feat(java): Increase test coverage (#2939)

Closes #2938

Author: jrhenderson1988

foreign/java/java-sdk/src/main/java/org/apache/iggy/exception/IggyException.java

@@ -46,13 +46,4 @@ protected IggyException(String message) {
     protected IggyException(String message, Throwable cause) {
         super(message, cause);
     }
-
-    /**
-     * Constructs a new IggyException with the specified cause.
-     *
-     * @param cause the cause of the exception
-     */
-    protected IggyException(Throwable cause) {
-        super(cause);
-    }
 }

foreign/java/java-sdk/src/main/java/org/apache/iggy/system/ClientInfoDetails.java

@@ -19,7 +19,6 @@
 
 package org.apache.iggy.system;
 
-import java.util.ArrayList;
 import java.util.List;
 import java.util.Optional;
 
@@ -30,7 +29,7 @@ public record ClientInfoDetails(
         String transport,
         Long consumerGroupsCount,
         List<ConsumerGroupInfo> consumerGroups) {
-    public ClientInfoDetails(ClientInfo clientInfo, ArrayList<ConsumerGroupInfo> consumerGroups) {
+    public ClientInfoDetails(ClientInfo clientInfo, List<ConsumerGroupInfo> consumerGroups) {
         this(
                 clientInfo.clientId(),
                 clientInfo.userId(),

foreign/java/java-sdk/src/main/java/org/apache/iggy/topic/CompressionAlgorithm.java

@@ -31,7 +31,7 @@ public enum CompressionAlgorithm {
         this.code = code;
     }
 
-    public static CompressionAlgorithm fromCode(byte code) {
+    public static CompressionAlgorithm fromCode(int code) {
         for (CompressionAlgorithm algorithm : values()) {
             if (algorithm.code == code) {
                 return algorithm;

foreign/java/java-sdk/src/test/java/org/apache/iggy/config/RetryPolicyTest.java

@@ -0,0 +1,96 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iggy.config;
+
+import org.junit.jupiter.api.Test;
+
+import java.time.Duration;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+class RetryPolicyTest {
+    @Test
+    void exponentialBackoffWithNoArgsReturnsExpectedRetryPolicy() {
+        var retryPolicy = RetryPolicy.exponentialBackoff();
+
+        assertThat(retryPolicy.getMaxRetries()).isEqualTo(3);
+        assertThat(retryPolicy.getInitialDelay()).isEqualTo(Duration.ofMillis(100));
+        assertThat(retryPolicy.getMaxDelay()).isEqualTo(Duration.ofSeconds(5));
+        assertThat(retryPolicy.getMultiplier()).isEqualTo(2.0);
+    }
+
+    @Test
+    void exponentialBackoffWithAllArgsReturnsExpectedRetryPolicy() {
+        var retryPolicy = RetryPolicy.exponentialBackoff(30, Duration.ofMillis(50), Duration.ofMinutes(60), 1.5);
+
+        assertThat(retryPolicy.getMaxRetries()).isEqualTo(30);
+        assertThat(retryPolicy.getInitialDelay()).isEqualTo(Duration.ofMillis(50));
+        assertThat(retryPolicy.getMaxDelay()).isEqualTo(Duration.ofMinutes(60));
+        assertThat(retryPolicy.getMultiplier()).isEqualTo(1.5);
+    }
+
+    @Test
+    void fixedDelayReturnsExpectedRetryPolicy() {
+        var retryPolicy = RetryPolicy.fixedDelay(50, Duration.ofMillis(500));
+
+        assertThat(retryPolicy.getMaxRetries()).isEqualTo(50);
+        assertThat(retryPolicy.getInitialDelay()).isEqualTo(Duration.ofMillis(500));
+        assertThat(retryPolicy.getMaxDelay()).isEqualTo(Duration.ofMillis(500));
+        assertThat(retryPolicy.getMultiplier()).isEqualTo(1.0);
+    }
+
+    @Test
+    void noRetryReturnsExpectedRetryPolicy() {
+        var retryPolicy = RetryPolicy.noRetry();
+
+        assertThat(retryPolicy.getMaxRetries()).isEqualTo(0);
+        assertThat(retryPolicy.getInitialDelay()).isEqualTo(Duration.ZERO);
+        assertThat(retryPolicy.getMaxDelay()).isEqualTo(Duration.ZERO);
+        assertThat(retryPolicy.getMultiplier()).isEqualTo(1.0);
+    }
+
+    @Test
+    void getMaxRetriesReturnsMaxRetries() {
+        var retryPolicy = RetryPolicy.exponentialBackoff(2, Duration.ofMillis(200), Duration.ofMillis(1000), 1.0);
+
+        assertThat(retryPolicy.getMaxRetries()).isEqualTo(2);
+    }
+
+    @Test
+    void getInitialDelayReturnsInitialDelay() {
+        var retryPolicy = RetryPolicy.exponentialBackoff(2, Duration.ofMillis(200), Duration.ofMillis(1000), 1.0);
+
+        assertThat(retryPolicy.getInitialDelay()).isEqualTo(Duration.ofMillis(200));
+    }
+
+    @Test
+    void getMaxDelayReturnsMaxDelay() {
+        var retryPolicy = RetryPolicy.exponentialBackoff(2, Duration.ofMillis(200), Duration.ofMillis(1000), 1.0);
+
+        assertThat(retryPolicy.getMaxDelay()).isEqualTo(Duration.ofMillis(1000));
+    }
+
+    @Test
+    void getMultiplierReturnsMultiplier() {
+        var retryPolicy = RetryPolicy.exponentialBackoff(2, Duration.ofMillis(200), Duration.ofMillis(1000), 1.0);
+
+        assertThat(retryPolicy.getMultiplier()).isEqualTo(1.0);
+    }
+}

foreign/java/java-sdk/src/test/java/org/apache/iggy/consumergroup/ConsumerGroupDetailsTest.java

@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iggy.consumergroup;
+
+import org.junit.jupiter.api.Test;
+
+import java.util.List;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+class ConsumerGroupDetailsTest {
+    @Test
+    void constructorWithConsumerGroupCreatesExpectedConsumerGroupDetails() {
+        var consumerGroup = new ConsumerGroup(2L, "group", 3L, 1L);
+        var members = List.of(new ConsumerGroupMember(1L, 3L, List.of()));
+
+        var consumerGroupDetails = new ConsumerGroupDetails(consumerGroup, members);
+
+        assertThat(consumerGroupDetails.id()).isEqualTo(2L);
+        assertThat(consumerGroupDetails.name()).isEqualTo("group");
+        assertThat(consumerGroupDetails.partitionsCount()).isEqualTo(3);
+        assertThat(consumerGroupDetails.membersCount()).isEqualTo(1L);
+        assertThat(consumerGroupDetails.members()).isEqualTo(members);
+    }
+}

foreign/java/java-sdk/src/test/java/org/apache/iggy/consumergroup/ConsumerTest.java

@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iggy.consumergroup;
+
+import org.apache.iggy.consumergroup.Consumer.Kind;
+import org.apache.iggy.identifier.ConsumerId;
+import org.junit.jupiter.api.Nested;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.CsvSource;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+class ConsumerTest {
+    @Test
+    void ofWithNumericIdCreatesExpectedConsumerWithConsumerKind() {
+        var consumer = Consumer.of(123L);
+
+        assertThat(consumer.id().getId()).isEqualTo(123L);
+        assertThat(consumer.kind()).isEqualTo(Kind.Consumer);
+    }
+
+    @Test
+    void ofWithConsumerIdCreatesExpectedConsumerWithConsumerKind() {
+        var consumer = Consumer.of(ConsumerId.of(321L));
+
+        assertThat(consumer.id().getId()).isEqualTo(321L);
+        assertThat(consumer.kind()).isEqualTo(Consumer.Kind.Consumer);
+    }
+
+    @Test
+    void groupWithNumericIdCreatesExpectedConsumerWithConsumerGroupKind() {
+        var consumer = Consumer.group(456L);
+
+        assertThat(consumer.id().getId()).isEqualTo(456L);
+        assertThat(consumer.kind()).isEqualTo(Consumer.Kind.ConsumerGroup);
+    }
+
+    @Test
+    void groupWithConsumerIdCreatesExpectedConsumerWithConsumerGroupKind() {
+        var consumer = Consumer.group(ConsumerId.of(654L));
+
+        assertThat(consumer.id().getId()).isEqualTo(654L);
+        assertThat(consumer.kind()).isEqualTo(Consumer.Kind.ConsumerGroup);
+    }
+
+    @Nested
+    class ConsumerKindTest {
+        @ParameterizedTest
+        @CsvSource({"Consumer, 1", "ConsumerGroup, 2"})
+        void asCodeReturnsExpectedCode(Consumer.Kind kind, int expectedCode) {
+            var code = kind.asCode();
+
+            assertThat(code).isEqualTo(expectedCode);
+        }
+    }
+}

foreign/java/java-sdk/src/test/java/org/apache/iggy/exception/IggyAuthenticationExceptionTest.java

@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iggy.exception;
+
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.EnumSource;
+import org.junit.jupiter.params.provider.EnumSource.Mode;
+
+import java.util.Optional;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+class IggyAuthenticationExceptionTest {
+    @Test
+    void constructorCreatesExpectedIggyAuthenticationException() {
+        var exception = new IggyAuthenticationException(
+                IggyErrorCode.UNAUTHENTICATED, 40, "unauthenticated", Optional.of("foo"), Optional.of("bar"));
+
+        assertThat(exception).isInstanceOf(IggyAuthenticationException.class);
+        assertThat(exception.getErrorCode()).isEqualTo(IggyErrorCode.UNAUTHENTICATED);
+        assertThat(exception.getRawErrorCode()).isEqualTo(40);
+        assertThat(exception.getReason()).isEqualTo("unauthenticated");
+        assertThat(exception.getField()).isEqualTo(Optional.of("foo"));
+        assertThat(exception.getErrorId()).isEqualTo(Optional.of("bar"));
+    }
+
+    @ParameterizedTest
+    @EnumSource(
+            value = IggyErrorCode.class,
+            names = {
+                "UNAUTHENTICATED",
+                "INVALID_CREDENTIALS",
+                "INVALID_USERNAME",
+                "INVALID_PASSWORD",
+                "INVALID_PAT_TOKEN",
+                "PASSWORD_DOES_NOT_MATCH",
+                "PASSWORD_HASH_INTERNAL_ERROR"
+            })
+    void matchesReturnsTrueForAuthenticationRelatedCodes(IggyErrorCode code) {
+        assertThat(IggyAuthenticationException.matches(code)).isTrue();
+    }
+
+    @ParameterizedTest
+    @EnumSource(
+            value = IggyErrorCode.class,
+            names = {
+                "UNAUTHENTICATED",
+                "INVALID_CREDENTIALS",
+                "INVALID_USERNAME",
+                "INVALID_PASSWORD",
+                "INVALID_PAT_TOKEN",
+                "PASSWORD_DOES_NOT_MATCH",
+                "PASSWORD_HASH_INTERNAL_ERROR"
+            },
+            mode = Mode.EXCLUDE)
+    void matchesReturnsFalseForNonAuthenticationRelatedCodes(IggyErrorCode code) {
+        assertThat(IggyAuthenticationException.matches(code)).isFalse();
+    }
+}

foreign/java/java-sdk/src/test/java/org/apache/iggy/exception/IggyAuthorizationExceptionTest.java

@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iggy.exception;
+
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.EnumSource;
+import org.junit.jupiter.params.provider.EnumSource.Mode;
+
+import java.util.Optional;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+class IggyAuthorizationExceptionTest {
+    @Test
+    void constructorCreatesExpectedIggyAuthorizationException() {
+        var exception = new IggyAuthorizationException(
+                IggyErrorCode.UNAUTHORIZED, 41, "unauthorized", Optional.of("bar"), Optional.of("foo"));
+
+        assertThat(exception).isInstanceOf(IggyAuthorizationException.class);
+        assertThat(exception.getErrorCode()).isEqualTo(IggyErrorCode.UNAUTHORIZED);
+        assertThat(exception.getRawErrorCode()).isEqualTo(41);
+        assertThat(exception.getReason()).isEqualTo("unauthorized");
+        assertThat(exception.getField()).isEqualTo(Optional.of("bar"));
+        assertThat(exception.getErrorId()).isEqualTo(Optional.of("foo"));
+    }
+
+    @ParameterizedTest
+    @EnumSource(
+            value = IggyErrorCode.class,
+            names = {"UNAUTHORIZED"})
+    void matchesReturnsTrueForAuthorizationRelatedCodes(IggyErrorCode code) {
+        assertThat(IggyAuthorizationException.matches(code)).isTrue();
+    }
+
+    @ParameterizedTest
+    @EnumSource(
+            value = IggyErrorCode.class,
+            names = {"UNAUTHORIZED"},
+            mode = Mode.EXCLUDE)
+    void matchesReturnsFalseForNonAuthorizationRelatedCodes(IggyErrorCode code) {
+        assertThat(IggyAuthorizationException.matches(code)).isFalse();
+    }
+}