IGNITE-26725 Add logging of fsync files for aipersist (#6790)

Author: tkalkirill

modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/checkpoint/Checkpoint.java

@@ -33,6 +33,9 @@ class Checkpoint {
     /** Number of written dirty pages. */
     int writtenPages;
 
+    /** Number of fsync-ed files. */
+    int syncedFiles;
+
     /**
      * Constructor.
      *
@@ -59,6 +62,7 @@ boolean hasDelta() {
     void finishCheckpoint() {
         if (hasDelta()) {
             writtenPages = progress.writtenPages();
+            syncedFiles = progress.syncedFiles();
 
             progress.pagesToWrite(null);
 

modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/checkpoint/CheckpointProgress.java

@@ -81,4 +81,7 @@ public interface CheckpointProgress {
      * Returns a number of written checkpoint pages.
      */
     int writtenPages();
+
+    /** Returns a number of fsync-ed checkpoint files. */
+    int syncedFiles();
 }

modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/checkpoint/CheckpointProgressImpl.java

@@ -64,6 +64,9 @@ public class CheckpointProgressImpl implements CheckpointProgress {
     /** Counter for fsynced checkpoint pages. */
     private final AtomicInteger syncedPagesCntr = new AtomicInteger();
 
+    /** Counter for fsynced checkpoint files. */
+    private final AtomicInteger syncedFilesCntr = new AtomicInteger();
+
     /** Counter for evicted checkpoint pages. */
     private final AtomicInteger evictedPagesCntr = new AtomicInteger();
 
@@ -154,6 +157,16 @@ public AtomicInteger syncedPagesCounter() {
         return syncedPagesCntr;
     }
 
+    /** Returns counter of fsync-ed checkpoint files. */
+    public AtomicInteger syncedFilesCounter() {
+        return syncedFilesCntr;
+    }
+
+    @Override
+    public int syncedFiles() {
+        return syncedFilesCntr.get();
+    }
+
     @Override
     public AtomicInteger evictedPagesCounter() {
         return evictedPagesCntr;
@@ -214,6 +227,7 @@ public void initCounters(int checkpointPages) {
         writtenPagesCntr.set(0);
         syncedPagesCntr.set(0);
         evictedPagesCntr.set(0);
+        syncedFilesCntr.set(0);
     }
 
     /**

modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/checkpoint/Checkpointer.java

@@ -121,6 +121,7 @@ public class Checkpointer extends IgniteWorker {
     private static final String CHECKPOINT_FINISHED_LOG_TEMPLATE = "Checkpoint finished ["
             + "checkpointId={}, "
             + "writtenPages={}, "
+            + "fsyncFiles={}, "
             + "pagesWriteTime={}ms, "
             + "fsyncTime={}ms, "
             + "replicatorLogSyncTime={}ms, "
@@ -432,6 +433,7 @@ void doCheckpoint() throws IgniteInternalCheckedException {
                             CHECKPOINT_FINISHED_LOG_TEMPLATE,
                             chp.progress.id(),
                             totalWrittenPages,
+                            chp.syncedFiles,
                             tracker.pagesWriteDuration(MILLISECONDS),
                             tracker.fsyncDuration(MILLISECONDS),
                             tracker.replicatorLogSyncDuration(MILLISECONDS),
@@ -639,9 +641,9 @@ private void fsyncPartitionFiles(
                 return;
             }
 
-            fsyncDeltaFilePageStoreOnCheckpointThread(filePageStore);
+            fsyncDeltaFilePageStoreOnCheckpointThread(filePageStore, currentCheckpointProgress);
 
-            fsyncFilePageStoreOnCheckpointThread(filePageStore);
+            fsyncFilePageStoreOnCheckpointThread(filePageStore, currentCheckpointProgress);
 
             renameDeltaFileOnCheckpointThread(filePageStore, partitionId);
 
@@ -653,11 +655,16 @@ private void fsyncPartitionFiles(
         }
     }
 
-    private void fsyncFilePageStoreOnCheckpointThread(FilePageStore filePageStore) throws IgniteInternalCheckedException {
+    private void fsyncFilePageStoreOnCheckpointThread(
+            FilePageStore filePageStore,
+            CheckpointProgressImpl currentCheckpointProgress
+    ) throws IgniteInternalCheckedException {
         blockingSectionBegin();
 
         try {
             filePageStore.sync();
+
+            currentCheckpointProgress.syncedFilesCounter().incrementAndGet();
         } finally {
             blockingSectionEnd();
         }
@@ -890,7 +897,10 @@ long nextCheckpointInterval() {
         return safeAbs(interval + startDelay);
     }
 
-    private void fsyncDeltaFilePageStoreOnCheckpointThread(FilePageStore filePageStore) throws IgniteInternalCheckedException {
+    private void fsyncDeltaFilePageStoreOnCheckpointThread(
+            FilePageStore filePageStore,
+            CheckpointProgressImpl currentCheckpointProgress
+    ) throws IgniteInternalCheckedException {
         blockingSectionBegin();
 
         try {
@@ -901,6 +911,8 @@ private void fsyncDeltaFilePageStoreOnCheckpointThread(FilePageStore filePageSto
             }
 
             deltaFilePageStoreFuture.join().sync();
+
+            currentCheckpointProgress.syncedFilesCounter().incrementAndGet();
         } finally {
             blockingSectionEnd();
         }

modules/page-memory/src/test/java/org/apache/ignite/internal/pagememory/persistence/checkpoint/CheckpointProgressImplTest.java

@@ -90,10 +90,12 @@ void testCounters() {
         assertEquals(0, progressImpl.writtenPagesCounter().get());
         assertEquals(0, progressImpl.syncedPagesCounter().get());
         assertEquals(0, progressImpl.evictedPagesCounter().get());
+        assertEquals(0, progressImpl.syncedFilesCounter().get());
 
         progressImpl.writtenPagesCounter().incrementAndGet();
         progressImpl.syncedPagesCounter().incrementAndGet();
         progressImpl.evictedPagesCounter().incrementAndGet();
+        progressImpl.syncedFilesCounter().incrementAndGet();
 
         progressImpl.initCounters(100500);
 
@@ -102,10 +104,12 @@ void testCounters() {
         assertEquals(0, progressImpl.writtenPagesCounter().get());
         assertEquals(0, progressImpl.syncedPagesCounter().get());
         assertEquals(0, progressImpl.evictedPagesCounter().get());
+        assertEquals(0, progressImpl.syncedFilesCounter().get());
 
         progressImpl.writtenPagesCounter().incrementAndGet();
         progressImpl.syncedPagesCounter().incrementAndGet();
         progressImpl.evictedPagesCounter().incrementAndGet();
+        progressImpl.syncedFilesCounter().incrementAndGet();
 
         progressImpl.clearCounters();
 
@@ -114,6 +118,7 @@ void testCounters() {
         assertEquals(0, progressImpl.writtenPagesCounter().get());
         assertEquals(0, progressImpl.syncedPagesCounter().get());
         assertEquals(0, progressImpl.evictedPagesCounter().get());
+        assertEquals(0, progressImpl.syncedFilesCounter().get());
 
         progressImpl.currentCheckpointPagesCount(42);