IGNITE-26580 Remove equals-based validation from AffinityBackupFilter component

Author: sergey-chugunov-1985

modules/core/src/main/java/org/apache/ignite/cache/affinity/rendezvous/ClusterNodeAttributeAffinityBackupFilter.java

@@ -17,7 +17,6 @@
 
 package org.apache.ignite.cache.affinity.rendezvous;
 
-import java.util.Arrays;
 import java.util.List;
 import java.util.Objects;
 import org.apache.ignite.cluster.ClusterNode;
@@ -137,22 +136,4 @@ public ClusterNodeAttributeAffinityBackupFilter(String... attrNames) {
     public String[] getAttributeNames() {
         return attrNames.clone();
     }
-
-    /** {@inheritDoc} */
-    @Override public boolean equals(Object o) {
-        if (o == this)
-            return true;
-
-        if (o == null || getClass() != o.getClass())
-            return false;
-
-        ClusterNodeAttributeAffinityBackupFilter other = (ClusterNodeAttributeAffinityBackupFilter)o;
-
-        return Arrays.equals(attrNames, other.attrNames);
-    }
-
-    /** {@inheritDoc} */
-    @Override public int hashCode() {
-        return Arrays.hashCode(attrNames);
-    }
 }

modules/core/src/main/java/org/apache/ignite/cache/affinity/rendezvous/ClusterNodeAttributeColocatedBackupFilter.java

@@ -122,22 +122,4 @@ public ClusterNodeAttributeColocatedBackupFilter(String attrName) {
 
         return primaryAttrVal.equals(candidateAttrVal);
     }
-
-    /** {@inheritDoc} */
-    @Override public boolean equals(Object o) {
-        if (o == this)
-            return true;
-
-        if (o == null || getClass() != o.getClass())
-            return false;
-
-        ClusterNodeAttributeColocatedBackupFilter other = (ClusterNodeAttributeColocatedBackupFilter)o;
-
-        return attrName.equals(other.attrName);
-    }
-
-    /** {@inheritDoc} */
-    @Override public int hashCode() {
-        return attrName.hashCode();
-    }
 }

modules/core/src/main/java/org/apache/ignite/cache/affinity/rendezvous/MdcAffinityBackupFilter.java

@@ -121,24 +121,6 @@ public MdcAffinityBackupFilter(int dcsNum, int backups) {
         return candDcCopiesAssigned < partCopiesPerDc;
     }
 
-    /** {@inheritDoc} */
-    @Override public boolean equals(Object o) {
-        if (this == o)
-            return true;
-
-        if (!(o instanceof MdcAffinityBackupFilter))
-            return false;
-
-        MdcAffinityBackupFilter filter = (MdcAffinityBackupFilter)o;
-
-        return partCopiesPerDc == filter.partCopiesPerDc;
-    }
-
-    /** {@inheritDoc} */
-    @Override public int hashCode() {
-        return Integer.hashCode(partCopiesPerDc);
-    }
-
     /** {@inheritDoc} */
     @Override public String toString() {
         return S.toString(MdcAffinityBackupFilter.class, this);

modules/core/src/main/java/org/apache/ignite/internal/processors/cache/ClusterCachesInfo.java

@@ -434,23 +434,9 @@ private void checkCache(CacheJoinNodeDiscoveryData.CacheInfo locInfo, CacheData
             "Affinity partitions count", locAttr.affinityPartitionsCount(),
             rmtAttr.affinityPartitionsCount(), true);
 
-        if (locAttr.affinityBackupFilterClass() != null && rmtAttr.affinityBackupFilterClass() != null) {
-            // We should not check backups if filters are lambdas both on local and remote nodes as lambdas cannot be compared with equals.
-            if (U.lambdaEnclosingClassName(locAttr.affinityBackupFilterClass()) == null ||
-                U.lambdaEnclosingClassName(rmtAttr.affinityBackupFilterClass()) == null
-            ) {
-                CU.checkAttributeMismatch(log, rmtAttr.cacheName(), rmt, "affinityBackupFilterClass", "Affinity backup filter class",
-                    locAttr.affinityBackupFilterClass(), rmtAttr.affinityBackupFilterClass(), true);
-
-                CU.checkAttributeMismatch(log, rmtAttr.cacheName(), rmt, "affinityBackupFilter", "Affinity backup filter",
-                    locAttr.affinityBackupFilter(), rmtAttr.affinityBackupFilter(), true);
-            }
-        }
-        else {
-            // If both filter classes are null, this check won't fail.
-            CU.checkAttributeMismatch(log, rmtAttr.cacheName(), rmt, "affinityBackupFilterClass", "Affinity backup filter class",
-                locAttr.affinityBackupFilterClass(), rmtAttr.affinityBackupFilterClass(), true);
-        }
+        // TODO IGNITE-26967 - implement better validation of affinity backup filter
+        CU.checkAttributeMismatch(log, rmtAttr.cacheName(), rmt, "affinityBackupFilterClass", "Affinity backup filter class",
+            locAttr.affinityBackupFilterClass(), rmtAttr.affinityBackupFilterClass(), true);
 
         CU.validateKeyConfigiration(rmtAttr.groupName(), rmtAttr.cacheName(), rmt, rmtAttr.configuration().getKeyConfiguration(),
             locAttr.configuration().getKeyConfiguration(), log, true);

modules/core/src/test/java/org/apache/ignite/cache/affinity/AffinityFunctionBackupFilterAbstractSelfTest.java

@@ -82,11 +82,6 @@ public abstract class AffinityFunctionBackupFilterAbstractSelfTest extends GridC
 
                 return backupAssignedAttr.get(nodeAttrVal).equals(0);
             }
-
-            /** {@inheritDoc} */
-            @Override public boolean equals(Object obj) {
-                return true;
-            }
         };
 
     /**