Skip to content

Commit 792bb21

Browse files
authored
IGNITE-26827 Minor refactoring after ErrorMessage updates (#12496)
1 parent 4cfac73 commit 792bb21

File tree

5 files changed

+22
-10
lines changed

5 files changed

+22
-10
lines changed

modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/atomic/GridDhtAtomicUpdateResponse.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
import org.apache.ignite.IgniteCheckedException;
2323
import org.apache.ignite.IgniteLogger;
2424
import org.apache.ignite.internal.Order;
25-
import org.apache.ignite.internal.managers.communication.ErrorMessage;
2625
import org.apache.ignite.internal.processors.cache.GridCacheContext;
2726
import org.apache.ignite.internal.processors.cache.GridCacheDeployable;
2827
import org.apache.ignite.internal.processors.cache.GridCacheIdMessage;
@@ -117,12 +116,12 @@ public void onError(IgniteCheckedException err) {
117116
if (errs == null)
118117
errs = new UpdateErrors();
119118

120-
errs.errorMessage(new ErrorMessage(err));
119+
errs.error(err);
121120
}
122121

123122
/** {@inheritDoc} */
124123
@Override public Throwable error() {
125-
return errs != null ? errs.errorMessage().error() : null;
124+
return errs != null ? errs.error() : null;
126125
}
127126

128127
/**

modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/atomic/GridNearAtomicSingleUpdateFuture.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -206,9 +206,9 @@ else if (rcvAll)
206206
UpdateErrors errors = res.errors();
207207

208208
if (errors != null) {
209-
assert errors.errorMessage() != null;
209+
assert errors.error() != null;
210210

211-
completeFuture(null, errors.errorMessage().error(), res.futureId());
211+
completeFuture(null, errors.error(), res.futureId());
212212

213213
return;
214214
}

modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/atomic/GridNearAtomicUpdateFuture.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -332,9 +332,9 @@ else if (rcvAll)
332332
UpdateErrors errors = res.errors();
333333

334334
if (errors != null) {
335-
assert errors.errorMessage() != null;
335+
assert errors.error() != null;
336336

337-
completeFuture(null, errors.errorMessage().error(), res.futureId());
337+
completeFuture(null, errors.error(), res.futureId());
338338

339339
return;
340340
}

modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/atomic/GridNearAtomicUpdateResponse.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
import org.apache.ignite.IgniteCheckedException;
2424
import org.apache.ignite.IgniteLogger;
2525
import org.apache.ignite.internal.Order;
26-
import org.apache.ignite.internal.managers.communication.ErrorMessage;
2726
import org.apache.ignite.internal.processors.affinity.AffinityTopologyVersion;
2827
import org.apache.ignite.internal.processors.cache.CacheObject;
2928
import org.apache.ignite.internal.processors.cache.GridCacheContext;
@@ -188,12 +187,12 @@ public void error(IgniteCheckedException err) {
188187
if (errs == null)
189188
errs = new UpdateErrors();
190189

191-
errs.errorMessage(new ErrorMessage(err));
190+
errs.error(err);
192191
}
193192

194193
/** {@inheritDoc} */
195194
@Override public Throwable error() {
196-
return errs != null ? errs.errorMessage().error() : null;
195+
return errs != null ? errs.error() : null;
197196
}
198197

199198
/**

modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/atomic/UpdateErrors.java

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,20 @@ public UpdateErrors(Throwable err) {
6060
errMsg = new ErrorMessage(err);
6161
}
6262

63+
/**
64+
* @param err Error.
65+
*/
66+
public void error(Throwable err) {
67+
errMsg = new ErrorMessage(err);
68+
}
69+
70+
/**
71+
* @return Error.
72+
*/
73+
public Throwable error() {
74+
return ErrorMessage.error(errMsg);
75+
}
76+
6377
/**
6478
* @param errMsg New error message.
6579
*/

0 commit comments

Comments
 (0)