Skip to content

Commit 92cd9ed

Browse files
committed
IGNITE-27832 Remove MemoryConfiguration, PersistentStoreConfiguration
1 parent d048c0a commit 92cd9ed

33 files changed

+29
-4169
lines changed

modules/compatibility/src/test/java/org/apache/ignite/compatibility/persistence/FoldersReuseCompatibilityTest.java

Lines changed: 6 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,9 @@
2525
import org.apache.ignite.Ignite;
2626
import org.apache.ignite.IgniteCache;
2727
import org.apache.ignite.compatibility.testframework.junits.SkipTestIfIsJdkNewer;
28+
import org.apache.ignite.configuration.DataRegionConfiguration;
29+
import org.apache.ignite.configuration.DataStorageConfiguration;
2830
import org.apache.ignite.configuration.IgniteConfiguration;
29-
import org.apache.ignite.configuration.MemoryConfiguration;
30-
import org.apache.ignite.configuration.MemoryPolicyConfiguration;
31-
import org.apache.ignite.configuration.PersistentStoreConfiguration;
3231
import org.apache.ignite.internal.IgniteEx;
3332
import org.apache.ignite.internal.processors.cache.GridCacheAbstractFullApiSelfTest;
3433
import org.apache.ignite.internal.processors.cache.persistence.filename.NodeFileTree;
@@ -174,16 +173,10 @@ private static class ConfigurationClosure implements IgniteInClosure<IgniteConfi
174173
* @param cfg ignite config to setup.
175174
*/
176175
private static void configPersistence(IgniteConfiguration cfg) {
177-
final PersistentStoreConfiguration psCfg = new PersistentStoreConfiguration();
178-
179-
cfg.setPersistentStoreConfiguration(psCfg);
180-
181-
final MemoryConfiguration memCfg = new MemoryConfiguration();
182-
final MemoryPolicyConfiguration memPolCfg = new MemoryPolicyConfiguration();
183-
184-
memPolCfg.setMaxSize(32L * 1024 * 1024); // we don't need much memory for this test
185-
memCfg.setMemoryPolicies(memPolCfg);
186-
cfg.setMemoryConfiguration(memCfg);
176+
cfg.setDataStorageConfiguration(new DataStorageConfiguration().setDataRegionConfigurations(new DataRegionConfiguration()
177+
// we don't need much memory for this test
178+
.setMaxSize(32L * 1024 * 1024)
179+
.setPersistenceEnabled(true)));
187180
}
188181

189182
/**

modules/compatibility/src/test/java/org/apache/ignite/compatibility/persistence/PersistenceBasicCompatibilityTest.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@
3535
import org.apache.ignite.configuration.DataRegionConfiguration;
3636
import org.apache.ignite.configuration.DataStorageConfiguration;
3737
import org.apache.ignite.configuration.IgniteConfiguration;
38-
import org.apache.ignite.configuration.PersistentStoreConfiguration;
3938
import org.apache.ignite.internal.IgniteEx;
4039
import org.apache.ignite.internal.processors.cache.GridCacheAbstractFullApiSelfTest;
4140
import org.apache.ignite.internal.util.typedef.internal.U;
@@ -248,7 +247,9 @@ public ConfigurationClosure(boolean compactFooter) {
248247

249248
cfg.setPeerClassLoadingEnabled(false);
250249

251-
cfg.setPersistentStoreConfiguration(new PersistentStoreConfiguration());
250+
cfg.setDataStorageConfiguration(new DataStorageConfiguration()
251+
.setDefaultDataRegionConfiguration(new DataRegionConfiguration()
252+
.setPersistenceEnabled(true)));
252253

253254
cfg.setBinaryConfiguration(new BinaryConfiguration().setCompactFooter(compactFooter));
254255
}

modules/core/src/main/java/org/apache/ignite/MemoryMetrics.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,15 +17,15 @@
1717

1818
package org.apache.ignite;
1919

20-
import org.apache.ignite.configuration.MemoryConfiguration;
21-
import org.apache.ignite.configuration.MemoryPolicyConfiguration;
20+
import org.apache.ignite.configuration.DataRegionConfiguration;
21+
import org.apache.ignite.configuration.DataStorageConfiguration;
2222
import org.apache.ignite.spi.metric.ReadOnlyMetricRegistry;
2323

2424
/**
2525
* This interface provides page memory related metrics of a specific Apache Ignite node. The overall page memory
26-
* architecture is covered in {@link MemoryConfiguration}.
26+
* architecture is covered in {@link DataStorageConfiguration}.
2727
* <p>
28-
* Since there are can be several memory regions configured with {@link MemoryPolicyConfiguration} on an individual
28+
* Since there are can be several data regions configured with {@link DataRegionConfiguration} on an individual
2929
* Apache Ignite node, the metrics for every region will be collected and obtained separately.
3030
* <p>
3131
* There are two ways to get the metrics of an Apache Ignite node.
@@ -43,7 +43,7 @@
4343
* <p>
4444
* Memory metrics collection is not a free operation and might affect performance of an application. This is the reason
4545
* why the metrics are turned off by default. To enable the collection you can use both
46-
* {@link MemoryPolicyConfiguration#setMetricsEnabled(boolean)} configuration property.
46+
* {@link DataStorageConfiguration#setMetricsEnabled(boolean)} configuration property.
4747
*
4848
* @deprecated Check the {@link ReadOnlyMetricRegistry} with "name=io.dataregion.{data_region_name}" instead.
4949
*/

modules/core/src/main/java/org/apache/ignite/configuration/IgniteConfiguration.java

Lines changed: 0 additions & 72 deletions
Original file line numberDiff line numberDiff line change
@@ -535,14 +535,6 @@ public class IgniteConfiguration {
535535
/** Custom executor configurations. */
536536
private ExecutorConfiguration[] execCfgs;
537537

538-
/** Page memory configuration. */
539-
@Deprecated
540-
private MemoryConfiguration memCfg;
541-
542-
/** Persistence store configuration. */
543-
@Deprecated
544-
private PersistentStoreConfiguration pstCfg;
545-
546538
/** Page memory configuration. */
547539
private DataStorageConfiguration dsCfg;
548540

@@ -651,8 +643,6 @@ public IgniteConfiguration(IgniteConfiguration cfg) {
651643
binaryCfg = cfg.getBinaryConfiguration();
652644
clusterStateOnStart = cfg.getClusterStateOnStart();
653645
dsCfg = cfg.getDataStorageConfiguration();
654-
memCfg = cfg.getMemoryConfiguration();
655-
pstCfg = cfg.getPersistentStoreConfiguration();
656646
cacheCfg = cfg.getCacheConfiguration();
657647
cacheKeyCfg = cfg.getCacheKeyConfiguration();
658648
cacheSanityCheckEnabled = cfg.isCacheSanityCheckEnabled();
@@ -2634,68 +2624,6 @@ public IgniteConfiguration setDataStorageConfiguration(DataStorageConfiguration
26342624
return this;
26352625
}
26362626

2637-
/**
2638-
* Gets page memory configuration.
2639-
*
2640-
* @return Memory configuration.
2641-
* @deprecated Use {@link DataStorageConfiguration} instead.
2642-
*/
2643-
@Deprecated
2644-
public MemoryConfiguration getMemoryConfiguration() {
2645-
return memCfg;
2646-
}
2647-
2648-
/**
2649-
* Sets page memory configuration.
2650-
*
2651-
* @param memCfg Memory configuration.
2652-
* @return {@code this} for chaining.
2653-
* @deprecated Use {@link DataStorageConfiguration} instead.
2654-
*/
2655-
@Deprecated
2656-
public IgniteConfiguration setMemoryConfiguration(MemoryConfiguration memCfg) {
2657-
this.memCfg = memCfg;
2658-
2659-
return this;
2660-
}
2661-
2662-
/**
2663-
* Gets persistence configuration used by Apache Ignite Persistent Store.
2664-
*
2665-
* @return Persistence configuration.
2666-
*
2667-
* @deprecated Part of old API. Use {@link DataStorageConfiguration} for configuring persistence instead.
2668-
*/
2669-
@Deprecated
2670-
public PersistentStoreConfiguration getPersistentStoreConfiguration() {
2671-
return pstCfg;
2672-
}
2673-
2674-
/**
2675-
* @return Flag {@code true} if persistence is enabled, {@code false} if disabled.
2676-
*
2677-
* @deprecated Part of legacy configuration API. Doesn't work if new configuration API is used.
2678-
*/
2679-
@Deprecated
2680-
public boolean isPersistentStoreEnabled() {
2681-
return pstCfg != null;
2682-
}
2683-
2684-
/**
2685-
* Sets persistence configuration activating Apache Ignite Persistent Store.
2686-
*
2687-
* @param pstCfg Persistence configuration.
2688-
* @return {@code this} for chaining.
2689-
*
2690-
* @deprecated Part of old API. Use {@link DataStorageConfiguration} for configuring persistence instead.
2691-
*/
2692-
@Deprecated
2693-
public IgniteConfiguration setPersistentStoreConfiguration(PersistentStoreConfiguration pstCfg) {
2694-
this.pstCfg = pstCfg;
2695-
2696-
return this;
2697-
}
2698-
26992627
/**
27002628
* Gets flag indicating whether the cluster will be active on start. If cluster is not active on start,
27012629
* there will be no cache partition map exchanges performed until the cluster is activated. This should

0 commit comments

Comments
 (0)