Skip to content

Commit b825740

Browse files
authored
IGNITE-26660 Use MessageSerializer for QueryCloseMessage (#12414)
1 parent d0a3df5 commit b825740

File tree

2 files changed

+9
-42
lines changed

2 files changed

+9
-42
lines changed

modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/message/MessageType.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919

2020
import java.util.function.Supplier;
2121
import org.apache.ignite.internal.codegen.FragmentDescriptionSerializer;
22+
import org.apache.ignite.internal.codegen.QueryCloseMessageSerializer;
2223
import org.apache.ignite.internal.codegen.QueryTxEntrySerializer;
2324
import org.apache.ignite.internal.processors.query.calcite.metadata.ColocationGroup;
2425
import org.apache.ignite.internal.processors.query.calcite.metadata.FragmentDescription;
@@ -48,7 +49,7 @@ public enum MessageType {
4849
QUERY_INBOX_CANCEL_MESSAGE(305, InboxCloseMessage::new),
4950

5051
/** */
51-
QUERY_CLOSE_MESSAGE(306, QueryCloseMessage::new),
52+
QUERY_CLOSE_MESSAGE(306, QueryCloseMessage::new, new QueryCloseMessageSerializer()),
5253

5354
/** */
5455
GENERIC_VALUE_MESSAGE(307, GenericValueMessage::new),

modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/message/QueryCloseMessage.java

Lines changed: 7 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -17,16 +17,15 @@
1717

1818
package org.apache.ignite.internal.processors.query.calcite.message;
1919

20-
import java.nio.ByteBuffer;
2120
import java.util.UUID;
22-
import org.apache.ignite.plugin.extensions.communication.MessageReader;
23-
import org.apache.ignite.plugin.extensions.communication.MessageWriter;
21+
import org.apache.ignite.internal.Order;
2422

2523
/**
2624
*
2725
*/
2826
public class QueryCloseMessage implements CalciteMessage {
2927
/** */
28+
@Order(value = 0, method = "queryId")
3029
private UUID qryId;
3130

3231
/** */
@@ -46,44 +45,11 @@ public UUID queryId() {
4645
return qryId;
4746
}
4847

49-
/** {@inheritDoc} */
50-
@Override public boolean writeTo(ByteBuffer buf, MessageWriter writer) {
51-
writer.setBuffer(buf);
52-
53-
if (!writer.isHeaderWritten()) {
54-
if (!writer.writeHeader(directType()))
55-
return false;
56-
57-
writer.onHeaderWritten();
58-
}
59-
60-
switch (writer.state()) {
61-
case 0:
62-
if (!writer.writeUuid(qryId))
63-
return false;
64-
65-
writer.incrementState();
66-
}
67-
68-
return true;
69-
}
70-
71-
/** {@inheritDoc} */
72-
@Override public boolean readFrom(ByteBuffer buf, MessageReader reader) {
73-
reader.setBuffer(buf);
74-
75-
switch (reader.state()) {
76-
case 0:
77-
qryId = reader.readUuid();
78-
79-
if (!reader.isLastRead())
80-
return false;
81-
82-
reader.incrementState();
83-
84-
}
85-
86-
return true;
48+
/**
49+
* @param qryId New query ID.
50+
*/
51+
public void queryId(UUID qryId) {
52+
this.qryId = qryId;
8753
}
8854

8955
/** {@inheritDoc} */

0 commit comments

Comments
 (0)