IGNITE-28069 Enable EVT_CONSISTENCY_VIOLATION by default

Author: alex-plekhanov

docs/_docs/key-value-api/read-repair.adoc

@@ -66,7 +66,7 @@ When 4 copies (3 backups) are given, any value found two or more times, when oth
 |===
 
 == Events
-link:https://ignite.apache.org/releases/{version}/javadoc/org/apache/ignite/events/EventType.html#EVT_CONSISTENCY_VIOLATION[Сonsistency Violation Event] will be recorded for each violation in case it's configured as recordable. You may listen to this event to get notified about inconsistency issues.
+link:https://ignite.apache.org/releases/{version}/javadoc/org/apache/ignite/events/EventType.html#EVT_CONSISTENCY_VIOLATION[Сonsistency Violation Event] will be recorded for each violation. You may listen to this event to get notified about inconsistency issues.
 
 Please, refer to the link:events/listening-to-events[Working with Events] section for the information on how to listen to events.
 

docs/_docs/tools/control-script.adoc

@@ -699,15 +699,6 @@ The command may not work on some special/unique configurations or even cause a c
 Command execution MUST be checked on the test environment using the data/configuration similar to the production before the execution on the real production environment.
 ====
 
-[WARNING]
-====
-[discrete]
-===  Additional configuration required
-The command uses special link:https://ignite.apache.org/releases/{version}/javadoc/org/apache/ignite/events/EventType.html#EVT_CONSISTENCY_VIOLATION[Consistency Violation Event] to detect the consistency violations. This event must be enabled before the command execution.
-
-Please, refer to the link:events/listening-to-events#enabling-events[Enabling Events] section for details.
-====
-
 `idle_verify` command provides the inconsistent cache group names and partitions list as a result.
 The `repair` command allows performing cache consistency check and repair (when possible) using the link:key-value-api/read-repair[Read Repair] approach for every inconsistent partition found by `idle_verify`.
 

modules/control-utility/src/test/java/org/apache/ignite/util/GridCommandHandlerConsistencyTest.java

@@ -63,8 +63,6 @@
 import static org.apache.ignite.internal.commandline.SecurityCommandHandlerPermissionsTest.enrichWithConnectionArguments;
 import static org.apache.ignite.internal.management.consistency.ConsistencyRepairTask.CONSISTENCY_VIOLATIONS_FOUND;
 import static org.apache.ignite.plugin.security.SecurityPermission.ADMIN_OPS;
-import static org.apache.ignite.plugin.security.SecurityPermission.EVENTS_DISABLE;
-import static org.apache.ignite.plugin.security.SecurityPermission.EVENTS_ENABLE;
 import static org.apache.ignite.plugin.security.SecurityPermissionSetBuilder.ALL_PERMISSIONS;
 import static org.apache.ignite.plugin.security.SecurityPermissionSetBuilder.NO_PERMISSIONS;
 import static org.apache.ignite.plugin.security.SecurityPermissionSetBuilder.systemPermissions;
@@ -186,8 +184,7 @@ protected CacheConfiguration<Integer, Integer> cacheConfiguration(boolean tx) {
                     ALL_PERMISSIONS,
                     false,
                     new TestSecurityData(TEST_NO_PERMISSIONS_LOGIN, DEFAULT_PWD, NO_PERMISSIONS, new Permissions()),
-                    new TestSecurityData(TEST_LOGIN, DEFAULT_PWD,
-                        systemPermissions(ADMIN_OPS, EVENTS_ENABLE, EVENTS_DISABLE), new Permissions()))
+                    new TestSecurityData(TEST_LOGIN, DEFAULT_PWD, systemPermissions(ADMIN_OPS), new Permissions()))
             );
         }
 

modules/core/src/main/java/org/apache/ignite/internal/management/consistency/ConsistencyRepairTask.java

@@ -102,11 +102,6 @@ protected ConsistencyRepairJob(ConsistencyRepairCommandArg arg, boolean debug) {
         @Override protected String run(ConsistencyRepairCommandArg arg) throws IgniteException {
             AtomicReference<Exception> err = new AtomicReference<>();
 
-            boolean evtEnabled = ignite.context().event().isRecordable(EVT_CONSISTENCY_VIOLATION);
-
-            if (!evtEnabled)
-                ignite.events().enableLocal(EVT_CONSISTENCY_VIOLATION);
-
             Map<Boolean, List<IgniteBiTuple<Integer, String>>> res = Arrays.stream(arg.partitions())
                 .mapToObj(p -> F.t(p, ForkJoinPool.commonPool().submit(() -> processPartition(p, arg))))
                 .map(t -> {
@@ -122,10 +117,6 @@ protected ConsistencyRepairJob(ConsistencyRepairCommandArg arg, boolean debug) {
                 .filter(t -> t.get2() != null)
                 .collect(Collectors.groupingBy(t -> t.get2().startsWith(PROCESSED_PREFIX)));
 
-            // Restore event state. Assume no concurrent consistency repair task can be run.
-            if (!evtEnabled)
-                ignite.events().disableLocal(EVT_CONSISTENCY_VIOLATION);
-
             if (err.get() != null || isCancelled())
                 throw new IgniteException("Consistency task was interrupted.", err.get());
 
@@ -168,7 +159,8 @@ private String processPartition(int p, ConsistencyRepairCommandArg arg) {
                 else
                     throw new IgniteException("Cache (or cache group) not found [name=" + cacheOrGrpName + "]");
 
-            assert ignite.context().event().isRecordable(EVT_CONSISTENCY_VIOLATION);
+            if (!ignite.context().event().isRecordable(EVT_CONSISTENCY_VIOLATION))
+                throw new UnsupportedOperationException("Consistency violation events recording is disabled on cluster.");
 
             GridDhtLocalPartition part = grpCtx.topology().localPartition(p);
 

modules/core/src/main/java/org/apache/ignite/internal/managers/eventstorage/GridEventStorageManager.java

@@ -76,6 +76,7 @@
 import static org.apache.ignite.events.EventType.EVT_CLUSTER_ACTIVATED;
 import static org.apache.ignite.events.EventType.EVT_CLUSTER_DEACTIVATED;
 import static org.apache.ignite.events.EventType.EVT_CLUSTER_STATE_CHANGED;
+import static org.apache.ignite.events.EventType.EVT_CONSISTENCY_VIOLATION;
 import static org.apache.ignite.events.EventType.EVT_JOB_MAPPED;
 import static org.apache.ignite.events.EventType.EVT_NODE_FAILED;
 import static org.apache.ignite.events.EventType.EVT_NODE_LEFT;
@@ -527,6 +528,7 @@ private boolean isInternalEvent(int type) {
             case EVT_CLUSTER_DEACTIVATED:
             case EVT_BASELINE_CHANGED:
             case EVT_CLUSTER_STATE_CHANGED:
+            case EVT_CONSISTENCY_VIOLATION:
                 return true;
 
             default: