Skip to content

Commit e4cd7a0

Browse files
renaming
1 parent a051e32 commit e4cd7a0

File tree

9 files changed

+25
-25
lines changed

9 files changed

+25
-25
lines changed

modules/core/src/main/java/org/apache/ignite/configuration/ClientConfiguration.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -230,16 +230,16 @@ public ClientConfiguration setTcpNoDelay(boolean tcpNoDelay) {
230230
}
231231

232232
/**
233-
* @deprecated Use {@link #getConnTimeout()} and {@link #getReqTimeout()} instead.
233+
* @deprecated Use {@link #getConnectionTimeout()} and {@link #getRequestTimeout()} instead.
234234
* @return Send/receive timeout in milliseconds.
235235
*/
236236
@Deprecated
237237
public int getTimeout() {
238-
return Math.max(connTimeout, reqTimeout);
238+
return reqTimeout;
239239
}
240240

241241
/**
242-
* @deprecated Use {@link #setConnTimeout(int)} and {@link #setReqTimeout(int)} instead.
242+
* @deprecated Use {@link #setConnectionTimeout(int)} and {@link #setRequestTimeout(int)} instead.
243243
* @param timeout Send/receive timeout in milliseconds.
244244
* @return {@code this} for chaining.
245245
*/
@@ -253,31 +253,31 @@ public ClientConfiguration setTimeout(int timeout) {
253253
/**
254254
* @return Connection timeout in milliseconds. 0 means infinite.
255255
*/
256-
public int getConnTimeout() {
256+
public int getConnectionTimeout() {
257257
return connTimeout;
258258
}
259259

260260
/**
261261
* @param connTimeout Connection timeout in milliseconds. 0 means infinite.
262262
* @return {@code this} for chaining.
263263
*/
264-
public ClientConfiguration setConnTimeout(int connTimeout) {
264+
public ClientConfiguration setConnectionTimeout(int connTimeout) {
265265
this.connTimeout = connTimeout;
266266
return this;
267267
}
268268

269269
/**
270270
* @return Request timeout in milliseconds. 0 means infinite.
271271
*/
272-
public int getReqTimeout() {
272+
public int getRequestTimeout() {
273273
return reqTimeout;
274274
}
275275

276276
/**
277277
* @param reqTimeout Request timeout in milliseconds. 0 means infinite.
278278
* @return {@code this} for chaining.
279279
*/
280-
public ClientConfiguration setReqTimeout(int reqTimeout) {
280+
public ClientConfiguration setRequestTimeout(int reqTimeout) {
281281
this.reqTimeout = reqTimeout;
282282
return this;
283283
}

modules/core/src/main/java/org/apache/ignite/internal/client/thin/ClientChannelConfiguration.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -126,8 +126,8 @@ final class ClientChannelConfiguration {
126126
ClientChannelConfiguration(ClientConfiguration cfg, List<InetSocketAddress> addrs) {
127127
this.sslMode = cfg.getSslMode();
128128
this.tcpNoDelay = cfg.isTcpNoDelay();
129-
this.connTimeout = cfg.getConnTimeout();
130-
this.reqTimeout = cfg.getReqTimeout();
129+
this.connTimeout = cfg.getConnectionTimeout();
130+
this.reqTimeout = cfg.getRequestTimeout();
131131
this.sndBufSize = cfg.getSendBufferSize();
132132
this.rcvBufSize = cfg.getReceiveBufferSize();
133133
this.sslClientCertKeyStorePath = cfg.getSslClientCertificateKeyStorePath();
@@ -176,25 +176,25 @@ public boolean isTcpNoDelay() {
176176
}
177177

178178
/**
179-
* @deprecated Use {@link #getConnTimeout()} and {@link #getReqTimeout()} instead.
179+
* @deprecated Use {@link #getConnectionTimeout()} and {@link #getRequestTimeout()} instead.
180180
* @return Timeout.
181181
*/
182182
@Deprecated
183183
public int getTimeout() {
184-
return Math.max(connTimeout, reqTimeout);
184+
return reqTimeout;
185185
}
186186

187187
/**
188188
* @return Connection timeout.
189189
*/
190-
public int getConnTimeout() {
190+
public int getConnectionTimeout() {
191191
return connTimeout;
192192
}
193193

194194
/**
195195
* @return Request timeout.
196196
*/
197-
public int getReqTimeout() {
197+
public int getRequestTimeout() {
198198
return reqTimeout;
199199
}
200200

modules/core/src/main/java/org/apache/ignite/internal/client/thin/TcpClientChannel.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -198,8 +198,8 @@ class TcpClientChannel implements ClientChannel, ClientMessageHandler, ClientCon
198198
Executor cfgExec = cfg.getAsyncContinuationExecutor();
199199
asyncContinuationExecutor = cfgExec != null ? cfgExec : ForkJoinPool.commonPool();
200200

201-
connTimeout = cfg.getConnTimeout();
202-
reqTimeout = cfg.getReqTimeout();
201+
connTimeout = cfg.getConnectionTimeout();
202+
reqTimeout = cfg.getRequestTimeout();
203203

204204
List<InetSocketAddress> addrs = cfg.getAddresses();
205205

modules/core/src/main/java/org/apache/ignite/internal/client/thin/io/gridnioserver/GridNioClientConnectionMultiplexer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ public GridNioClientConnectionMultiplexer(ClientConfiguration cfg) {
8989
else
9090
filters = new GridNioFilter[] {codecFilter};
9191

92-
connTimeout = cfg.getConnTimeout();
92+
connTimeout = cfg.getConnectionTimeout();
9393

9494
try {
9595
srv = GridNioServer.<ByteBuffer>builder()

modules/core/src/test/java/org/apache/ignite/client/ClientConfigurationTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,8 @@ public class ClientConfigurationTest {
5959
public void testSerialization() throws IOException, ClassNotFoundException {
6060
ClientConfiguration target = new ClientConfiguration()
6161
.setAddresses("127.0.0.1:10800", "127.0.0.1:10801")
62-
.setConnTimeout(123)
63-
.setReqTimeout(123)
62+
.setConnectionTimeout(123)
63+
.setRequestTimeout(123)
6464
.setBinaryConfiguration(new BinaryConfiguration()
6565
.setClassNames(Collections.singleton("Person"))
6666
)

modules/core/src/test/java/org/apache/ignite/client/Comparers.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,8 @@ public static boolean equal(ClientConfiguration a, Object o) {
3636

3737
return Arrays.equals(a.getAddresses(), b.getAddresses()) &&
3838
a.isTcpNoDelay() == b.isTcpNoDelay() &&
39-
a.getConnTimeout() == b.getConnTimeout() &&
40-
a.getReqTimeout() == b.getReqTimeout() &&
39+
a.getConnectionTimeout() == b.getConnectionTimeout() &&
40+
a.getRequestTimeout() == b.getRequestTimeout() &&
4141
a.getSendBufferSize() == b.getSendBufferSize() &&
4242
a.getReceiveBufferSize() == b.getReceiveBufferSize();
4343
}

modules/core/src/test/java/org/apache/ignite/internal/client/thin/ThinClientEnpointsDiscoveryTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -158,8 +158,8 @@ public void testUnreachableAddressDiscoveredDoesNotPreventClientInit() throws Ex
158158
// Config has good server address, client discovery returns unreachable address.
159159
// We expect the client to connect to the good address and ignore the unreachable one.
160160
ClientConfiguration ccfg = new ClientConfiguration()
161-
.setConnTimeout(2000)
162-
.setReqTimeout(2000)
161+
.setConnectionTimeout(2000)
162+
.setRequestTimeout(2000)
163163
.setAddresses("127.0.0.1:" + DFLT_PORT);
164164

165165
IgniteClient client = Ignition.startClient(ccfg);

modules/core/src/test/java/org/apache/ignite/internal/client/thin/TimeoutTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ public class TimeoutTest extends AbstractThinClientTest {
6767

6868
/** {@inheritDoc} */
6969
@Override protected ClientConfiguration getClientConfiguration() {
70-
return super.getClientConfiguration().setConnTimeout(TIMEOUT).setReqTimeout(TIMEOUT);
70+
return super.getClientConfiguration().setConnectionTimeout(TIMEOUT).setRequestTimeout(TIMEOUT);
7171
}
7272

7373
/**

modules/core/src/test/java/org/apache/ignite/internal/processors/odbc/ClientSessionOutboundQueueLimitTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,8 +68,8 @@ public void testClientSessionOutboundQueueLimit() throws Exception {
6868
try (
6969
IgniteClient cli = Ignition.startClient(new ClientConfiguration()
7070
.setAddresses("127.0.0.1:10800")
71-
.setConnTimeout(5000) // Server will drop packets intended for the client. So client can hang on handshake during reconnect.
72-
.setReqTimeout(5000)
71+
.setConnectionTimeout(5000) // Server will drop packets intended for the client. So client can hang on handshake during reconnect.
72+
.setRequestTimeout(5000)
7373
.setRetryLimit(1) // Let's not retry operations if the channel was closed while waiting for a response.
7474
.setEventListeners(new ConnectionEventListener() {
7575
@Override public void onConnectionClosed(ConnectionClosedEvent event) {

0 commit comments

Comments
 (0)