feat(github): update token refresh logic to handle old token comparison

Author: ysinghc

backend/plugins/github/models/connection_test.go

@@ -18,9 +18,9 @@ limitations under the License.
 package models
 
 import (
-	"github.com/apache/incubator-devlake/helpers/pluginhelper/api"
 	"testing"
 
+	"github.com/apache/incubator-devlake/helpers/pluginhelper/api"
 	"github.com/go-playground/validator/v10"
 	"github.com/stretchr/testify/assert"
 )

backend/plugins/github/token/round_tripper.go

@@ -56,7 +56,7 @@ func (rt *RefreshRoundTripper) RoundTrip(req *http.Request) (*http.Response, err
 		resp.Body.Close()
 
 		// Force refresh
-		if err := rt.tokenProvider.ForceRefresh(); err != nil {
+		if err := rt.tokenProvider.ForceRefresh(token); err != nil {
 			return nil, err
 		}
 

backend/plugins/github/token/token_provider.go

@@ -157,8 +157,15 @@ func (tp *TokenProvider) refreshToken() errors.Error {
 	return nil
 }
 
-func (tp *TokenProvider) ForceRefresh() errors.Error {
+func (tp *TokenProvider) ForceRefresh(oldToken string) errors.Error {
 	tp.mu.Lock()
 	defer tp.mu.Unlock()
+
+	// If the token has changed since the request was made, it means another thread
+	// has already refreshed it. We don't need to do anything.
+	if tp.conn.Token != oldToken {
+		return nil
+	}
+
 	return tp.refreshToken()
 }

backend/plugins/github/token/token_provider_test.go

@@ -167,7 +167,7 @@ func TestPersistenceFailure(t *testing.T) {
 
 	// Mock DAL failure
 	mockDal.On("UpdateColumns", mock.Anything, mock.Anything, mock.Anything).Return(errors.Default.New("db error")) // Force refresh
-	err := tp.ForceRefresh()
+	err := tp.ForceRefresh("")
 	assert.NoError(t, err) // Should not return error even if persistence fails
 
 	mockRT.AssertExpectations(t)