-
Notifications
You must be signed in to change notification settings - Fork 574
[VL][CI] Migrate Spark 4.1 tests to CentOS 9 #11519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@ReemaAlzaid, thanks for the PR. I'm concerned that this may introduce too much test redundancy, considering these Spark tests are being verified on Centos 8. If the purpose is enabling some Spark tests with python 3.11, can we install this python version by compiling from source to keep using Centos 8? cc @zhouyuan If we indeed want to migrate from Centos 8 to 9 for Spark tests, maybe we can directly do the replacement. There seems to be no need to keep the both categories. In addition, we may re-use the existing build native lib job, i.e., for tests on Centos 9, download the native binary built on Centos 7. I assume there is no compatibility issue. |
zhouyuan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ReemaAlzaid Thanks for the contribution.
|
@ReemaAlzaid since it may take some time to get the patches ready in velox, could you please check if we could exclude the new timezone(America/Coyhaique) in those tests? here's one example: |
zhouyuan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
PHILO-HE
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thank you.
|
@ReemaAlzaid would you pelase create new pr for this https://github.com/apache/incubator-gluten/pull/11481/changes#diff-d34bc9515f676ce2605c33b00515f94ff1d6b0f6eb1be32670f9783d79c85968 |
What changes are proposed in this pull request?
This PR adds CentOS 9 support for running Spark unit tests while maintaining existing CentOS 8 jobs for gradual migration.
Related Issue: #11511
Fixes: #11481
How was this patch tested?
Will be tested by CI pipeline execution