Bug(c++): cpp ci workflow (macos) failed

[yangxk1]

Describe the bug, including details regarding any error messages, version, and platform.

https://github.com/apache/incubator-graphar/actions/workflows/ci.yml

Component(s)

C++, Developer Tools

[yangxk1]

rel: #871

[SYaoJun]

std::span is a feature introduced in C++20 (not merely a syntax element). A straightforward solution to this issue is to upgrade the project's C++ standard from C++17 to C++20. This problem has caused numerous PRs to fail, so I believe we should prioritize fixing it first.

https://github.com/apache/incubator-graphar/actions/runs/22336590214/job/64630545785

/opt/homebrew/include/parquet/metadata.h:397:36: error: no template named 'span' in namespace 'std'
  397 |   static bool VerifySignature(std::span<const uint8_t> serialized_metadata,
      |                               ~~~~~^
/opt/homebrew/include/parquet/metadata.h:398:36: error: no template named 'span' in namespace 'std'
  398 |                               std::span<const uint8_t> signature,
      |                               ~~~~~^
2 errors generated.

[SYaoJun]

Another solution is to pin the Arrow version to 17, as this issue was introduced starting from Arrow 18.

[SYaoJun]

If it not fixed in afternoon , I can create a PR in tonight.

[Sober7135]

Another solution is to pin the Arrow version to 17, as this issue was introduced starting from Arrow 18.

I think this is introduced in Arrow 23

see: apache/arrow#48414 and arrow 23 release notes

[SYaoJun]

Another solution is to pin the Arrow version to 17, as this issue was introduced starting from Arrow 18.

I think this is introduced in Arrow 23

see: apache/arrow#48414 and arrow 23 release notes

Actually, the macOS CI doesn’t build Arrow from source; it just uses the pre-installed system version. I suspect brew install arrowhas updated the default version recently. Maybe the default version just Arrow 23.

BTW, this bug https://github.com/apache/incubator-graphar/actions/runs/22292264507/job/64481691350?pr=872 occurred before merged arrow 23 PR into main.

[yangxk1]

I verified locally that replacing cxx_std_17 with cxx_std_20 in target_compile_features can solve the problem.

incubator-graphar/cpp/CMakeLists.txt

Line 144 in 6c802a1

target_compile_features(${PROJECT_NAME} INTERFACE cxx_std_17)

But I don’t think we can directly replace it. Maybe we can judge whether to modify it based on the environment of macos and ubuntu. A better solution is to judge whether to modify it based on the arrow version. cc @SYaoJun @Sober7135