Skip to content
This repository was archived by the owner on Apr 10, 2025. It is now read-only.

Commit 0f3f268

Browse files
committed
Revert "Revert "Handle DoneAndSetHeaders() new second argument that wants to know whether the response is complete.""
Needed for 1.9.32.6 to build. This reverts commit 19ebf69.
1 parent 30fdd02 commit 0f3f268

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

src/ngx_pagespeed.cc

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1709,8 +1709,8 @@ void ps_release_request_context(void* data) {
17091709
}
17101710

17111711
if (ctx->recorder != NULL) {
1712-
ctx->recorder->Fail();
1713-
ctx->recorder->DoneAndSetHeaders(NULL); // Deletes recorder.
1712+
// Deletes recorder.
1713+
ctx->recorder->DoneAndSetHeaders(NULL, false /* incomplete response */);
17141714
ctx->recorder = NULL;
17151715
}
17161716

@@ -2506,7 +2506,9 @@ ngx_int_t ps_in_place_body_filter(ngx_http_request_t* r, ngx_chain_t* in) {
25062506
if (cl->buf->last_buf || recorder->failed()) {
25072507
ResponseHeaders response_headers;
25082508
copy_response_headers_from_ngx(r, &response_headers);
2509-
ctx->recorder->DoneAndSetHeaders(&response_headers);
2509+
ctx->recorder->DoneAndSetHeaders(
2510+
&response_headers,
2511+
cl->buf->last_buf /* response is complete if last_buf is set */);
25102512
ctx->recorder = NULL;
25112513
break;
25122514
}

0 commit comments

Comments
 (0)