fix clang-tidy

Author: wangguangshuo

src/shell/command_helper.h

@@ -2240,17 +2240,20 @@ inline bool get_storage_size_stat(shell_context *sc, app_storage_size_stat &st_s
             if (counter_name != "disk.storage.sst(MB)")
                 continue;
             auto find = pcs_by_appid.find(app_id_x);
-            if (find == pcs_by_appid.end()) // app id not found
+            if (find == pcs_by_appid.end()) { // app id not found
                 continue;
+            }
             auto &pc = find->second[partition_index_x];
 
             dsn::host_port primary;
             GET_HOST_PORT(pc, primary, primary);
 
-            if (primary != nodes[i].hp) // not primary replica
+            if (primary != nodes[i].hp) { // not primary replica
                 continue;
-            if (pc.partition_flags != 0) // already calculated
+            }
+            if (pc.partition_flags != 0) { // already calculated
                 continue;
+            }
             pc.partition_flags = 1;
             int64_t app_partition_count = find->second.size();
             auto st_it = st_stat.st_value_by_app

src/shell/commands/recovery.cpp

@@ -203,7 +203,8 @@ dsn::host_port diagnose_recommend(const dsn::replication::ddd_partition_info &pi
         //  - choose the node with the largest last committed decree
         //  - if last committed decree is the same, choose node with the largest ballot
 
-        dsn::host_port latest_node, secondary_node;
+        dsn::host_port latest_node;
+        dsn::host_port secondary_node;
         GET_HOST_PORT(latest, node, latest_node);
         GET_HOST_PORT(secondary, node, secondary_node);
 
@@ -308,8 +309,9 @@ bool ddd_diagnose(command_executor *e, shell_context *sc, arguments args)
         std::vector<dsn::host_port> last_drops;
         GET_HOST_PORTS(pinfo.config, last_drops, last_drops);
 
-        dsn::host_port latest_dropped, secondary_latest_dropped;
-        if (last_drops.size() > 0) {
+        dsn::host_port latest_dropped;
+        dsn::host_port secondary_latest_dropped;
+        if (!last_drops.empty()) {
             latest_dropped = last_drops[last_drops.size() - 1];
         }
         if (last_drops.size() > 1) {
@@ -329,21 +331,23 @@ bool ddd_diagnose(command_executor *e, shell_context *sc, arguments args)
                 << "ballot(" << n.ballot << "), "
                 << "last_committed(" << n.last_committed_decree << "), "
                 << "last_prepared(" << n.last_prepared_decree << ")";
-            if (node == latest_dropped)
+            if (node == latest_dropped) {
                 out << "  <== the latest";
-            else if (node == secondary_latest_dropped)
+            } else if (node == secondary_latest_dropped) {
                 out << "  <== the secondary latest";
+            }
             out << std::endl;
         }
         out << "    ----" << std::endl;
         j = 0;
         for (const auto &r : last_drops) {
             out << "    last_drops[" << j++ << "]: "
                 << "node(" << r.to_string() << ")";
-            if (j == (int)last_drops.size() - 1)
+            if (j == static_cast<int>(last_drops.size()) - 1) {
                 out << "  <== the secondary latest";
-            else if (j == (int)last_drops.size())
+            } else if (j == static_cast<int>(last_drops.size())) {
                 out << "  <== the latest";
+            }
             out << std::endl;
         }
         out << "    ----" << std::endl;

src/shell/commands/table_management.cpp

@@ -398,8 +398,9 @@ bool app_disk(command_executor *e, shell_context *sc, arguments args)
             std::stringstream oss;
             oss << "[";
             for (int j = 0; j < secondaries.size(); j++) {
-                if (j != 0)
+                if (j != 0) {
                     oss << ",";
+                }
                 bool found = false;
                 double value = 0;
                 auto f1 = disk_map.find(secondaries[j]);