simplify 'no expiration' #363
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raboof
force-pushed
the
simplify-nonexpiration
branch
from
1b2ccf3 to
cacb617
Compare
Instead of having 2050-01-01 as 'magic no expiration date', just leave this field out.
raboof
force-pushed
the
simplify-nonexpiration
branch
from
cacb617 to
3d7ed77
Compare
6 tasks
snazy
reviewed
Nov 10, 2025
| for name, refs in actions.items() | ||
| for ref, details in refs.items() | ||
| if date.today() < details.get("expires_at") or details.get("keep") | ||
| if (not details or "expires_at" not in details or date.today() < details["expires_at"]) or details.get("keep") |
Member
There was a problem hiding this comment.
Just for my personal Python education...
Can details actually be None? (similar in L151 + L162)
Member
Author
There was a problem hiding this comment.
yes, it looks like the yaml parser we're using turns a key without any children into None instead of an empty dict. I guess that makes sense since at the yaml level it's not possible to distinguish between "a key without a value" and "a key without children". To make this nicer we'd have to do some kind of 'model-based yaml parsing', which might not be worth it.
|
|
||
| import ruyaml | ||
|
|
||
| indefinitely = date(2050, 1, 1) |
snazy
approved these changes
Nov 10, 2025
Member
snazy
left a comment
snazy
left a comment
There was a problem hiding this comment.
LGTM - thanks for the clarification!
+1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having 2050-01-01 as 'magic no expiration date', just leave this field out.