placeholder

Author: Caideyipi

iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/sink/protocol/opcua/OpcUaSink.java

@@ -84,7 +84,7 @@
 import static org.apache.iotdb.commons.pipe.config.constant.PipeSinkConstant.CONNECTOR_OPC_UA_MODEL_KEY;
 import static org.apache.iotdb.commons.pipe.config.constant.PipeSinkConstant.CONNECTOR_OPC_UA_MODEL_PUB_SUB_VALUE;
 import static org.apache.iotdb.commons.pipe.config.constant.PipeSinkConstant.CONNECTOR_OPC_UA_NODE_URL_KEY;
-import static org.apache.iotdb.commons.pipe.config.constant.PipeSinkConstant.CONNECTOR_OPC_UA_PLACEHOLDER_DEFAULT_VALUE;
+import static org.apache.iotdb.commons.pipe.config.constant.PipeSinkConstant.CONNECTOR_OPC_UA_PLACEHOLDER_4_NULL_TAG_DEFAULT_VALUE;
 import static org.apache.iotdb.commons.pipe.config.constant.PipeSinkConstant.CONNECTOR_OPC_UA_PLACEHOLDER_KEY;
 import static org.apache.iotdb.commons.pipe.config.constant.PipeSinkConstant.CONNECTOR_OPC_UA_QUALITY_NAME_DEFAULT_VALUE;
 import static org.apache.iotdb.commons.pipe.config.constant.PipeSinkConstant.CONNECTOR_OPC_UA_QUALITY_NAME_KEY;
@@ -141,7 +141,7 @@ public class OpcUaSink implements PipeConnector {
   private String serverKey;
   private boolean isClientServerModel;
   private String databaseName;
-  private String placeHolder;
+  private String placeHolder4NullTag;
   private @Nullable String valueName;
   private @Nullable String qualityName;
   private StatusCode defaultQuality;
@@ -224,10 +224,10 @@ public void customize(
                 Arrays.asList(CONNECTOR_OPC_UA_MODEL_KEY, SINK_OPC_UA_MODEL_KEY),
                 CONNECTOR_OPC_UA_MODEL_DEFAULT_VALUE)
             .equals(CONNECTOR_OPC_UA_MODEL_CLIENT_SERVER_VALUE);
-    placeHolder =
+    placeHolder4NullTag =
         parameters.getStringOrDefault(
             Arrays.asList(CONNECTOR_OPC_UA_PLACEHOLDER_KEY, SINK_OPC_UA_PLACEHOLDER_KEY),
-            CONNECTOR_OPC_UA_PLACEHOLDER_DEFAULT_VALUE);
+            CONNECTOR_OPC_UA_PLACEHOLDER_4_NULL_TAG_DEFAULT_VALUE);
     final DataRegion region =
         StorageEngine.getInstance()
             .getDataRegion(new DataRegionId(configuration.getRuntimeEnvironment().getRegionId()));
@@ -556,8 +556,8 @@ public String getDatabaseName() {
     return databaseName;
   }
 
-  public String getPlaceHolder() {
-    return placeHolder;
+  public String getPlaceHolder4NullTag() {
+    return placeHolder4NullTag;
   }
 
   @Nullable

iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/sink/protocol/opcua/client/IoTDBOpcUaClient.java

@@ -69,6 +69,9 @@ public class IoTDBOpcUaClient {
 
   // Customized nodes
   private static final int NAME_SPACE_INDEX = 2;
+
+  // Useless for a server only accept client writing
+  private static final double SAMPLING_INTERVAL_PLACEHOLDER = 500;
   private final String nodeUrl;
 
   private final SecurityPolicy securityPolicy;
@@ -281,7 +284,7 @@ private VariableAttributes createMeasurementAttributes(
         null, // arrayDimensions
         AccessLevel.toValue(AccessLevel.READ_WRITE),
         AccessLevel.toValue(AccessLevel.READ_WRITE),
-        500.0, // samplingInterval
+        SAMPLING_INTERVAL_PLACEHOLDER,
         historizing);
   }
 

iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/sink/protocol/opcua/server/OpcUaNameSpace.java

@@ -156,7 +156,7 @@ public static void transferTabletForClientServerModel(
 
         for (int j = 0; j < segments.length; ++j) {
           folderSegments[j + 1] =
-              Objects.isNull(segments[j]) ? sink.getPlaceHolder() : (String) segments[j];
+              Objects.isNull(segments[j]) ? sink.getPlaceHolder4NullTag() : (String) segments[j];
         }
 
         final int finalI = i;
@@ -393,7 +393,7 @@ private void transferTabletForPubSubModel(
         for (final Object segment : tablet.getDeviceID(i).getSegments()) {
           idBuilder
               .append(TsFileConstant.PATH_SEPARATOR)
-              .append(Objects.isNull(segment) ? sink.getPlaceHolder() : segment);
+              .append(Objects.isNull(segment) ? sink.getPlaceHolder4NullTag() : segment);
         }
         sourceNameList.add(idBuilder.toString());
       }

iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/pipe/config/constant/PipeSinkConstant.java

@@ -181,7 +181,7 @@ public class PipeSinkConstant {
 
   public static final String CONNECTOR_OPC_UA_PLACEHOLDER_KEY = "connector.opcua.placeholder";
   public static final String SINK_OPC_UA_PLACEHOLDER_KEY = "sink.opcua.placeholder";
-  public static final String CONNECTOR_OPC_UA_PLACEHOLDER_DEFAULT_VALUE = "null";
+  public static final String CONNECTOR_OPC_UA_PLACEHOLDER_4_NULL_TAG_DEFAULT_VALUE = "null";
 
   public static final String CONNECTOR_OPC_UA_WITH_QUALITY_KEY = "connector.opcua.with-quality";
   public static final String SINK_OPC_UA_WITH_QUALITY_KEY = "sink.opcua.with-quality";