Skip to content

Commit 3a57f3c

Browse files
committed
fix: left & right in ComparisonExpression should be final
1 parent 00da5ad commit 3a57f3c

File tree

2 files changed

+2
-12
lines changed

2 files changed

+2
-12
lines changed

iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/planner/ir/PredicateWithUncorrelatedScalarSubqueryReconstructor.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,8 +93,6 @@ public void reconstructPredicateWithUncorrelatedScalarSubquery(
9393
context, (SubqueryExpression) left, analysis.getWith());
9494
result.ifPresent(comparisonExpression::setShadowLeft);
9595
}
96-
comparisonExpression.setLeft(left);
97-
comparisonExpression.setRight(right);
9896
}
9997
}
10098

iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/sql/ast/ComparisonExpression.java

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -100,9 +100,9 @@ public Operator negate() {
100100
}
101101

102102
private final Operator operator;
103-
private Expression left;
103+
private final Expression left;
104104
private Expression shadowLeft;
105-
private Expression right;
105+
private final Expression right;
106106
private Expression shadowRight;
107107

108108
public ComparisonExpression(Operator operator, Expression left, Expression right) {
@@ -140,14 +140,6 @@ public Expression getRight() {
140140
return shadowRight != null ? shadowRight : right;
141141
}
142142

143-
public void setLeft(Expression left) {
144-
this.left = left;
145-
}
146-
147-
public void setRight(Expression right) {
148-
this.right = right;
149-
}
150-
151143
@Override
152144
public <R, C> R accept(AstVisitor<R, C> visitor, C context) {
153145
return visitor.visitComparisonExpression(this, context);

0 commit comments

Comments
 (0)