Fix issue and adjust some bugs on the IT, remove some debug code.

Author: zerolbsony

integration-test/src/test/java/org/apache/iotdb/relational/it/schema/IoTDBAlterTimeSeriesTypeIT.java

@@ -490,7 +490,6 @@ public void testHybridAutoExtendSchemaTemplate()
           Arrays.asList(1d, 2d, 3));
       Assert.fail();
     } catch (StatementExecutionException e) {
-      System.out.println("hi: " + e.getMessage());
       Assert.assertTrue(
           e.getMessage()
               .contains(

integration-test/src/test/java/org/apache/iotdb/session/it/IoTDBSessionSchemaTemplateIT.java

@@ -480,8 +480,6 @@ public TSStatus alterTimeSeriesDataType(final TAlterTimeSeriesReq req) {
               req.getQueryId(),
               (MeasurementPath)
                   PathDeserializeUtil.deserialize(ByteBuffer.wrap(req.getMeasurementPath())),
-              //
-              // MeasurementPath.deserialize(ByteBuffer.wrap(req.getMeasurementPath())),
               req.getOperationType(),
               TSDataType.deserialize(req.updateInfo.get()),
               false);

iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/ProcedureManager.java

@@ -102,30 +102,22 @@ protected StateMachineProcedure.Flow executeFromState(
         case ALTER_TIME_SERIES_DATA_TYPE:
           LOGGER.info("altering time series {} data type", measurementPath.getFullPath());
           if (!alterTimeSeriesDataType(env)) {
-            LOGGER.info("altering time series {} data type failed", measurementPath.getFullPath());
+            LOGGER.error("alter time series {} data type failed", measurementPath.getFullPath());
             return Flow.NO_MORE_STATE;
           }
-          LOGGER.info(
-              "altering time series {} data type successful", measurementPath.getFullPath());
           break;
         case CLEAR_CACHE:
           LOGGER.info(
               "clearing cache after alter time series {} data type", measurementPath.getFullPath());
           PathPatternTree patternTree = new PathPatternTree();
           patternTree.appendPathPattern(measurementPath);
           patternTree.constructTree();
-          LOGGER.info(
-              "Invalidate cache of timeSeries {} in AlterTimeSeriesDataTypeProcedure",
-              measurementPath.getFullPath());
           invalidateCache(
               env,
               preparePatternTreeBytesData(patternTree),
               measurementPath.getFullPath(),
               this::setFailure,
               true);
-          LOGGER.info(
-              "clear cache successful after alter time series {} data type",
-              measurementPath.getFullPath());
           break;
         default:
           setFailure(
@@ -247,9 +239,7 @@ protected void onAllReplicasetFailure(
           }
         };
     alterTimerSeriesTask.execute();
-    LOGGER.error("start clear cache in AlterTimeSeriesDataTypeProcedure");
     setNextState(AlterTimeSeriesDataTypeState.CLEAR_CACHE);
-    LOGGER.error("end clear cache in AlterTimeSeriesDataTypeProcedure");
     return true;
   }
 
@@ -352,6 +342,8 @@ public void serialize(final DataOutputStream stream) throws IOException {
     super.serialize(stream);
     ReadWriteIOUtils.write(queryId, stream);
     measurementPath.serialize(stream);
+    ReadWriteIOUtils.write(operationType, stream);
+    ReadWriteIOUtils.write(dataType, stream);
   }
 
   @Override
@@ -362,6 +354,12 @@ public void deserialize(final ByteBuffer byteBuffer) {
     if (getCurrentState() == AlterTimeSeriesDataTypeState.CLEAR_CACHE) {
       LOGGER.info("Successfully restored, will set mods to the data regions anyway");
     }
+    if (byteBuffer.hasRemaining()) {
+      operationType = ReadWriteIOUtils.readByte(byteBuffer);
+    }
+    if (byteBuffer.hasRemaining()) {
+      dataType = ReadWriteIOUtils.readDataType(byteBuffer);
+    }
   }
 
   @Override
@@ -377,7 +375,9 @@ public boolean equals(final Object o) {
         && this.getCurrentState().equals(that.getCurrentState())
         && this.getCycles() == getCycles()
         && this.isGeneratedByPipe == that.isGeneratedByPipe
-        && this.measurementPath.equals(that.measurementPath);
+        && this.measurementPath.equals(that.measurementPath)
+        && this.operationType == that.operationType
+        && this.dataType.equals(that.dataType);
   }
 
   @Override

iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/impl/schema/AlterTimeSeriesDataTypeProcedure.java

@@ -323,6 +323,9 @@ public Procedure create(ByteBuffer buffer) throws IOException {
       case PIPE_ENRICHED_ALTER_COLUMN_DATATYPE_PROCEDURE:
         procedure = new AlterTableColumnDataTypeProcedure(true);
         break;
+      case PIPE_ENRICHED_ALTER_TIMESERIES_DATATYPE_PROCEDURE:
+        procedure = new AlterTimeSeriesDataTypeProcedure(true);
+        break;
       case PIPE_ENRICHED_DELETE_DEVICES_PROCEDURE:
         procedure = new DeleteDevicesProcedure(true);
         break;

iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/store/ProcedureFactory.java

@@ -22,14 +22,11 @@
 import org.apache.iotdb.commons.exception.MetadataException;
 
 import org.apache.tsfile.enums.TSDataType;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
 
 public class DataTypeMismatchException extends MetadataException {
 
   // NOTICE: DO NOT CHANGE THIS STRING, IT IS USED IN THE ERROR HANDLING OF PIPE
   public static final String REGISTERED_TYPE_STRING = "registered type";
-  private static final Logger log = LoggerFactory.getLogger(DataTypeMismatchException.class);
 
   public DataTypeMismatchException(
       String deviceName,
@@ -49,21 +46,6 @@ public DataTypeMismatchException(
             insertType,
             time,
             value == null ? "null" : processValue(value.toString())));
-
-    StackTraceElement[] stackTraceElements = Thread.currentThread().getStackTrace();
-
-    // 通常，我们需要忽略前两层堆栈信息，因为它们分别对应于printCallerInfo()方法和当前正在执行的方法（例如methodB()）
-    if (stackTraceElements.length > 2) {
-      // 获取调用者的信息
-      StackTraceElement caller =
-          stackTraceElements[2]; // 获取调用者信息，索引从0开始，所以要取第3个元素（因为第0和第1个是当前方法的堆栈）
-      log.error("调用者类名: {}", caller.getClassName());
-      log.error("调用者方法名: {}", caller.getMethodName());
-      log.error("调用者文件名: {}", caller.getFileName());
-      log.error("调用者行号: {}", caller.getLineNumber());
-    } else {
-      log.error("堆栈跟踪信息不足，无法确定调用者信息。");
-    }
   }
 
   public DataTypeMismatchException(
@@ -77,20 +59,6 @@ public DataTypeMismatchException(
             insertType,
             time,
             value == null ? "null" : processValue(value.toString())));
-    StackTraceElement[] stackTraceElements = Thread.currentThread().getStackTrace();
-
-    // 通常，我们需要忽略前两层堆栈信息，因为它们分别对应于printCallerInfo()方法和当前正在执行的方法（例如methodB()）
-    if (stackTraceElements.length > 2) {
-      // 获取调用者的信息
-      StackTraceElement caller =
-          stackTraceElements[2]; // 获取调用者信息，索引从0开始，所以要取第3个元素（因为第0和第1个是当前方法的堆栈）
-      log.error("调用者类名: {}", caller.getClassName());
-      log.error("调用者方法名: {}", caller.getMethodName());
-      log.error("调用者文件名: {}", caller.getFileName());
-      log.error("调用者行号: {}", caller.getLineNumber());
-    } else {
-      log.error("堆栈跟踪信息不足，无法确定调用者信息。");
-    }
   }
 
   private static String processValue(String value) {

iotdb-core/datanode/src/main/java/org/apache/iotdb/db/exception/metadata/DataTypeMismatchException.java

@@ -150,7 +150,13 @@ public void addStatistics(Statistics statistics) {
                   StandardCharsets.UTF_8),
               statistics.getStartTime());
         } else {
-          updateBinaryFirstValue((Binary) statistics.getFirstValue(), statistics.getStartTime());
+          if (statistics.getFirstValue() instanceof Binary) {
+            updateBinaryFirstValue((Binary) statistics.getFirstValue(), statistics.getStartTime());
+          } else {
+            updateBinaryFirstValue(
+                new Binary(String.valueOf(statistics.getFirstValue()), StandardCharsets.UTF_8),
+                statistics.getStartTime());
+          }
         }
         break;
       case BOOLEAN:

iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/aggregation/FirstValueAccumulator.java

@@ -150,7 +150,13 @@ public void addStatistics(Statistics statistics) {
                   StandardCharsets.UTF_8),
               statistics.getEndTime());
         } else {
-          updateBinaryLastValue((Binary) statistics.getLastValue(), statistics.getEndTime());
+          if (statistics.getLastValue() instanceof Binary) {
+            updateBinaryLastValue((Binary) statistics.getLastValue(), statistics.getEndTime());
+          } else {
+            updateBinaryLastValue(
+                new Binary(String.valueOf(statistics.getLastValue()), StandardCharsets.UTF_8),
+                statistics.getEndTime());
+          }
         }
         break;
       case BOOLEAN:

iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/aggregation/LastValueAccumulator.java

@@ -19,13 +19,17 @@
 
 package org.apache.iotdb.db.queryengine.plan.relational.sql.ast;
 
+import org.apache.tsfile.utils.RamUsageEstimator;
+
 import javax.annotation.Nullable;
 
 import java.util.Collections;
 import java.util.List;
 import java.util.Objects;
 
 public class AlterColumnDataType extends Statement {
+  private static final long INSTANCE_SIZE =
+      RamUsageEstimator.shallowSizeOfInstance(AlterColumnDataType.class);
   private final QualifiedName tableName;
   private final Identifier columnName;
   private final DataType dataType;
@@ -116,4 +120,14 @@ public boolean isIfColumnExists() {
   public boolean isView() {
     return view;
   }
+
+  @Override
+  public long ramBytesUsed() {
+    long size = INSTANCE_SIZE;
+    size += AstMemoryEstimationHelper.getEstimatedSizeOfNodeLocation(getLocationInternal());
+    size += tableName == null ? 0L : tableName.ramBytesUsed();
+    size += AstMemoryEstimationHelper.getEstimatedSizeOfAccountableObject(columnName);
+    size += AstMemoryEstimationHelper.getEstimatedSizeOfAccountableObject(dataType);
+    return size;
+  }
 }

iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/sql/ast/AlterColumnDataType.java

@@ -362,28 +362,15 @@ public void writeAlignedRow(
 
   public void writeTabletNode(InsertTabletNode insertTabletNode, int start, int end) {
     List<IMeasurementSchema> schemaList = new ArrayList<>();
-    int j = 0;
-    for (TSDataType tsDataType : insertTabletNode.getDataTypes()) {
-      logger.error("getDataTypes[{}] is {}", j, tsDataType);
-      j++;
-    }
     for (int i = 0; i < insertTabletNode.getMeasurementSchemas().length; i++) {
       if (insertTabletNode.getColumns()[i] == null) {
         schemaList.add(null);
       } else {
         schemaList.add(insertTabletNode.getMeasurementSchemas()[i]);
       }
     }
-    int i = 0;
-    for (IMeasurementSchema schema : schemaList) {
-      logger.error("schemaList[{}] is {}", i, schema);
-      i++;
-    }
-    logger.error("be ready to createMemChunkGroupIfNotExistAndGet");
     IWritableMemChunkGroup memChunkGroup =
         createMemChunkGroupIfNotExistAndGet(insertTabletNode.getDeviceID(), schemaList);
-    logger.error("after createMemChunkGroupIfNotExistAndGet");
-    logger.error("be ready to [writeTabletNode]writeTablet");
     memChunkGroup.writeTablet(
         insertTabletNode.getTimes(),
         insertTabletNode.getColumns(),
@@ -392,16 +379,10 @@ public void writeTabletNode(InsertTabletNode insertTabletNode, int start, int en
         start,
         end,
         null);
-    logger.error("after [writeTabletNode]writeTablet");
   }
 
   public void writeAlignedTablet(
       InsertTabletNode insertTabletNode, int start, int end, TSStatus[] results) {
-    int j = 0;
-    for (TSDataType tsDataType : insertTabletNode.getDataTypes()) {
-      logger.error("getDataTypes[{}] is {}", j, tsDataType);
-      j++;
-    }
     List<IMeasurementSchema> schemaList = new ArrayList<>();
     for (int i = 0; i < insertTabletNode.getMeasurementSchemas().length; i++) {
       if (insertTabletNode.getColumns()[i] == null
@@ -415,22 +396,14 @@ public void writeAlignedTablet(
     if (schemaList.isEmpty()) {
       return;
     }
-    int i = 0;
-    for (IMeasurementSchema schema : schemaList) {
-      logger.error("schemaList[{}] is {}", i, schema);
-      i++;
-    }
     final List<Pair<IDeviceID, Integer>> deviceEndOffsetPair =
         insertTabletNode.splitByDevice(start, end);
     int splitStart = start;
     for (Pair<IDeviceID, Integer> pair : deviceEndOffsetPair) {
       final IDeviceID deviceID = pair.left;
       int splitEnd = pair.right;
-      logger.error("be ready to createAlignedMemChunkGroupIfNotExistAndGet");
       IWritableMemChunkGroup memChunkGroup =
           createAlignedMemChunkGroupIfNotExistAndGet(deviceID, schemaList);
-      logger.error("after createAlignedMemChunkGroupIfNotExistAndGet");
-      logger.error("be ready to [writeAlignedTablet]writeTablet");
       memChunkGroup.writeTablet(
           insertTabletNode.getTimes(),
           insertTabletNode.getColumns(),
@@ -439,7 +412,6 @@ public void writeAlignedTablet(
           splitStart,
           splitEnd,
           results);
-      logger.error("after [writeAlignedTablet]writeTablet");
       splitStart = splitEnd;
     }
   }