Ignore not exist device when storage engine is not ready

Author: shuwenwei

iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/fragment/FragmentInstanceContext.java

@@ -36,6 +36,7 @@
 import org.apache.iotdb.db.queryengine.plan.planner.memory.MemoryReservationManager;
 import org.apache.iotdb.db.queryengine.plan.planner.memory.ThreadSafeMemoryReservationManager;
 import org.apache.iotdb.db.queryengine.plan.planner.plan.TimePredicate;
+import org.apache.iotdb.db.storageengine.StorageEngine;
 import org.apache.iotdb.db.storageengine.dataregion.IDataRegionForQuery;
 import org.apache.iotdb.db.storageengine.dataregion.read.IQueryDataSource;
 import org.apache.iotdb.db.storageengine.dataregion.read.QueryDataSource;
@@ -107,6 +108,10 @@ public class FragmentInstanceContext extends QueryContext {
   // empty for zero time partitions
   private List<Long> timePartitions;
 
+  // An optimization during restart changes the time index from FILE TIME INDEX
+  // to DEVICE TIME INDEX, which may cause a related validation false positive.
+  private boolean ignoreNotExistsDevice = false;
+
   private QueryDataSourceType queryDataSourceType = QueryDataSourceType.SERIES_SCAN;
 
   private final AtomicLong startNanos = new AtomicLong();
@@ -294,6 +299,7 @@ private FragmentInstanceContext(long queryId) {
 
   public void start() {
     long now = System.currentTimeMillis();
+    ignoreNotExistsDevice = !StorageEngine.getInstance().isReadyForNonReadWriteFunctions();
     executionStartTime.compareAndSet(null, now);
     startNanos.compareAndSet(0, System.nanoTime());
 
@@ -939,4 +945,8 @@ public long getClosedUnseqFileNum() {
   public long getUnclosedSeqFileNum() {
     return unclosedSeqFileNum;
   }
+
+  public boolean ignoreNotExistsDevice() {
+    return ignoreNotExistsDevice;
+  }
 }

iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/source/FileLoaderUtils.java

@@ -21,6 +21,7 @@
 
 import org.apache.iotdb.commons.path.AlignedFullPath;
 import org.apache.iotdb.commons.path.NonAlignedFullPath;
+import org.apache.iotdb.db.queryengine.execution.fragment.FragmentInstanceContext;
 import org.apache.iotdb.db.queryengine.execution.fragment.QueryContext;
 import org.apache.iotdb.db.queryengine.metric.SeriesScanCostMetricSet;
 import org.apache.iotdb.db.storageengine.buffer.TimeSeriesMetadataCache;
@@ -78,7 +79,7 @@ private FileLoaderUtils() {
   public static TimeseriesMetadata loadTimeSeriesMetadata(
       TsFileResource resource,
       NonAlignedFullPath seriesPath,
-      QueryContext context,
+      FragmentInstanceContext context,
       Filter globalTimeFilter,
       Set<String> allSensors,
       boolean isSeq)
@@ -101,7 +102,8 @@ public static TimeseriesMetadata loadTimeSeriesMetadata(
                         seriesPath.getDeviceId(),
                         seriesPath.getMeasurement()),
                     allSensors,
-                    resource.getTimeIndexType() == ITimeIndex.FILE_TIME_INDEX_TYPE,
+                    context.ignoreNotExistsDevice()
+                        || resource.getTimeIndexType() == ITimeIndex.FILE_TIME_INDEX_TYPE,
                     context.isDebug(),
                     context);
         if (timeSeriesMetadata != null) {
@@ -178,7 +180,7 @@ public static TimeseriesMetadata loadTimeSeriesMetadata(
   public static AbstractAlignedTimeSeriesMetadata loadAlignedTimeSeriesMetadata(
       TsFileResource resource,
       AlignedFullPath alignedPath,
-      QueryContext context,
+      FragmentInstanceContext context,
       Filter globalTimeFilter,
       boolean isSeq,
       boolean ignoreAllNullRows)
@@ -254,7 +256,7 @@ public static AbstractAlignedTimeSeriesMetadata loadAlignedTimeSeriesMetadata(
   private static AbstractAlignedTimeSeriesMetadata loadAlignedTimeSeriesMetadataFromDisk(
       TsFileResource resource,
       AlignedFullPath alignedPath,
-      QueryContext context,
+      FragmentInstanceContext context,
       Filter globalTimeFilter,
       boolean ignoreAllNullRows)
       throws IOException {
@@ -276,7 +278,8 @@ private static AbstractAlignedTimeSeriesMetadata loadAlignedTimeSeriesMetadataFr
             filePath,
             new TimeSeriesMetadataCacheKey(resource.getTsFileID(), deviceId, ""),
             allSensors,
-            resource.getTimeIndexType() == ITimeIndex.FILE_TIME_INDEX_TYPE,
+            context.ignoreNotExistsDevice()
+                || resource.getTimeIndexType() == ITimeIndex.FILE_TIME_INDEX_TYPE,
             isDebug,
             context);
     if (timeColumn != null) {
@@ -305,7 +308,8 @@ private static AbstractAlignedTimeSeriesMetadata loadAlignedTimeSeriesMetadataFr
                   new TimeSeriesMetadataCacheKey(
                       resource.getTsFileID(), deviceId, valueMeasurement),
                   allSensors,
-                  resource.getTimeIndexType() == ITimeIndex.FILE_TIME_INDEX_TYPE,
+                  context.ignoreNotExistsDevice()
+                      || resource.getTimeIndexType() == ITimeIndex.FILE_TIME_INDEX_TYPE,
                   isDebug,
                   context);
           exist = (exist || (valueColumn != null));