Skip to content

Commit 78630df

Browse files
authored
Set the parameter names from default_storage_group_level to default_database_level (#16626) (#16646)
1 parent 403cf64 commit 78630df

File tree

8 files changed

+32
-27
lines changed

8 files changed

+32
-27
lines changed

integration-test/src/main/java/org/apache/iotdb/it/env/cluster/config/MppCommonConfig.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -551,7 +551,7 @@ public CommonConfig setSubscriptionEnabled(boolean subscriptionEnabled) {
551551

552552
@Override
553553
public CommonConfig setDefaultStorageGroupLevel(int defaultStorageGroupLevel) {
554-
setProperty("default_storage_group_level", String.valueOf(defaultStorageGroupLevel));
554+
setProperty("default_database_level", String.valueOf(defaultStorageGroupLevel));
555555
return this;
556556
}
557557

integration-test/src/test/java/org/apache/iotdb/db/it/IoTDBSetConfigurationIT.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,7 @@ public void testSetDefaultSGLevel() throws SQLException {
213213
try (Connection connection = EnvFactory.getEnv().getConnection();
214214
Statement statement = connection.createStatement()) {
215215
// legal value
216-
statement.execute("set configuration \"default_storage_group_level\"=\"3\"");
216+
statement.execute("set configuration \"default_database_level\"=\"3\"");
217217
statement.execute("INSERT INTO root.a.b.c.d1(timestamp, s1) VALUES (1, 1)");
218218
ResultSet databases = statement.executeQuery("show databases");
219219
databases.next();
@@ -231,18 +231,18 @@ public void testSetDefaultSGLevel() throws SQLException {
231231

232232
// illegal value
233233
try {
234-
statement.execute("set configuration \"default_storage_group_level\"=\"-1\"");
234+
statement.execute("set configuration \"default_database_level\"=\"-1\"");
235235
} catch (SQLException e) {
236-
assertTrue(e.getMessage().contains("Illegal defaultStorageGroupLevel: -1, should >= 1"));
236+
assertTrue(e.getMessage().contains("Illegal defaultDatabaseLevel: -1, should >= 1"));
237237
}
238238

239239
// Failed updates will not change the files.
240240
assertFalse(
241241
checkConfigFileContains(
242-
EnvFactory.getEnv().getDataNodeWrapper(0), "default_storage_group_level=-1"));
242+
EnvFactory.getEnv().getDataNodeWrapper(0), "default_database_level=-1"));
243243
assertTrue(
244244
checkConfigFileContains(
245-
EnvFactory.getEnv().getDataNodeWrapper(0), "default_storage_group_level=3"));
245+
EnvFactory.getEnv().getDataNodeWrapper(0), "default_database_level=3"));
246246
}
247247

248248
// can start with an illegal value

iotdb-core/datanode/src/main/java/org/apache/iotdb/db/conf/IoTDBConfig.java

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -692,7 +692,7 @@ public class IoTDBConfig {
692692
private TSDataType nanStringInferType = TSDataType.DOUBLE;
693693

694694
/** Database level when creating schema automatically is enabled */
695-
private int defaultStorageGroupLevel = 1;
695+
private int defaultDatabaseLevel = 1;
696696

697697
/** BOOLEAN encoding when creating schema automatically is enabled */
698698
private TSEncoding defaultBooleanEncoding = TSEncoding.RLE;
@@ -2490,24 +2490,23 @@ public void setNanStringInferType(TSDataType nanStringInferType) {
24902490
this.nanStringInferType = nanStringInferType;
24912491
}
24922492

2493-
public int getDefaultStorageGroupLevel() {
2494-
return defaultStorageGroupLevel;
2493+
public int getDefaultDatabaseLevel() {
2494+
return defaultDatabaseLevel;
24952495
}
24962496

2497-
void setDefaultStorageGroupLevel(int defaultStorageGroupLevel, boolean startUp) {
2498-
if (defaultStorageGroupLevel < 1) {
2497+
void setDefaultDatabaseLevel(int defaultDatabaseLevel, boolean startUp) {
2498+
if (defaultDatabaseLevel < 1) {
24992499
if (startUp) {
25002500
logger.warn(
2501-
"Illegal defaultStorageGroupLevel: {}, should >= 1, use default value 1",
2502-
defaultStorageGroupLevel);
2503-
defaultStorageGroupLevel = 1;
2501+
"Illegal defaultDatabaseLevel: {}, should >= 1, use default value 1",
2502+
defaultDatabaseLevel);
2503+
defaultDatabaseLevel = 1;
25042504
} else {
25052505
throw new IllegalArgumentException(
2506-
String.format(
2507-
"Illegal defaultStorageGroupLevel: %d, should >= 1", defaultStorageGroupLevel));
2506+
String.format("Illegal defaultDatabaseLevel: %d, should >= 1", defaultDatabaseLevel));
25082507
}
25092508
}
2510-
this.defaultStorageGroupLevel = defaultStorageGroupLevel;
2509+
this.defaultDatabaseLevel = defaultDatabaseLevel;
25112510
}
25122511

25132512
public TSEncoding getDefaultBooleanEncoding() {

iotdb-core/datanode/src/main/java/org/apache/iotdb/db/conf/IoTDBDescriptor.java

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1691,12 +1691,18 @@ private void loadAutoCreateSchemaProps(TrimProperties properties, boolean startU
16911691
properties.getProperty(
16921692
"nan_string_infer_type",
16931693
ConfigurationFileUtils.getConfigurationDefaultValue("nan_string_infer_type"))));
1694-
conf.setDefaultStorageGroupLevel(
1694+
conf.setDefaultDatabaseLevel(
16951695
Integer.parseInt(
1696-
properties.getProperty(
1697-
"default_storage_group_level",
1698-
ConfigurationFileUtils.getConfigurationDefaultValue(
1699-
"default_storage_group_level"))),
1696+
Optional.ofNullable(properties.getProperty("default_database_level"))
1697+
.orElse(
1698+
properties.getProperty(
1699+
"default_storage_group_level",
1700+
Optional.ofNullable(
1701+
ConfigurationFileUtils.getConfigurationDefaultValue(
1702+
"default_database_level"))
1703+
.orElse(
1704+
ConfigurationFileUtils.getConfigurationDefaultValue(
1705+
"default_storage_group_level"))))),
17001706
startUp);
17011707
conf.setDefaultBooleanEncoding(
17021708
properties.getProperty(

iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/analyze/cache/partition/PartitionCache.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -246,7 +246,7 @@ private void createStorageGroupAndUpdateCache(
246246
} else {
247247
PartialPath databaseNameNeedCreated =
248248
MetaUtils.getStorageGroupPathByLevel(
249-
new PartialPath(devicePath), config.getDefaultStorageGroupLevel());
249+
new PartialPath(devicePath), config.getDefaultDatabaseLevel());
250250
databaseNamesNeedCreated.add(databaseNameNeedCreated.getFullPath());
251251
}
252252
}

iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/crud/LoadTsFileStatement.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ public class LoadTsFileStatement extends Statement {
5757

5858
public LoadTsFileStatement(String filePath) throws FileNotFoundException {
5959
this.file = new File(filePath);
60-
this.databaseLevel = IoTDBDescriptor.getInstance().getConfig().getDefaultStorageGroupLevel();
60+
this.databaseLevel = IoTDBDescriptor.getInstance().getConfig().getDefaultDatabaseLevel();
6161
this.verifySchema = true;
6262
this.deleteAfterLoad = false;
6363
this.convertOnTypeMismatch = true;
@@ -90,7 +90,7 @@ public static List<File> processTsFile(final File file) throws FileNotFoundExcep
9090

9191
protected LoadTsFileStatement() {
9292
this.file = null;
93-
this.databaseLevel = IoTDBDescriptor.getInstance().getConfig().getDefaultStorageGroupLevel();
93+
this.databaseLevel = IoTDBDescriptor.getInstance().getConfig().getDefaultDatabaseLevel();
9494
this.verifySchema = true;
9595
this.deleteAfterLoad = false;
9696
this.convertOnTypeMismatch = true;

iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/load/config/LoadTsFileConfigurator.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ public static void validateParameters(final String key, final String value) {
6161

6262
public static final String DATABASE_LEVEL_KEY = "database-level";
6363
private static final int DATABASE_LEVEL_DEFAULT_VALUE =
64-
IoTDBDescriptor.getInstance().getConfig().getDefaultStorageGroupLevel();
64+
IoTDBDescriptor.getInstance().getConfig().getDefaultDatabaseLevel();
6565
private static final int DATABASE_LEVEL_MIN_VALUE = 1;
6666

6767
public static void validateDatabaseLevelParam(final String databaseLevel) {

iotdb-core/node-commons/src/assembly/resources/conf/iotdb-system.properties.template

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -910,7 +910,7 @@ enable_auto_create_schema=true
910910
# Default: 1
911911
# When illegal: report an error and change nothing during hot-reload; use the default value in
912912
# start-up
913-
default_storage_group_level=1
913+
default_database_level=1
914914

915915
# ALL data types: BOOLEAN, INT32, INT64, FLOAT, DOUBLE, TEXT
916916

0 commit comments

Comments
 (0)