Skip to content

Commit 9466829

Browse files
Pipe: Reduce the amount of log information printed after a batch fails (#14172)
Co-authored-by: Steve Yurong Su <[email protected]>
1 parent e2543f3 commit 9466829

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/connector/protocol/pipeconsensus/handler/PipeConsensusTabletBatchEventHandler.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -117,15 +117,15 @@ public void onComplete(final TPipeConsensusBatchTransferResp response) {
117117
@Override
118118
public void onError(final Exception exception) {
119119
LOGGER.warn(
120-
"PipeConsensus: Failed to transfer TabletInsertionEvent batch {} (request commit ids={}).",
120+
"PipeConsensus: Failed to transfer TabletInsertionEvent batch. Total failed events: {}, related pipe names: {}",
121+
events.size(),
121122
events.stream()
122123
.map(
123124
event ->
124125
event instanceof EnrichedEvent
125-
? ((EnrichedEvent) event).coreReportMessage()
126-
: event.toString())
127-
.collect(Collectors.toList()),
128-
requestCommitIds,
126+
? ((EnrichedEvent) event).getPipeName()
127+
: "UNKNOWN")
128+
.collect(Collectors.toSet()),
129129
exception);
130130

131131
connector.addFailureEventsToRetryQueue(events);

iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/connector/protocol/thrift/async/handler/PipeTransferTabletBatchEventHandler.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -121,9 +121,9 @@ public void onComplete(final TPipeTransferResp response) {
121121
public void onError(final Exception exception) {
122122
try {
123123
LOGGER.warn(
124-
"Failed to transfer TabletInsertionEvent batch {} (request commit ids={}).",
125-
events.stream().map(EnrichedEvent::coreReportMessage).collect(Collectors.toList()),
126-
events.stream().map(EnrichedEvent::getCommitId).collect(Collectors.toList()),
124+
"Failed to transfer TabletInsertionEvent batch. Total failed events: {}, related pipe names: {}",
125+
events.size(),
126+
events.stream().map(EnrichedEvent::getPipeName).collect(Collectors.toSet()),
127127
exception);
128128
} finally {
129129
connector.addFailureEventsToRetryQueue(events);

0 commit comments

Comments
 (0)