[To dev/1.3] Fix setting illegal default_storage_group_level does not report an error (#14483)

* Fix setting illegal default_storage_group_level does not report an error

(cherry picked from commit 391d153)

* spotless

* allow illegal config during startup

Author: jt2594838

integration-test/src/main/java/org/apache/iotdb/it/env/cluster/config/MppCommonConfig.java

@@ -490,6 +490,12 @@ public CommonConfig setQueryMemoryProportion(String queryMemoryProportion) {
     return this;
   }
 
+  @Override
+  public CommonConfig setDefaultStorageGroupLevel(int defaultStorageGroupLevel) {
+    setProperty("default_storage_group_level", String.valueOf(defaultStorageGroupLevel));
+    return this;
+  }
+
   // For part of the log directory
   public String getClusterConfigStr() {
     return fromConsensusFullNameToAbbr(properties.getProperty(CONFIG_NODE_CONSENSUS_PROTOCOL_CLASS))

integration-test/src/main/java/org/apache/iotdb/it/env/cluster/config/MppSharedCommonConfig.java

@@ -498,4 +498,11 @@ public CommonConfig setQueryMemoryProportion(String queryMemoryProportion) {
     cnConfig.setQueryMemoryProportion(queryMemoryProportion);
     return this;
   }
+
+  @Override
+  public CommonConfig setDefaultStorageGroupLevel(int defaultStorageGroupLevel) {
+    dnConfig.setDefaultStorageGroupLevel(defaultStorageGroupLevel);
+    cnConfig.setDefaultStorageGroupLevel(defaultStorageGroupLevel);
+    return this;
+  }
 }

integration-test/src/main/java/org/apache/iotdb/itbase/env/CommonConfig.java

@@ -155,4 +155,8 @@ CommonConfig setPipeConnectorRequestSliceThresholdBytes(
       int pipeConnectorRequestSliceThresholdBytes);
 
   CommonConfig setQueryMemoryProportion(String queryMemoryProportion);
+
+  default CommonConfig setDefaultStorageGroupLevel(int defaultStorageGroupLevel) {
+    return this;
+  }
 }

integration-test/src/test/java/org/apache/iotdb/db/it/IoTDBSetConfigurationIT.java

@@ -39,11 +39,16 @@
 import java.nio.file.Files;
 import java.sql.Connection;
 import java.sql.ResultSet;
+import java.sql.SQLException;
 import java.sql.Statement;
 import java.util.Arrays;
 import java.util.Properties;
 import java.util.concurrent.TimeUnit;
 
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertTrue;
+
 @RunWith(IoTDBTestRunner.class)
 @Category({LocalStandaloneIT.class})
 public class IoTDBSetConfigurationIT {
@@ -202,4 +207,48 @@ private static File getConfigFile(AbstractNodeWrapper nodeWrapper) {
             + CommonConfig.SYSTEM_CONFIG_NAME;
     return new File(systemPropertiesPath);
   }
+
+  @Test
+  public void testSetDefaultSGLevel() throws SQLException {
+    try (Connection connection = EnvFactory.getEnv().getConnection();
+        Statement statement = connection.createStatement()) {
+      // legal value
+      statement.execute("set configuration \"default_storage_group_level\"=\"3\"");
+      statement.execute("INSERT INTO root.a.b.c.d1(timestamp, s1) VALUES (1, 1)");
+      ResultSet databases = statement.executeQuery("show databases");
+      databases.next();
+      Assert.assertEquals("root.a.b.c", databases.getString(1));
+      assertFalse(databases.next());
+
+      // path too short
+      try {
+        statement.execute("INSERT INTO root.fail(timestamp, s1) VALUES (1, 1)");
+      } catch (SQLException e) {
+        assertEquals(
+            "509: root.fail is not a legal path, because it is no longer than default sg level: 3",
+            e.getMessage());
+      }
+
+      // illegal value
+      try {
+        statement.execute("set configuration \"default_storage_group_level\"=\"-1\"");
+      } catch (SQLException e) {
+        assertTrue(e.getMessage().contains("Illegal defaultStorageGroupLevel: -1, should >= 1"));
+      }
+    }
+
+    // can start with an illegal value
+    EnvFactory.getEnv().cleanClusterEnvironment();
+    EnvFactory.getEnv().getConfig().getCommonConfig().setDefaultStorageGroupLevel(-1);
+    EnvFactory.getEnv().initClusterEnvironment();
+    try (Connection connection = EnvFactory.getEnv().getConnection();
+        Statement statement = connection.createStatement()) {
+      statement.execute("INSERT INTO root.a.b.c.d1(timestamp, s1) VALUES (1, 1)");
+      ResultSet databases = statement.executeQuery("show databases");
+      databases.next();
+      // the default value should take effect
+      Assert.assertEquals("root.a", databases.getString(1));
+      assertFalse(databases.next());
+    }
+  }
 }

iotdb-core/datanode/src/main/java/org/apache/iotdb/db/conf/IoTDBConfig.java

@@ -2433,7 +2433,19 @@ public int getDefaultStorageGroupLevel() {
     return defaultStorageGroupLevel;
   }
 
-  void setDefaultStorageGroupLevel(int defaultStorageGroupLevel) {
+  void setDefaultStorageGroupLevel(int defaultStorageGroupLevel, boolean startUp) {
+    if (defaultStorageGroupLevel < 1) {
+      if (startUp) {
+        logger.warn(
+            "Illegal defaultStorageGroupLevel: {}, should >= 1, use default value 1",
+            defaultStorageGroupLevel);
+        defaultStorageGroupLevel = 1;
+      } else {
+        throw new IllegalArgumentException(
+            String.format(
+                "Illegal defaultStorageGroupLevel: %d, should >= 1", defaultStorageGroupLevel));
+      }
+    }
     this.defaultStorageGroupLevel = defaultStorageGroupLevel;
   }
 

iotdb-core/datanode/src/main/java/org/apache/iotdb/db/conf/IoTDBDescriptor.java

@@ -806,7 +806,8 @@ public void loadProperties(Properties properties) throws BadNodeUrlException, IO
 
     conf.setRpcMaxConcurrentClientNum(maxConcurrentClientNum);
 
-    loadAutoCreateSchemaProps(properties);
+    boolean startUp = true;
+    loadAutoCreateSchemaProps(properties, startUp);
 
     conf.setTsFileStorageFs(
         properties.getProperty("tsfile_storage_fs", conf.getTsFileStorageFs().toString()));
@@ -1627,7 +1628,8 @@ public long getThrottleThresholdWithDirs() {
     return Math.max(Math.min(newThrottleThreshold, MAX_THROTTLE_THRESHOLD), MIN_THROTTLE_THRESHOLD);
   }
 
-  private void loadAutoCreateSchemaProps(Properties properties) throws IOException {
+  private void loadAutoCreateSchemaProps(Properties properties, boolean startUp)
+      throws IOException {
     conf.setAutoCreateSchemaEnabled(
         Boolean.parseBoolean(
             properties.getProperty(
@@ -1659,7 +1661,8 @@ private void loadAutoCreateSchemaProps(Properties properties) throws IOException
             properties.getProperty(
                 "default_storage_group_level",
                 ConfigurationFileUtils.getConfigurationDefaultValue(
-                    "default_storage_group_level"))));
+                    "default_storage_group_level"))),
+        startUp);
     conf.setDefaultBooleanEncoding(
         properties.getProperty(
             "default_boolean_encoding",
@@ -1899,7 +1902,8 @@ public synchronized void loadHotModifiedProps(Properties properties)
       loadTimedService(properties);
       StorageEngine.getInstance().rebootTimedService();
       // update params of creating schema automatically
-      loadAutoCreateSchemaProps(properties);
+      boolean startUp = false;
+      loadAutoCreateSchemaProps(properties, startUp);
 
       // update tsfile-format config
       loadTsFileProps(properties);

iotdb-core/datanode/src/main/java/org/apache/iotdb/db/exception/sql/StatementAnalyzeException.java

@@ -28,4 +28,8 @@ public StatementAnalyzeException(String message) {
   public StatementAnalyzeException(Exception cause) {
     super(cause);
   }
+
+  public StatementAnalyzeException(String message, Throwable cause) {
+    super(message, cause);
+  }
 }

iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/analyze/cache/partition/PartitionCache.java

@@ -384,7 +384,7 @@ private void getStorageGroupCacheResult(
         }
       } catch (TException | MetadataException | ClientManagerException e) {
         throw new StatementAnalyzeException(
-            "An error occurred when executing getDeviceToStorageGroup():" + e.getMessage());
+            "An error occurred when executing getDeviceToDatabase():" + e.getMessage(), e);
       }
     }
   }

iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/utils/MetaUtils.java

@@ -61,8 +61,13 @@ private MetaUtils() {}
   public static PartialPath getStorageGroupPathByLevel(PartialPath path, int level)
       throws MetadataException {
     String[] nodeNames = path.getNodes();
-    if (nodeNames.length <= level || !nodeNames[0].equals(IoTDBConstant.PATH_ROOT)) {
-      throw new IllegalPathException(path.getFullPath());
+    if (nodeNames.length <= level) {
+      throw new IllegalPathException(
+          path.getFullPath(), "it is no longer than default sg level: " + level);
+    }
+    if (!nodeNames[0].equals(IoTDBConstant.PATH_ROOT)) {
+      throw new IllegalPathException(
+          path.getFullPath(), "it does not start with " + IoTDBConstant.PATH_ROOT);
     }
     String[] storageGroupNodes = new String[level + 1];
     System.arraycopy(nodeNames, 0, storageGroupNodes, 0, level + 1);

iotdb-core/datanode/src/test/java/org/apache/iotdb/db/metadata/MetaUtilsTest.java

@@ -45,7 +45,6 @@ public class MetaUtilsTest {
 
   private final IMNodeFactory<IMemMNode> nodeFactory =
       MNodeFactoryLoader.getInstance().getMemMNodeIMNodeFactory();
-  ;
 
   @Test
   public void testGetMultiFullPaths() {
@@ -128,7 +127,9 @@ public void testGetStorageGroupPathByLevel() {
       MetaUtils.getStorageGroupPathByLevel(new PartialPath("root1.laptop.d1.s1"), level);
     } catch (MetadataException e) {
       caughtException = true;
-      assertEquals("root1.laptop.d1.s1 is not a legal path", e.getMessage());
+      assertEquals(
+          "root1.laptop.d1.s1 is not a legal path, because it does not start with root",
+          e.getMessage());
     }
     assertTrue(caughtException);
 
@@ -137,7 +138,9 @@ public void testGetStorageGroupPathByLevel() {
       MetaUtils.getStorageGroupPathByLevel(new PartialPath("root"), level);
     } catch (MetadataException e) {
       caughtException = true;
-      assertEquals("root is not a legal path", e.getMessage());
+      assertEquals(
+          "root is not a legal path, because it is no longer than default sg level: 1",
+          e.getMessage());
     }
     assertTrue(caughtException);
   }