sonar

Author: Caideyipi

iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/persistence/pipe/PipePluginInfo.java

@@ -216,15 +216,7 @@ public TSStatus createPipePlugin(final CreatePipePluginPlan createPipePluginPlan
       final String jarName = pipePluginMeta.getJarName();
 
       if (createPipePluginPlan.getJarFile() != null) {
-        try {
-          pipePluginExecutableManager.savePluginToInstallDir(
-              ByteBuffer.wrap(createPipePluginPlan.getJarFile().getValues()), pluginName, jarName);
-          computeFromPluginClass(pluginName, className);
-        } catch (final Exception e) {
-          // We need to rollback if the creation has failed
-          pipePluginExecutableManager.removePluginFileUnderLibRoot(pluginName, jarName);
-          throw e;
-        }
+        savePipePluginWithRollback(createPipePluginPlan);
       } else {
         final String existed = pipePluginMetaKeeper.getPluginNameByJarName(jarName);
         if (Objects.nonNull(existed)) {
@@ -256,6 +248,23 @@ public TSStatus createPipePlugin(final CreatePipePluginPlan createPipePluginPlan
     }
   }
 
+  private void savePipePluginWithRollback(final CreatePipePluginPlan createPipePluginPlan)
+      throws Exception {
+    final PipePluginMeta pipePluginMeta = createPipePluginPlan.getPipePluginMeta();
+    final String pluginName = pipePluginMeta.getPluginName();
+    final String className = pipePluginMeta.getClassName();
+    final String jarName = pipePluginMeta.getJarName();
+    try {
+      pipePluginExecutableManager.savePluginToInstallDir(
+          ByteBuffer.wrap(createPipePluginPlan.getJarFile().getValues()), pluginName, jarName);
+      computeFromPluginClass(pluginName, className);
+    } catch (final Exception e) {
+      // We need to rollback if the creation has failed
+      pipePluginExecutableManager.removePluginFileUnderLibRoot(pluginName, jarName);
+      throw e;
+    }
+  }
+
   private void computeFromPluginClass(final String pluginName, final String className)
       throws Exception {
     final String pluginDirPath = pipePluginExecutableManager.getPluginsDirPath(pluginName);