Skip to content

Commit c4f1ba6

Browse files
authored
[Py-client] Print Dataset is closed error msg if user continues to fetch from it (#14396)
1 parent 4c21331 commit c4f1ba6

File tree

2 files changed

+9
-6
lines changed

2 files changed

+9
-6
lines changed

iotdb-client/client-py/iotdb/Session.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -516,7 +516,7 @@ def insert_str_record(self, device_id, timestamp, measurements, string_values):
516516
)
517517
measurements = list(filtered_measurements)
518518
values = list(filtered_values)
519-
if len(measurements) is 0 or len(values) is 0:
519+
if len(measurements) == 0 or len(values) == 0:
520520
logger.info("All inserting values are none!")
521521
return
522522
request = self.gen_insert_str_record_req(
@@ -556,7 +556,7 @@ def insert_aligned_str_record(
556556
)
557557
measurements = list(filtered_measurements)
558558
values = list(filtered_values)
559-
if len(measurements) is 0 or len(values) is 0:
559+
if len(measurements) == 0 or len(values) == 0:
560560
logger.info("All inserting values are none!")
561561
return
562562
request = self.gen_insert_str_record_req(
@@ -605,7 +605,7 @@ def insert_record(self, device_id, timestamp, measurements, data_types, values):
605605
measurements = list(filtered_measurements)
606606
data_types = list(filtered_data_types)
607607
values = list(filtered_values)
608-
if len(measurements) is 0 or len(data_types) is 0 or len(values) is 0:
608+
if len(measurements) == 0 or len(data_types) == 0 or len(values) == 0:
609609
logger.info("All inserting values are none!")
610610
return
611611
request = self.gen_insert_record_req(
@@ -651,7 +651,7 @@ def insert_records(
651651
) = self.__filter_lists_by_values(
652652
device_ids, times, measurements_lst, types_lst, values_lst
653653
)
654-
if len(device_ids) is 0:
654+
if len(device_ids) == 0:
655655
logger.info("All inserting values are none!")
656656
return
657657
if self.__enable_redirection:
@@ -734,7 +734,7 @@ def insert_aligned_record(
734734
measurements = list(filtered_measurements)
735735
data_types = list(filtered_data_types)
736736
values = list(filtered_values)
737-
if len(measurements) is 0 or len(data_types) is 0 or len(values) is 0:
737+
if len(measurements) == 0 or len(data_types) == 0 or len(values) == 0:
738738
logger.info("All inserting values are none!")
739739
return
740740
request = self.gen_insert_record_req(
@@ -780,7 +780,7 @@ def insert_aligned_records(
780780
) = self.__filter_lists_by_values(
781781
device_ids, times, measurements_lst, types_lst, values_lst
782782
)
783-
if len(device_ids) is 0:
783+
if len(device_ids) == 0:
784784
logger.info("All inserting values are none!")
785785
return
786786
if self.__enable_redirection:

iotdb-client/client-py/iotdb/utils/IoTDBRpcDataSet.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
from thrift.transport import TTransport
2626
from iotdb.thrift.rpc.IClientRPCService import TSFetchResultsReq, TSCloseOperationReq
2727
from iotdb.tsfile.utils.DateUtils import parse_int_to_date
28+
from iotdb.utils.IoTDBConnectionException import IoTDBConnectionException
2829
from iotdb.utils.IoTDBConstants import TSDataType
2930

3031
logger = logging.getLogger("IoTDB")
@@ -417,6 +418,8 @@ def result_set_to_pandas(self):
417418
return df
418419

419420
def fetch_results(self):
421+
if self.__is_closed:
422+
raise IoTDBConnectionException("This DataSet is already closed")
420423
self.__rows_index = 0
421424
request = TSFetchResultsReq(
422425
self.__session_id,

0 commit comments

Comments
 (0)