Skip to content

Commit e393847

Browse files
committed
remove ch.qos.logback dependency in UT
1 parent 6865c24 commit e393847

File tree

1 file changed

+14
-16
lines changed

1 file changed

+14
-16
lines changed

iotdb-core/datanode/src/test/java/org/apache/iotdb/db/queryengine/execution/fragment/FragmentInstanceExecutionTest.java

Lines changed: 14 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
package org.apache.iotdb.db.queryengine.execution.fragment;
2121

2222
import org.apache.iotdb.commons.concurrent.IoTDBThreadPoolFactory;
23-
import org.apache.iotdb.commons.memory.AtomicLongMemoryBlock;
2423
import org.apache.iotdb.db.conf.IoTDBDescriptor;
2524
import org.apache.iotdb.db.queryengine.common.FragmentInstanceId;
2625
import org.apache.iotdb.db.queryengine.common.PlanFragmentId;
@@ -34,16 +33,13 @@
3433
import org.apache.iotdb.db.utils.datastructure.AlignedTVList;
3534
import org.apache.iotdb.db.utils.datastructure.TVList;
3635

37-
import ch.qos.logback.classic.Level;
38-
import ch.qos.logback.classic.Logger;
39-
import ch.qos.logback.classic.spi.ILoggingEvent;
40-
import ch.qos.logback.core.read.ListAppender;
4136
import com.google.common.collect.ImmutableMap;
4237
import org.apache.tsfile.enums.TSDataType;
4338
import org.junit.Test;
4439
import org.mockito.Mockito;
45-
import org.slf4j.LoggerFactory;
4640

41+
import java.io.ByteArrayOutputStream;
42+
import java.io.PrintStream;
4743
import java.util.ArrayList;
4844
import java.util.Collections;
4945
import java.util.List;
@@ -53,6 +49,7 @@
5349
import static org.apache.iotdb.db.queryengine.common.QueryId.MOCK_QUERY_ID;
5450
import static org.apache.iotdb.db.queryengine.execution.fragment.FragmentInstanceContext.createFragmentInstanceContext;
5551
import static org.junit.Assert.assertEquals;
52+
import static org.junit.Assert.assertFalse;
5653
import static org.junit.Assert.assertTrue;
5754
import static org.junit.Assert.fail;
5855

@@ -102,14 +99,10 @@ public void testFragmentInstanceExecution() {
10299

103100
@Test
104101
public void testTVListOwnerTransfer() throws InterruptedException {
105-
Logger logger = (Logger) LoggerFactory.getLogger(AtomicLongMemoryBlock.class);
106-
ListAppender<ILoggingEvent> listAppender = new ListAppender<>();
107-
listAppender.start();
108-
109-
// set log level
110-
logger.setLevel(Level.WARN);
111-
logger.setAdditive(false);
112-
logger.addAppender(listAppender);
102+
// Capture System.err to check for warning messages
103+
PrintStream systemOut = System.out;
104+
ByteArrayOutputStream logPrint = new ByteArrayOutputStream();
105+
System.setOut(new PrintStream(logPrint));
113106

114107
try {
115108
IoTDBDescriptor.getInstance().getConfig().setDataNodeId(1);
@@ -155,10 +148,15 @@ public void testTVListOwnerTransfer() throws InterruptedException {
155148
instanceNotificationExecutor.shutdown();
156149
}
157150
} finally {
158-
logger.detachAppender(listAppender);
151+
// Restore original System.out
152+
System.setErr(systemOut);
153+
159154
// should not contain warn message: "The memory cost to be released is larger than the memory
160155
// cost of memory block"
161-
assertEquals(0, listAppender.list.size());
156+
String capturedOutput = logPrint.toString();
157+
assertFalse(
158+
"Should not contain warning message",
159+
capturedOutput.contains("The memory cost to be released is larger than the memory"));
162160
}
163161
}
164162

0 commit comments

Comments
 (0)