[ENHANCEMENT] Log http error code upon unexpected exception calling p… (#2711)

Author: chibenwa

server/protocols/jmap-rfc-8621-integration-tests/jmap-rfc-8621-integration-tests-common/src/main/scala/org/apache/james/jmap/rfc8621/contract/PushSubscriptionSetMethodContract.scala

@@ -2373,7 +2373,7 @@ trait PushSubscriptionSetMethodContract {
            |                "notCreated": {
            |                    "4f29": {
            |                        "type": "serverFail",
-           |                        "description": "Error when call to Push Server. "
+           |                        "description": "Error when call to Push Server: code 500. "
            |                    }
            |                }
            |            },

server/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/pushsubscription/WebPushClient.scala

@@ -65,9 +65,9 @@ object WebPushClientHeader {
 
 sealed abstract class WebPushException(message: String) extends RuntimeException(message)
 
-case class WebPushInvalidRequestException(detailError: String) extends WebPushException(s"Bad request when call to Push Server. ${detailError}")
+case class WebPushInvalidRequestException(detailError: String) extends WebPushException(s"Bad request when call to Push Server. $detailError")
 
-case class WebPushTemporarilyUnavailableException(detailError: String) extends WebPushException(s"Error when call to Push Server. ${detailError}")
+case class WebPushTemporarilyUnavailableException(httpCode: Int, detailError: String) extends WebPushException(s"Error when call to Push Server: code $httpCode. $detailError")
 
 object DefaultWebPushClient {
   val PUSH_SERVER_ERROR_RESPONSE_MAX_LENGTH: Int = 1024
@@ -131,8 +131,8 @@ class DefaultWebPushClient @Inject()(configuration: PushClientConfiguration) ext
         case HttpResponseStatus.CREATED => Mono.empty()
         case HttpResponseStatus.BAD_REQUEST => preProcessingData(dataBuf)
           .flatMap(string => Mono.error(WebPushInvalidRequestException(string)))
-        case _ => preProcessingData(dataBuf)
-          .flatMap(string => Mono.error(WebPushTemporarilyUnavailableException(string)))
+        case statusCode: HttpResponseStatus => preProcessingData(dataBuf)
+          .flatMap(string => Mono.error(WebPushTemporarilyUnavailableException(statusCode.code, string)))
       }.`then`()
 
   private def preProcessingData(dataBuf: ByteBufMono): Mono[String] =