chore: remove SpotBugs verifications

SpotBugs is slow, it is problematic, it requires dependency updates,
it fails like in spotbugs/spotbugs-gradle-plugin#1508

Author: vlsi

build-logic/build-parameters/build.gradle.kts

@@ -62,18 +62,10 @@ buildParameters {
     string("jdkTestImplementation") {
         description.set("Vendor-specific virtual machine implementation to use testing JMeter (see https://docs.gradle.org/8.0/userguide/toolchains.html#selecting_toolchains_by_virtual_machine_implementation)")
     }
-    bool("spotbugs") {
-        defaultValue.set(false)
-        description.set("Run SpotBugs verifications")
-    }
     bool("sonarqube") {
         defaultValue.set(false)
         description.set("Report verification results to Sonarqube")
     }
-    bool("ignoreSpotBugsFailures") {
-        defaultValue.set(false)
-        description.set("Ignore SpotBugs failures")
-    }
     bool("skipAutostyle") {
         defaultValue.set(false)
         description.set("Skip AutoStyle verifications")

build-logic/verification/build.gradle.kts

@@ -23,7 +23,6 @@ dependencies {
     api(projects.basics)
     api(projects.buildParameters)
     api("com.github.autostyle:com.github.autostyle.gradle.plugin:4.0")
-    api("com.github.spotbugs:com.github.spotbugs.gradle.plugin:6.0.4")
     api("com.github.vlsi.ide:com.github.vlsi.ide.gradle.plugin:2.0.0")
     api("com.github.vlsi.gradle-extensions:com.github.vlsi.gradle-extensions.gradle.plugin:2.0.0")
     api("de.thetaphi.forbiddenapis:de.thetaphi.forbiddenapis.gradle.plugin:3.10")

build-logic/verification/src/main/kotlin/build-logic.sonarqube-aggregate.gradle.kts

@@ -15,7 +15,6 @@
  * limitations under the License.
  */
 
-import com.github.spotbugs.snom.SpotBugsTask
 import jacoco.JacocoAggregateReportSpec
 
 plugins {
@@ -68,26 +67,3 @@ plugins.withId("build-params.jacoco-aggregation") {
         }
     }
 }
-
-subprojects {
-    plugins.withId("com.github.spotbugs") {
-        val spotBugTasks = tasks.withType<SpotBugsTask>().matching {
-            // We don't send spotbugs for test classes
-            !it.name.endsWith("Test")
-        }
-        sonarTask {
-            dependsOn(spotBugTasks)
-        }
-        sonar {
-            properties {
-                property(
-                    "sonar.java.spotbugs.reportPaths",
-                    spotBugTasks.asSequence()
-                        .map {
-                            it.reports.named("XML").get().outputLocation.asFile.get()
-                        }
-                )
-            }
-        }
-    }
-}

build-logic/verification/src/main/kotlin/build-logic.spotbugs.gradle.kts

@@ -42,9 +42,6 @@ plugins.withId("java-base") {
     if (buildParameters.enableErrorprone) {
         apply(plugin = "build-logic.errorprone")
     }
-    if (buildParameters.spotbugs) {
-        apply(plugin = "build-logic.spotbugs")
-    }
     if (buildParameters.coverage) {
         apply(plugin = "build-logic.jacoco")
     }

build-logic/verification/src/main/kotlin/build-logic.style.gradle.kts

@@ -295,11 +295,6 @@
             <sha256 value="dc0e8e782ba0dac5c4d0d8678081c11380a5c793b3c46f2d0f8d242d1733b62b" origin="Generated by Gradle" reason="Artifact is not signed"/>
          </artifact>
       </component>
-      <component group="com.github.spotbugs" name="com.github.spotbugs.gradle.plugin" version="6.0.4">
-         <artifact name="com.github.spotbugs.gradle.plugin-6.0.4.pom">
-            <sha256 value="f029abeb54aa13d5631ece27f58f2e20039cb28b9ce3b1b314947af5b06d8a65" origin="Generated by Gradle" reason="Artifact is not signed"/>
-         </artifact>
-      </component>
       <component group="com.github.vlsi.crlf" name="com.github.vlsi.crlf.gradle.plugin" version="2.0.0">
          <artifact name="com.github.vlsi.crlf.gradle.plugin-2.0.0.pom">
             <sha256 value="fdd676d789d97e249bb312568659343e40bb68ab2cc7bb355e5f925a71a2e67d" origin="Generated by Gradle" reason="Artifact is not signed"/>