MINOR: Declare the inner RocksDBDualCFRangeIterator class as static (#20220)

jim0987795064 · web-flow · commit 0086f2410132 · 2025-07-23T21:37:48.000+08:00
Make inner classes static. from: #20182 (comment) Reviewers: Ken Huang <s7133700@gmail.com>, Chia-Ping Tsai <chia7712@gmail.com>
diff --git a/streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBTimestampedStore.java b/streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBTimestampedStore.java
@@ -404,7 +404,7 @@ public void onClose(final Runnable closeCallback) {
         }
     }
 
-    private class RocksDBDualCFRangeIterator extends RocksDBDualCFIterator {
+    private static class RocksDBDualCFRangeIterator extends RocksDBDualCFIterator {
         // RocksDB's JNI interface does not expose getters/setters that allow the
         // comparator to be pluggable, and the default is lexicographic, so it's
         // safe to just force lexicographic comparator here for now.

Original file line number	Diff line number	Diff line change
`@@ -404,7 +404,7 @@ public void onClose(final Runnable closeCallback) {`
`404`	`404`	`}`
`405`	`405`	`}`
`406`	`406`
`407`		`- private class RocksDBDualCFRangeIterator extends RocksDBDualCFIterator {`
	`407`	`+ private static class RocksDBDualCFRangeIterator extends RocksDBDualCFIterator {`
`408`	`408`	`// RocksDB's JNI interface does not expose getters/setters that allow the`
`409`	`409`	`// comparator to be pluggable, and the default is lexicographic, so it's`
`410`	`410`	`// safe to just force lexicographic comparator here for now.`