Skip to content

Commit 02d58b1

Browse files
committed
KAFKA-19418: Fix for flaky verifiable producer system test (#20001)
Fix to avoid flakiness in verifiable producer system test. The test lists running processes and greps to find the VerifiableProducer one, but wasn't providing an specific pattern to grep (so flaky if there were more than one process containing the default grep pattern "kafka") Fix by passing a "proc_grep_string" to filter when looking for the VerifiableProducer process. All test pass successfully after the change. Reviewers: PoAn Yang <[email protected]>, Andrew Schofield <[email protected]>
1 parent eeafe0a commit 02d58b1

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

tests/kafkatest/sanity_checks/test_verifiable_producer.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ def test_simple_run(self, producer_version, acks=None, enable_idempotence=False,
7171
wait_until(lambda: self.producer.num_acked > 5, timeout_sec=15,
7272
err_msg="Producer failed to start in a reasonable amount of time.")
7373

74-
assert is_version(node, [node.version.vstring], logger=self.logger)
74+
assert is_version(node, [node.version.vstring], proc_grep_string=VerifiableProducer.__qualname__, logger=self.logger)
7575

7676
self.producer.wait()
7777
num_produced = self.producer.num_acked
@@ -113,8 +113,8 @@ def test_multiple_kraft_security_protocols(
113113
wait_until(lambda: self.producer.num_acked > 5, timeout_sec=15,
114114
err_msg="Producer failed to start in a reasonable amount of time.")
115115

116-
# See above comment above regarding use of version.vstring (distutils.version.LooseVersion)
117-
assert is_version(node, [node.version.vstring], logger=self.logger)
116+
# See comment above regarding use of version.vstring (distutils.version.LooseVersion)
117+
assert is_version(node, [node.version.vstring], proc_grep_string=VerifiableProducer.__qualname__, logger=self.logger)
118118

119119
self.producer.wait()
120120
num_produced = self.producer.num_acked
@@ -144,8 +144,8 @@ def test_multiple_kraft_sasl_mechanisms(self, metadata_quorum):
144144
wait_until(lambda: self.producer.num_acked > 5, timeout_sec=15,
145145
err_msg="Producer failed to start in a reasonable amount of time.")
146146

147-
# See above comment above regarding use of version.vstring (distutils.version.LooseVersion)
148-
assert is_version(node, [node.version.vstring], logger=self.logger)
147+
# See comment above regarding use of version.vstring (distutils.version.LooseVersion)
148+
assert is_version(node, [node.version.vstring], proc_grep_string=VerifiableProducer.__qualname__, logger=self.logger)
149149

150150
self.producer.wait()
151151
num_produced = self.producer.num_acked

0 commit comments

Comments
 (0)