apply

Vincent Potucek · Vincent Potucek · commit a5475f82b0ff · 2025-07-26T17:53:33.000+02:00
diff --git a/clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java b/clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java
@@ -149,7 +149,6 @@ public abstract class ConsumerCoordinatorTest {
     private final long retryBackoffMaxMs = 1000;
     private final int autoCommitIntervalMs = 2000;
     private final int requestTimeoutMs = 30000;
-    private final int throttleMs = 10;
     private final MockTime time = new MockTime();
     private GroupRebalanceConfig rebalanceConfig;
 
diff --git a/clients/src/test/java/org/apache/kafka/common/security/oauthbearer/internals/secured/OAuthBearerTest.java b/clients/src/test/java/org/apache/kafka/common/security/oauthbearer/internals/secured/OAuthBearerTest.java
@@ -46,6 +46,7 @@
 import java.net.URL;
 import java.nio.ByteBuffer;
 import java.nio.channels.FileChannel;
+import java.nio.file.Files;
 import java.nio.file.StandardOpenOption;
 import java.security.KeyPair;
 import java.security.KeyPairGenerator;
@@ -236,7 +237,7 @@ protected JwtConsumer jwtConsumer(PublicKey publicKey) {
     }
 
     protected File generatePrivateKey(PrivateKey privateKey) throws IOException {
-        File file = File.createTempFile("private-", ".key");
+        File file = Files.createTempFile("private-", ".key").toFile();
         byte[] bytes = Base64.getEncoder().encode(privateKey.getEncoded());
 
         try (FileChannel channel = FileChannel.open(file.toPath(), EnumSet.of(StandardOpenOption.WRITE))) {
diff --git a/clients/src/test/java/org/apache/kafka/common/security/oauthbearer/internals/secured/assertion/DefaultAssertionCreatorTest.java b/clients/src/test/java/org/apache/kafka/common/security/oauthbearer/internals/secured/assertion/DefaultAssertionCreatorTest.java
@@ -19,7 +19,6 @@
 import org.apache.kafka.common.KafkaException;
 import org.apache.kafka.common.security.oauthbearer.internals.secured.OAuthBearerTest;
 import org.apache.kafka.common.utils.MockTime;
-import org.apache.kafka.common.utils.Time;
 
 import org.jose4j.jwt.consumer.JwtContext;
 import org.jose4j.jwx.JsonWebStructure;
@@ -165,8 +164,6 @@ public void testInvalidAlgorithm() throws IOException {
     }
 
     private static class Builder {
-
-        private final Time time = new MockTime();
         private String algorithm = TOKEN_SIGNING_ALGORITHM_RS256;
         private File privateKeyFile;
         private Optional<String> passphrase = Optional.empty();
diff --git a/connect/file/src/test/java/org/apache/kafka/connect/file/FileStreamSourceTaskTest.java b/connect/file/src/test/java/org/apache/kafka/connect/file/FileStreamSourceTaskTest.java
@@ -53,7 +53,7 @@ public class FileStreamSourceTaskTest {
 
     @BeforeEach
     public void setup() throws IOException {
-        tempFile = File.createTempFile("file-stream-source-task-test", null);
+        tempFile = Files.createTempFile("file-stream-source-task-test", null).toFile();
         config = new HashMap<>();
         config.put(FileStreamSourceConnector.FILE_CONFIG, tempFile.getAbsolutePath());
         config.put(FileStreamSourceConnector.TOPIC_CONFIG, TOPIC);
diff --git a/connect/runtime/src/test/java/org/apache/kafka/connect/storage/FileOffsetBackingStoreTest.java b/connect/runtime/src/test/java/org/apache/kafka/connect/storage/FileOffsetBackingStoreTest.java
@@ -81,7 +81,7 @@ public void setup() {
         when(converter.toConnectData(anyString(), any(byte[].class))).thenReturn(new SchemaAndValue(null,
                 Arrays.asList("connector", Collections.singletonMap("partitionKey", "dummy"))));
         store = new FileOffsetBackingStore(converter);
-        tempFile = assertDoesNotThrow(() -> File.createTempFile("fileoffsetbackingstore", null));
+        tempFile = assertDoesNotThrow(() -> Files.createTempFile("fileoffsetbackingstore", null).toFile());
         Map<String, String> props = new HashMap<>();
         props.put(StandaloneConfig.OFFSET_STORAGE_FILE_FILENAME_CONFIG, tempFile.getAbsolutePath());
         props.put(StandaloneConfig.KEY_CONVERTER_CLASS_CONFIG, "org.apache.kafka.connect.json.JsonConverter");
diff --git a/connect/runtime/src/test/resources/test-plugins/bad-packaging/test/plugins/StaticInitializerThrowsRestExtension.java b/connect/runtime/src/test/resources/test-plugins/bad-packaging/test/plugins/StaticInitializerThrowsRestExtension.java
@@ -18,14 +18,10 @@
 package test.plugins;
 
 import java.io.IOException;
-import java.util.List;
 import java.util.Map;
 
-import org.apache.kafka.common.config.ConfigDef;
-import org.apache.kafka.connect.connector.Task;
 import org.apache.kafka.connect.rest.ConnectRestExtension;
 import org.apache.kafka.connect.rest.ConnectRestExtensionContext;
-import org.apache.kafka.connect.sink.SinkConnector;
 
 /**
  * Fake plugin class for testing classloading isolation.
diff --git a/connect/runtime/src/test/resources/test-plugins/classpath-converter/org/apache/kafka/connect/converters/ByteArrayConverter.java b/connect/runtime/src/test/resources/test-plugins/classpath-converter/org/apache/kafka/connect/converters/ByteArrayConverter.java
@@ -19,17 +19,14 @@
 import org.apache.kafka.common.config.ConfigDef;
 import org.apache.kafka.common.utils.AppInfoParser;
 import org.apache.kafka.connect.components.Versioned;
-import org.apache.kafka.connect.connector.Task;
 import org.apache.kafka.connect.data.Schema;
 import org.apache.kafka.connect.data.SchemaAndValue;
 import org.apache.kafka.connect.errors.DataException;
-import org.apache.kafka.connect.sink.SinkConnector;
 import org.apache.kafka.connect.storage.Converter;
 import org.apache.kafka.connect.storage.ConverterConfig;
 import org.apache.kafka.connect.storage.HeaderConverter;
 
 import java.nio.ByteBuffer;
-import java.util.List;
 import java.util.Map;
 
 public class ByteArrayConverter implements Converter, HeaderConverter, Versioned {
diff --git a/connect/runtime/src/test/resources/test-plugins/sampling-config-provider/test/plugins/SamplingConfigProvider.java b/connect/runtime/src/test/resources/test-plugins/sampling-config-provider/test/plugins/SamplingConfigProvider.java
@@ -27,11 +27,7 @@
 import org.apache.kafka.common.config.provider.ConfigProvider;
 import org.apache.kafka.common.config.ConfigData;
 import org.apache.kafka.common.config.ConfigChangeCallback;
-import org.apache.kafka.connect.data.Schema;
-import org.apache.kafka.connect.data.SchemaAndValue;
-import org.apache.kafka.connect.storage.Converter;
 import org.apache.kafka.connect.runtime.isolation.SamplingTestPlugin;
-import org.apache.kafka.connect.storage.HeaderConverter;
 
 /**
  * Fake plugin class for testing classloading isolation.
diff --git a/connect/runtime/src/test/resources/test-plugins/sampling-connector/test/plugins/SamplingConnector.java b/connect/runtime/src/test/resources/test-plugins/sampling-connector/test/plugins/SamplingConnector.java
@@ -17,7 +17,6 @@
 
 package test.plugins;
 
-import java.io.IOException;
 import java.util.Collections;
 import java.util.ArrayList;
 import java.util.List;
diff --git a/connect/runtime/src/test/resources/test-plugins/sampling-header-converter/test/plugins/SamplingHeaderConverter.java b/connect/runtime/src/test/resources/test-plugins/sampling-header-converter/test/plugins/SamplingHeaderConverter.java
@@ -26,7 +26,6 @@
 import org.apache.kafka.common.config.ConfigDef;
 import org.apache.kafka.connect.data.Schema;
 import org.apache.kafka.connect.data.SchemaAndValue;
-import org.apache.kafka.connect.storage.Converter;
 import org.apache.kafka.connect.runtime.isolation.SamplingTestPlugin;
 import org.apache.kafka.connect.storage.HeaderConverter;
 
diff --git a/connect/runtime/src/test/resources/test-plugins/subclass-of-classpath/test/plugins/SubclassOfClasspathOverridePolicy.java b/connect/runtime/src/test/resources/test-plugins/subclass-of-classpath/test/plugins/SubclassOfClasspathOverridePolicy.java
@@ -18,7 +18,6 @@
 package test.plugins;
 
 import org.apache.kafka.connect.connector.policy.AllConnectorClientConfigOverridePolicy;
-import org.apache.kafka.connect.converters.ByteArrayConverter;
 
 /**
  * Fake plugin class for testing classloading isolation.
diff --git a/connect/runtime/src/test/resources/test-plugins/versioned-predicate/test/plugins/VersionedPredicate.java b/connect/runtime/src/test/resources/test-plugins/versioned-predicate/test/plugins/VersionedPredicate.java
@@ -18,7 +18,6 @@
 package test.plugins;
 
 import org.apache.kafka.common.config.ConfigDef;
-import org.apache.kafka.common.utils.AppInfoParser;
 import org.apache.kafka.connect.components.Versioned;
 import org.apache.kafka.connect.connector.ConnectRecord;
 import org.apache.kafka.connect.transforms.predicates.Predicate;
diff --git a/connect/runtime/src/test/resources/test-plugins/versioned-transformation/test/plugins/VersionedTransformation.java b/connect/runtime/src/test/resources/test-plugins/versioned-transformation/test/plugins/VersionedTransformation.java
@@ -18,7 +18,6 @@
 package test.plugins;
 
 import org.apache.kafka.common.config.ConfigDef;
-import org.apache.kafka.common.utils.AppInfoParser;
 import org.apache.kafka.connect.components.Versioned;
 import org.apache.kafka.connect.connector.ConnectRecord;
 import org.apache.kafka.connect.transforms.Transformation;
diff --git a/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/metrics/GroupCoordinatorMetricsShard.java b/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/metrics/GroupCoordinatorMetricsShard.java
@@ -26,9 +26,6 @@
 import org.apache.kafka.timeline.SnapshotRegistry;
 import org.apache.kafka.timeline.TimelineLong;
 
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-
 import java.util.Map;
 import java.util.Objects;
 import java.util.concurrent.atomic.AtomicLong;
@@ -43,8 +40,6 @@
  */
 public class GroupCoordinatorMetricsShard implements CoordinatorMetricsShard {
 
-    private static final Logger log = LoggerFactory.getLogger(GroupCoordinatorMetricsShard.class);
-
     /**
      * This class represents a gauge counter for this shard. The TimelineLong object represents a gauge backed by
      * the snapshot registry. Once we commit to a certain offset in the snapshot registry, we write the given
diff --git a/group-coordinator/src/test/java/org/apache/kafka/coordinator/group/streams/TargetAssignmentBuilderTest.java b/group-coordinator/src/test/java/org/apache/kafka/coordinator/group/streams/TargetAssignmentBuilderTest.java
@@ -664,7 +664,6 @@ public static class TargetAssignmentBuilderTestContext {
         private final ConfiguredTopology topology = new ConfiguredTopology(0, 0, Optional.of(subtopologies), new HashMap<>(),
             Optional.empty());
         private final Map<String, StreamsGroupMember> members = new HashMap<>();
-        private final Map<String, org.apache.kafka.coordinator.group.streams.TopicMetadata> subscriptionMetadata = new HashMap<>();
         private final Map<String, StreamsGroupMember> updatedMembers = new HashMap<>();
         private final Map<String, TasksTuple> targetAssignment = new HashMap<>();
         private final Map<String, MemberAssignment> memberAssignments = new HashMap<>();
diff --git a/jmh-benchmarks/src/main/java/org/apache/kafka/jmh/producer/ProducerResponseBenchmark.java b/jmh-benchmarks/src/main/java/org/apache/kafka/jmh/producer/ProducerResponseBenchmark.java
@@ -73,8 +73,6 @@ private static ProduceResponse response() {
         return new ProduceResponse(PARTITION_RESPONSE_MAP);
     }
 
-    private static final ProduceResponse RESPONSE = response();
-
     @Benchmark
     @OutputTimeUnit(TimeUnit.NANOSECONDS)
     public AbstractResponse constructorProduceResponse() {
diff --git a/server-common/src/test/java/org/apache/kafka/server/common/MetadataVersionTest.java b/server-common/src/test/java/org/apache/kafka/server/common/MetadataVersionTest.java
@@ -23,7 +23,31 @@
 import org.junit.jupiter.params.ParameterizedTest;
 import org.junit.jupiter.params.provider.EnumSource;
 
-import static org.apache.kafka.server.common.MetadataVersion.*;
+import static org.apache.kafka.server.common.MetadataVersion.IBP_3_3_IV3;
+import static org.apache.kafka.server.common.MetadataVersion.IBP_3_4_IV0;
+import static org.apache.kafka.server.common.MetadataVersion.IBP_3_5_IV0;
+import static org.apache.kafka.server.common.MetadataVersion.IBP_3_5_IV1;
+import static org.apache.kafka.server.common.MetadataVersion.IBP_3_5_IV2;
+import static org.apache.kafka.server.common.MetadataVersion.IBP_3_6_IV0;
+import static org.apache.kafka.server.common.MetadataVersion.IBP_3_6_IV1;
+import static org.apache.kafka.server.common.MetadataVersion.IBP_3_6_IV2;
+import static org.apache.kafka.server.common.MetadataVersion.IBP_3_7_IV0;
+import static org.apache.kafka.server.common.MetadataVersion.IBP_3_7_IV1;
+import static org.apache.kafka.server.common.MetadataVersion.IBP_3_7_IV2;
+import static org.apache.kafka.server.common.MetadataVersion.IBP_3_7_IV3;
+import static org.apache.kafka.server.common.MetadataVersion.IBP_3_7_IV4;
+import static org.apache.kafka.server.common.MetadataVersion.IBP_3_8_IV0;
+import static org.apache.kafka.server.common.MetadataVersion.IBP_3_9_IV0;
+import static org.apache.kafka.server.common.MetadataVersion.IBP_4_0_IV0;
+import static org.apache.kafka.server.common.MetadataVersion.IBP_4_0_IV1;
+import static org.apache.kafka.server.common.MetadataVersion.IBP_4_0_IV2;
+import static org.apache.kafka.server.common.MetadataVersion.IBP_4_0_IV3;
+import static org.apache.kafka.server.common.MetadataVersion.IBP_4_1_IV0;
+import static org.apache.kafka.server.common.MetadataVersion.IBP_4_1_IV1;
+import static org.apache.kafka.server.common.MetadataVersion.IBP_4_2_IV0;
+import static org.apache.kafka.server.common.MetadataVersion.IBP_4_2_IV1;
+import static org.apache.kafka.server.common.MetadataVersion.LATEST_PRODUCTION;
+import static org.apache.kafka.server.common.MetadataVersion.MINIMUM_VERSION;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertFalse;
 import static org.junit.jupiter.api.Assertions.assertTrue;
diff --git a/server-common/src/test/java/org/apache/kafka/server/share/persister/PersisterStateManagerTest.java b/server-common/src/test/java/org/apache/kafka/server/share/persister/PersisterStateManagerTest.java
@@ -96,7 +96,6 @@ private static class PersisterStateManagerBuilder {
         private Time time = MOCK_TIME;
         private Timer timer = MOCK_TIMER;
         private ShareCoordinatorMetadataCacheHelper cacheHelper = CACHE_HELPER;
-        private int requestTimeoutMs =  Math.toIntExact(CommonClientConfigs.DEFAULT_SOCKET_CONNECTION_SETUP_TIMEOUT_MAX_MS);
 
         private PersisterStateManagerBuilder withKafkaClient(KafkaClient client) {
             this.client = client;
diff --git a/streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/MetricsIntegrationTest.java b/streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/MetricsIntegrationTest.java
@@ -157,10 +157,6 @@ public static void closeCluster() {
     private static final String PROCESS_LATENCY_MAX = "process-latency-max";
     private static final String PUNCTUATE_LATENCY_AVG = "punctuate-latency-avg";
     private static final String PUNCTUATE_LATENCY_MAX = "punctuate-latency-max";
-    private static final String CREATE_LATENCY_AVG = "create-latency-avg";
-    private static final String CREATE_LATENCY_MAX = "create-latency-max";
-    private static final String DESTROY_LATENCY_AVG = "destroy-latency-avg";
-    private static final String DESTROY_LATENCY_MAX = "destroy-latency-max";
     private static final String PROCESS_RATE = "process-rate";
     private static final String PROCESS_TOTAL = "process-total";
     private static final String PROCESS_RATIO = "process-ratio";
@@ -171,12 +167,6 @@ public static void closeCluster() {
     private static final String PUNCTUATE_RATIO = "punctuate-ratio";
     private static final String THREAD_STATE = "thread-state";
     private static final String THREAD_STATE_JMX = "state";
-    private static final String CREATE_RATE = "create-rate";
-    private static final String CREATE_TOTAL = "create-total";
-    private static final String DESTROY_RATE = "destroy-rate";
-    private static final String DESTROY_TOTAL = "destroy-total";
-    private static final String FORWARD_TOTAL = "forward-total";
-    private static final String FORWARD_RATE = "forward-rate";
     private static final String STREAM_STRING = "stream";
     private static final String COMMIT_LATENCY_AVG = "commit-latency-avg";
     private static final String COMMIT_LATENCY_MAX = "commit-latency-max";
@@ -200,9 +190,6 @@ public static void closeCluster() {
     private static final String THREAD_START_TIME = "thread-start-time";
     private static final String ACTIVE_PROCESS_RATIO = "active-process-ratio";
     private static final String ACTIVE_BUFFER_COUNT = "active-buffer-count";
-
-    private static final String SKIPPED_RECORDS_RATE = "skipped-records-rate";
-    private static final String SKIPPED_RECORDS_TOTAL = "skipped-records-total";
     private static final String RECORD_LATENESS_AVG = "record-lateness-avg";
     private static final String RECORD_LATENESS_MAX = "record-lateness-max";
     private static final String HIT_RATIO_AVG = "hit-ratio-avg";
@@ -214,8 +201,6 @@ public static void closeCluster() {
     private static final String SUPPRESSION_BUFFER_COUNT_CURRENT = "suppression-buffer-count-current";
     private static final String SUPPRESSION_BUFFER_COUNT_AVG = "suppression-buffer-count-avg";
     private static final String SUPPRESSION_BUFFER_COUNT_MAX = "suppression-buffer-count-max";
-    private static final String EXPIRED_WINDOW_RECORD_DROP_RATE = "expired-window-record-drop-rate";
-    private static final String EXPIRED_WINDOW_RECORD_DROP_TOTAL = "expired-window-record-drop-total";
     private static final String RECORD_E2E_LATENCY_AVG = "record-e2e-latency-avg";
     private static final String RECORD_E2E_LATENCY_MIN = "record-e2e-latency-min";
     private static final String RECORD_E2E_LATENCY_MAX = "record-e2e-latency-max";
diff --git a/streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/NamedTopologyIntegrationTest.java b/streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/NamedTopologyIntegrationTest.java
@@ -117,13 +117,6 @@ public class NamedTopologyIntegrationTest {
 
     // "delayed" input topics which are empty at start to allow control over when input data appears
     private static final String DELAYED_INPUT_STREAM_1 = "delayed-input-stream-1";
-    private static final String DELAYED_INPUT_STREAM_2 = "delayed-input-stream-2";
-
-    // topic that is not initially created during the test setup
-    private static final String NEW_STREAM = "new-stream";
-
-    // existing topic that is pre-filled but cleared between tests
-    private static final String EXISTING_STREAM = "existing-stream";
 
     // topic created with just one partition
     private static final String SINGLE_PARTITION_INPUT_STREAM = "single-partition-input-stream";
diff --git a/streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/PauseResumeIntegrationTest.java b/streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/PauseResumeIntegrationTest.java
@@ -48,7 +48,6 @@
 import org.junit.jupiter.params.provider.ValueSource;
 
 import java.time.Duration;
-import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.Collection;
 import java.util.List;
@@ -92,10 +91,6 @@ public class PauseResumeIntegrationTest {
         asList(pair("A", 1L), pair("B", 1L), pair("A", 2L), pair("C", 1L), pair("C", 2L));
     private static final List<KeyValue<String, Long>> COUNT_OUTPUT_DATA2 =
         asList(pair("A", 3L), pair("B", 2L), pair("A", 4L), pair("C", 3L), pair("C", 4L));
-    private static final List<KeyValue<String, Long>> COUNT_OUTPUT_DATA_ALL = new ArrayList<KeyValue<String, Long>>() {{
-            addAll(COUNT_OUTPUT_DATA);
-            addAll(COUNT_OUTPUT_DATA2);
-        }};
 
     private String appId;
     private KafkaStreams kafkaStreams, kafkaStreams2;
diff --git a/streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/RebalanceIntegrationTest.java b/streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/RebalanceIntegrationTest.java
@@ -41,8 +41,6 @@
 import org.junit.jupiter.api.Tag;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.Timeout;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
 
 import java.io.IOException;
 import java.time.Duration;
@@ -65,7 +63,6 @@
 @Tag("integration")
 @Timeout(600)
 public class RebalanceIntegrationTest {
-    private static final Logger LOG = LoggerFactory.getLogger(RebalanceIntegrationTest.class);
     private static final int NUM_BROKERS = 3;
     private static final int MAX_POLL_INTERVAL_MS = 30_000;
 
diff --git a/streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/DefaultTaskTopicPartition.java b/streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/DefaultTaskTopicPartition.java
@@ -19,9 +19,6 @@
 import org.apache.kafka.common.TopicPartition;
 import org.apache.kafka.streams.processor.assignment.TaskTopicPartition;
 
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-
 import java.util.Objects;
 import java.util.Optional;
 import java.util.Set;
@@ -36,7 +33,6 @@
  * the assignor that is currently making decisions.
  */
 public class DefaultTaskTopicPartition implements TaskTopicPartition {
-    private static final Logger LOG = LoggerFactory.getLogger(DefaultTaskTopicPartition.class);
 
     private final TopicPartition topicPartition;
     private final boolean isSourceTopic;
diff --git a/streams/src/test/java/org/apache/kafka/streams/kstream/internals/NamedInternalTest.java b/streams/src/test/java/org/apache/kafka/streams/kstream/internals/NamedInternalTest.java
@@ -23,7 +23,6 @@
 public class NamedInternalTest {
 
     private static final String TEST_PREFIX = "prefix-";
-    private static final String TEST_VALUE = "default-value";
     private static final String TEST_SUFFIX = "-suffix";
 
     private static class TestNameProvider implements InternalNameProvider {
diff --git a/streams/src/test/java/org/apache/kafka/streams/kstream/internals/WindowedStreamPartitionerTest.java b/streams/src/test/java/org/apache/kafka/streams/kstream/internals/WindowedStreamPartitionerTest.java
@@ -21,7 +21,6 @@
 import org.apache.kafka.common.Node;
 import org.apache.kafka.common.PartitionInfo;
 import org.apache.kafka.common.serialization.IntegerSerializer;
-import org.apache.kafka.common.serialization.StringSerializer;
 import org.apache.kafka.streams.kstream.TimeWindowedSerializer;
 import org.apache.kafka.streams.kstream.Windowed;
 
@@ -42,7 +41,6 @@ public class WindowedStreamPartitionerTest {
     private final String topicName = "topic";
 
     private final IntegerSerializer intSerializer = new IntegerSerializer();
-    private final StringSerializer stringSerializer = new StringSerializer();
 
     private final List<PartitionInfo> infos = Arrays.asList(
             new PartitionInfo(topicName, 0, Node.noNode(), new Node[0], new Node[0]),
diff --git a/tools/src/main/java/org/apache/kafka/tools/consumer/group/ShareGroupCommandOptions.java b/tools/src/main/java/org/apache/kafka/tools/consumer/group/ShareGroupCommandOptions.java
@@ -19,9 +19,6 @@
 import org.apache.kafka.server.util.CommandDefaultOptions;
 import org.apache.kafka.server.util.CommandLineUtils;
 
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-
 import java.util.List;
 import java.util.Set;
 import java.util.stream.Collectors;
@@ -31,7 +28,6 @@
 import static org.apache.kafka.tools.ToolsUtils.minus;
 
 public class ShareGroupCommandOptions extends CommandDefaultOptions {
-    private static final Logger LOGGER = LoggerFactory.getLogger(ShareGroupCommandOptions.class);
 
     private static final String BOOTSTRAP_SERVER_DOC = "REQUIRED: The server(s) to connect to.";
     private static final String GROUP_DOC = "The share group we wish to act on.";
diff --git a/tools/src/test/java/org/apache/kafka/tools/ProducerPerformanceTest.java b/tools/src/test/java/org/apache/kafka/tools/ProducerPerformanceTest.java
@@ -72,7 +72,7 @@ public class ProducerPerformanceTest {
     ProducerPerformance producerPerformanceSpy;
 
     private File createTempFile(String contents) throws IOException {
-        File file = File.createTempFile("ProducerPerformanceTest", ".tmp");
+        File file = Files.createTempFile("ProducerPerformanceTest", ".tmp").toFile();
         file.deleteOnExit();
         Files.write(file.toPath(), contents.getBytes());
         return file;
