Extract options into main function

Author: jim0987795064

jmh-benchmarks/src/main/java/org/apache/kafka/jmh/log/TestLinearWriteSpeed.java

@@ -63,19 +63,22 @@
 public class TestLinearWriteSpeed {
 
     public static void main(String[] args) throws Exception {
-        var option = createOptions(new OptionParser(), args);
-        long bytesToWrite = option.options.valueOf(option.bytesOpt);
-        int bufferSize = option.options.valueOf(option.sizeOpt);
-        int numFiles = option.options.valueOf(option.filesOpt);
-        long reportingInterval = option.options.valueOf(option.reportingIntervalOpt);
-        String dir = option.options.valueOf(option.dirOpt);
-        long maxThroughputBytes = option.options.valueOf(option.maxThroughputOpt) * 1024L * 1024L;
+        var parser = new OptionParser();
+        var option = createOptions(parser);
+        OptionSet options = parser.parse(args);
+        CommandLineUtils.checkRequiredArgs(parser, options, option.bytesOpt, option.sizeOpt);
+        long bytesToWrite = options.valueOf(option.bytesOpt);
+        int bufferSize = options.valueOf(option.sizeOpt);
+        int numFiles = options.valueOf(option.filesOpt);
+        long reportingInterval = options.valueOf(option.reportingIntervalOpt);
+        String dir = options.valueOf(option.dirOpt);
+        long maxThroughputBytes = options.valueOf(option.maxThroughputOpt) * 1024L * 1024L;
         ByteBuffer buffer = ByteBuffer.allocate(bufferSize);
-        int messageSize = option.options.valueOf(option.messageSizeOpt);
-        long flushInterval = option.options.valueOf(option.flushIntervalOpt);
-        CompressionType compressionType = CompressionType.forName(option.options.valueOf(option.compressionCodecOpt));
+        int messageSize = options.valueOf(option.messageSizeOpt);
+        long flushInterval = options.valueOf(option.flushIntervalOpt);
+        CompressionType compressionType = CompressionType.forName(options.valueOf(option.compressionCodecOpt));
         Compression.Builder<? extends Compression> compressionBuilder = Compression.of(compressionType);
-        Integer compressionLevel = option.options.valueOf(option.compressionLevelOpt);
+        Integer compressionLevel = options.valueOf(option.compressionLevelOpt);
 
         if (compressionLevel != null) setupCompression(compressionType, compressionBuilder, compressionLevel);
         Compression compression = compressionBuilder.build();
@@ -95,11 +98,11 @@ public static void main(String[] args) throws Exception {
         scheduler.startup();
 
         for (int i = 0; i < numFiles; i++) {
-            if (option.options.has(option.mmapOpt)) {
+            if (options.has(option.mmapOpt)) {
                 writables[i] = new MmapWritable(new File(dir, "kafka-test-" + i + ".dat"), bytesToWrite / numFiles, buffer);
-            } else if (option.options.has(option.channelOpt)) {
+            } else if (options.has(option.channelOpt)) {
                 writables[i] = new ChannelWritable(new File(dir, "kafka-test-" + i + ".dat"), buffer);
-            } else if (option.options.has(option.logOpt)) {
+            } else if (options.has(option.logOpt)) {
                 int segmentSize = ThreadLocalRandom.current().nextInt(512) * 1024 * 1024 + 64 * 1024 * 1024;
                 Properties logProperties = new Properties();
                 logProperties.put(TopicConfig.SEGMENT_BYTES_CONFIG, Integer.toString(segmentSize));
@@ -294,7 +297,6 @@ private static class Options {
         private final OptionSpec<Void> channelOpt;
         private final OptionSpec<Void> logOpt;
         private final OptionSpec<Void> mmapOpt;
-        private final OptionSet options;
 
         private Options(
             OptionSpec<String> dirOpt,
@@ -309,8 +311,7 @@ private Options(
             OptionSpec<Integer> compressionLevelOpt,
             OptionSpec<Void> channelOpt,
             OptionSpec<Void> logOpt,
-            OptionSpec<Void> mmapOpt,
-            OptionSet options
+            OptionSpec<Void> mmapOpt
         ) {
             this.dirOpt = dirOpt;
             this.bytesOpt = bytesOpt;
@@ -325,11 +326,10 @@ private Options(
             this.channelOpt = channelOpt;
             this.logOpt = logOpt;
             this.mmapOpt = mmapOpt;
-            this.options = options;
         }
     }
 
-    private static Options createOptions(OptionParser parser, String[] args) {
+    private static Options createOptions(OptionParser parser) {
         OptionSpec<String> dirOpt = parser.accepts("dir", "The directory to write to.")
             .withRequiredArg()
             .describedAs("path")
@@ -390,8 +390,6 @@ private static Options createOptions(OptionParser parser, String[] args) {
         OptionSpec<Void> channelOpt = parser.accepts("channel", "Do writes to file channels.");
         OptionSpec<Void> logOpt = parser.accepts("log", "Do writes to kafka logs.");
         OptionSpec<Void> mmapOpt = parser.accepts("mmap", "Do writes to mmap file.");
-        OptionSet options = parser.parse(args);
-        CommandLineUtils.checkRequiredArgs(parser, options, bytesOpt, sizeOpt);
 
         return new Options(
             dirOpt,
@@ -406,8 +404,7 @@ private static Options createOptions(OptionParser parser, String[] args) {
             compressionLevelOpt,
             channelOpt,
             logOpt,
-            mmapOpt,
-            options
+            mmapOpt
         );
     }
 }