MINOR: Move ReconfigurableQuorumIntegrationTest from core module to server module #20636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
…ableQuorumIntegrationTest
chia7712
approved these changes
Oct 5, 2025
chia7712
reviewed
Oct 5, 2025
| package org.apache.kafka.server; | ||
|
|
||
| import org.apache.kafka.clients.admin.Admin; | ||
| import org.apache.kafka.clients.admin.FeatureMetadata; |
There was a problem hiding this comment.
@jim0987795064 Could you merge org.apache.kafka.clients.admin.ReconfigurableQuorumIntegrationTest into this one? Also, please add @Tag("integration")
There was a problem hiding this comment.
Sure.Update it
…est into this test and add @tag(integration)
added 2 commits
October 6, 2025 19:03
…ableQuorumIntegrationTest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It moves the
ReconfigurableQuorumIntegrationTestclass to theorg.apache.kafka.serverpackage and consolidates two related tests,RemoveAndAddVoterWithValidClusterIdandRemoveAndAddVoterWithInconsistentClusterId, into a single file. Thisimproves code organization and reduces redundancy.
Reviewers: Chia-Ping Tsai [email protected]