KAFKA-18509 Move StateChangeLogger to server-common module #20637
+62
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chia7712
reviewed
Oct 6, 2025
| import org.slf4j.LoggerFactory; | ||
|
|
||
| public class StateChangeLogger { | ||
| private static final Logger log = LoggerFactory.getLogger("state.change.logger"); |
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
|
|
||
| public class StateChangeLogger { |
There was a problem hiding this comment.
Could you please add comments explaining the purpose of this class?
chia7712
approved these changes
Oct 6, 2025
There was a problem hiding this comment.
LGTM, test this patch locally, and it works well
astraea@4d06546d9896:/opt/kafka$ cat logs/state-change.log
[2025-10-06 14:49:48,720] INFO [Broker id=10686] Transitioning 1 partition(s) to local leaders. (state.change.logger)
[2025-10-06 14:49:48,722] INFO [Broker id=10686] Creating new partition chia-0 with topic id SSROqblKQnylcx-1TgPrPA. (state.change.logger)
[2025-10-06 14:49:48,735] INFO [Broker id=10686] Leader chia-0 with topic id Some(SSROqblKQnylcx-1TgPrPA) starts at leader epoch 0 from offset 0 with partition epoch 0, high watermark 0, ISR [10686], adding replicas [] and removing replicas [] . Previous leader None and previous leader epoch was -1. (state.change.logger)
[2025-10-06 14:49:48,891] INFO [Broker id=10686] Transitioning 1 partition(s) to local leaders. (state.change.logger)
[2025-10-06 14:49:48,900] INFO [Broker id=10686] Skipped the become-leader state change for chia-0 with topic id Some(SSROqblKQnylcx-1TgPrPA), partition registration PartitionRegistration(replicas=[10686], directories=[_Q5ubnelBuH_WhzwMDjmjA], isr=[10686], removingReplicas=[], addingReplicas=[], elr=[], lastKnownElr=[], leader=10686, leaderRecoveryState=RECOVERED, leaderEpoch=0, partitionEpoch=1) and isNew=false since it is already the leader with leader epoch 0. Current high watermark 0, ISR [10686], adding replicas [] and removing replicas []. (state.change.logger)
|
the failed test is handled by #20620 |
omkreddy
reviewed
Oct 8, 2025
| } | ||
|
|
||
| public void trace(String message) { | ||
| LOGGER.info("{}{}", logIdent, message); |
There was a problem hiding this comment.
@m1a2st This should be LOGGER.trace
There was a problem hiding this comment.
Sorry about the bad code review. We will submit a patch for it ASAP
There was a problem hiding this comment.
Thanks for the review and for pointing it out!
chia7712
pushed a commit
that referenced
this pull request
Oct 9, 2025
from: #20637 (comment) Previously, the method used LOGGER.info() instead of LOGGER.trace(). This patch corrects the logging level used in the trace method of StateChangeLogger. Reviewers: Manikumar Reddy <[email protected]>, TengYao Chi <[email protected]>, Ken Huang <[email protected]>, Chia-Ping Tsai <[email protected]> Co-authored-by: Ubuntu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can rewrite this class from scala to java and move to server-common
module. To maintain backward compatibility, we should keep the logger
name
state.change.logger.Reviewers: Chia-Ping Tsai [email protected]