MINOR: update method name from createGroupTombstoneRecords to createGroupTombStoneRecordsAndCancelTimers
#20949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
dajac
reviewed
Nov 21, 2025
| List<CoordinatorRecord> records | ||
| ) { | ||
| group.createGroupTombstoneRecords(records); | ||
| timer.cancel(streamsInitialRebalanceKey(group.groupId())); |
Member
There was a problem hiding this comment.
It is actually a bit weird to have this here. createGroupTombstoneRecords applies to all group types but the timer is only for streams. What's the reasoning?
Member
There was a problem hiding this comment.
It won't have an effect for other group types. But we could move this into Group implementation, but then we should probably also rename this method.
Contributor
Author
chia7712
reviewed
Nov 25, 2025
|
|
||
| @Override | ||
| public void cancelTimers(CoordinatorTimer<Void, CoordinatorRecord> timer) { | ||
| timer.cancel("initial-rebalance-timeout-" + groupId); |
Member
There was a problem hiding this comment.
To keep the code consistent, we could add a static helper to StreamGroup and use it to implement GroupMetadataManager.streamsInitialRebalanceKey
| Group group = groups.get(groupId); | ||
| if (group != null && group.isEmpty()) { | ||
| createGroupTombstoneRecords(groupId, records); | ||
| createGroupTombstoneRecordsAndCancelTimers(groupId, records); |
Member
There was a problem hiding this comment.
Could we pass group instead of groupId?
Contributor
Author
There was a problem hiding this comment.
Yeah that's a good point, fixed, thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since now we are canceling timers in the method, we need to update the method name