Renames newInstance to getInstance

Author: ppkarwasz

log4j-converter-config/src/main/java/org/apache/logging/converter/config/ConfigurationConverter.java

@@ -30,8 +30,8 @@ public interface ConfigurationConverter {
      * A default implementation of {@link ConfigurationConverter} that uses {@link java.util.ServiceLoader} to load additional formats.
      * @see org.apache.logging.converter.config.spi.ConfigurationMapper
      */
-    static ConfigurationConverter newInstance() {
-        return new DefaultConfigurationConverter();
+    static ConfigurationConverter getInstance() {
+        return DefaultConfigurationConverter.INSTANCE;
     }
 
     /**

log4j-converter-config/src/main/java/org/apache/logging/converter/config/internal/DefaultConfigurationConverter.java

@@ -48,12 +48,14 @@
         value = ConfigurationMapper.class,
         cardinality = Cardinality.MULTIPLE,
         resolution = Resolution.OPTIONAL)
-public class DefaultConfigurationConverter implements ConfigurationConverter {
+public final class DefaultConfigurationConverter implements ConfigurationConverter {
+
+    public static final ConfigurationConverter INSTANCE = new DefaultConfigurationConverter();
 
     private final Map<String, ConfigurationParser> parsers = new HashMap<>();
     private final Map<String, ConfigurationWriter> writers = new HashMap<>();
 
-    public DefaultConfigurationConverter() {
+    private DefaultConfigurationConverter() {
         ServiceLoader.load(ConfigurationParser.class).forEach(parser -> parsers.put(parser.getInputFormat(), parser));
         ServiceLoader.load(ConfigurationWriter.class).forEach(writer -> writers.put(writer.getOutputFormat(), writer));
         ServiceLoader.load(ConfigurationMapper.class).forEach(mapper -> {

log4j-converter-config/src/test/java/org/apache/logging/converter/config/ConfigurationConverterTest.java

@@ -40,7 +40,7 @@ class ConfigurationConverterTest {
 
     private static final String DEFAULT_FORMAT = "v2:xml";
 
-    private final ConfigurationConverter converter = ConfigurationConverter.newInstance();
+    private final ConfigurationConverter converter = ConfigurationConverter.getInstance();
     private final ConfigurationParser parser = new XmlConfigurationMapper();
 
     public static Stream<Arguments> conversionToXml() {