fix toString() method in configuration implementations (#3599)

Author: anindita-sarkarArray

log4j-core/src/main/java/org/apache/logging/log4j/core/config/AbstractConfiguration.java

@@ -22,6 +22,7 @@
 import java.io.InputStream;
 import java.lang.ref.WeakReference;
 import java.net.URI;
+import java.time.Instant;
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.Collection;
@@ -1187,6 +1188,12 @@ private Object createPluginObject(final PluginType<?> type, final Node node, fin
         return map;
     }
 
+    @Override
+    public String toString() {
+        return getClass().getSimpleName() + "[location=" + getConfigurationSource() + ", lastModified="
+                + Instant.ofEpochMilli(getConfigurationSource().getLastModified()) + "]";
+    }
+
     private static Collection<?> createPluginCollection(final Node node) {
         final List<Node> children = node.getChildren();
         final Collection<Object> list = new ArrayList<>(children.size());

log4j-core/src/main/java/org/apache/logging/log4j/core/config/composite/CompositeConfiguration.java

@@ -183,13 +183,4 @@ private void printNodes(final String indent, final Node node, final StringBuilde
             printNodes(indent + "  ", child, sb);
         }
     }
-
-    @Override
-    public String toString() {
-        return getClass().getName() + "@" + Integer.toHexString(hashCode()) + " [configurations=" + configurations
-                + ", mergeStrategy=" + mergeStrategy + ", rootNode=" + rootNode + ", listeners=" + listeners
-                + ", pluginPackages=" + pluginPackages + ", pluginManager=" + pluginManager + ", isShutdownHookEnabled="
-                + isShutdownHookEnabled + ", shutdownTimeoutMillis=" + shutdownTimeoutMillis + ", scriptManager="
-                + scriptManager + "]";
-    }
 }

log4j-core/src/main/java/org/apache/logging/log4j/core/config/json/JsonConfiguration.java

@@ -236,11 +236,6 @@ private void processAttributes(final Node parent, final JsonNode node) {
         }
     }
 
-    @Override
-    public String toString() {
-        return getClass().getSimpleName() + "[location=" + getConfigurationSource() + "]";
-    }
-
     /**
      * The error that occurred.
      */
@@ -261,10 +256,5 @@ public Status(final String name, final JsonNode node, final ErrorType errorType)
             this.node = node;
             this.errorType = errorType;
         }
-
-        @Override
-        public String toString() {
-            return "Status [name=" + name + ", errorType=" + errorType + ", node=" + node + "]";
-        }
     }
 }

log4j-core/src/main/java/org/apache/logging/log4j/core/config/xml/XmlConfiguration.java

@@ -20,7 +20,6 @@
 import java.io.ByteArrayInputStream;
 import java.io.IOException;
 import java.io.InputStream;
-import java.time.Instant;
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.List;
@@ -336,12 +335,6 @@ private Map<String, String> processAttributes(final Node node, final Element ele
         return attributes;
     }
 
-    @Override
-    public String toString() {
-        return getClass().getSimpleName() + "[location=" + getConfigurationSource() + ", lastModified="
-                + Instant.ofEpochMilli(getConfigurationSource().getLastModified()) + "]";
-    }
-
     /**
      * The error that occurred.
      */
@@ -362,10 +355,5 @@ public Status(final String name, final Element element, final ErrorType errorTyp
             this.element = element;
             this.errorType = errorType;
         }
-
-        @Override
-        public String toString() {
-            return "Status [name=" + name + ", element=" + element + ", errorType=" + errorType + "]";
-        }
     }
 }