Fix: Ensure jvmrunargs lookup is always registered (fixes #2726)

Author: ramanathan1504

log4j-core-test/src/test/java/org/apache/logging/log4j/core/lookup/JvmRunArgsIntegrationTest.java

@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to you under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.logging.log4j.core.lookup;
+
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
+import org.junit.Test;
+
+public class JvmRunArgsIntegrationTest {
+    @Test
+    public void testJvmRunArgsInConfig() {
+        Logger logger = LogManager.getLogger(JvmRunArgsIntegrationTest.class);
+        logger.info("Testing JVM Args lookup in config");
+    }
+}

log4j-core-test/src/test/java/org/apache/logging/log4j/core/lookup/JvmRunArgsLookupTest.java

@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to you under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.logging.log4j.core.lookup;
+
+import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertNull;
+
+import org.apache.logging.log4j.core.LogEvent;
+import org.junit.Test;
+
+public class JvmRunArgsLookupTest {
+
+    @Test
+    public void testJvmRunArgsLookupIsRegistered() {
+        Interpolator interpolator = new Interpolator();
+        StrLookup lookup = interpolator.getStrLookupMap().get("jvmrunargs");
+        assertNotNull("jvmrunargs lookup should be registered", lookup);
+    }
+
+    @Test
+    public void testJvmRunArgsLookupReturnsArgs() {
+        Interpolator interpolator = new Interpolator();
+        StrLookup lookup = interpolator.getStrLookupMap().get("jvmrunargs");
+        // This will depend on the JVM args, but should not be null (may be empty)
+        String anyArg = lookup.lookup((LogEvent) null, "-Xmx");
+        // Accept null or a value, but the lookup should not throw
+        // Most likely null unless -Xmx is set
+        assertNull(anyArg);
+    }
+}

log4j-core-test/src/test/resources/log4j2-test.xml

@@ -0,0 +1,29 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+  ~ Licensed to the Apache Software Foundation (ASF) under one or more
+  ~ contributor license agreements.  See the NOTICE file distributed with
+  ~ this work for additional information regarding copyright ownership.
+  ~ The ASF licenses this file to you under the Apache License, Version 2.0
+  ~ (the "License"); you may not use this file except in compliance with
+  ~ the License.  You may obtain a copy of the License at
+  ~
+  ~      http://www.apache.org/licenses/LICENSE-2.0
+  ~
+  ~ Unless required by applicable law or agreed to in writing, software
+  ~ distributed under the License is distributed on an "AS IS" BASIS,
+  ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  ~ See the License for the specific language governing permissions and
+  ~ limitations under the License.
+  -->
+<Configuration status="WARN">
+  <Appenders>
+    <Console name="Console" target="SYSTEM_OUT">
+      <PatternLayout pattern="JVM Args: ${jvmrunargs:-Xmx}%n" />
+    </Console>
+  </Appenders>
+  <Loggers>
+    <Root level="info">
+      <AppenderRef ref="Console"/>
+    </Root>
+  </Loggers>
+</Configuration>

log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/Interpolator.java

@@ -93,6 +93,14 @@ public Interpolator(final StrLookup defaultLookup, final List<String> pluginPack
                 handleError(entry.getKey(), t);
             }
         }
+
+        if (!strLookupMap.containsKey(LOOKUP_KEY_JVMRUNARGS)) {
+            try {
+                strLookupMap.put(LOOKUP_KEY_JVMRUNARGS, new JmxRuntimeInputArgumentsLookup());
+            } catch (Throwable t) {
+                handleError(LOOKUP_KEY_JVMRUNARGS, t);
+            }
+        }
     }
 
     /**