Skip to content

Commit 2fea365

Browse files
committed
Apply review feedback
1 parent 14aaac3 commit 2fea365

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

log4j-core-test/src/test/java/org/apache/logging/log4j/core/MonitorResourcesTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
import org.apache.logging.log4j.core.config.builder.api.ComponentBuilder;
3535
import org.apache.logging.log4j.core.config.builder.api.ConfigurationBuilder;
3636
import org.apache.logging.log4j.core.config.builder.api.ConfigurationBuilderFactory;
37-
import org.apache.logging.log4j.core.config.properties.PropertiesConfiguration;
37+
import org.apache.logging.log4j.core.config.builder.impl.BuiltConfiguration;
3838
import org.apache.logging.log4j.core.test.junit.LoggerContextSource;
3939
import org.apache.logging.log4j.core.util.Source;
4040
import org.junit.jupiter.api.Test;
@@ -45,8 +45,8 @@ public class MonitorResourcesTest {
4545

4646
@Test
4747
void test_reconfiguration(@TempDir(cleanup = CleanupMode.ON_SUCCESS) final Path tempDir) throws IOException {
48-
final ConfigurationBuilder<PropertiesConfiguration> configBuilder =
49-
ConfigurationBuilderFactory.newConfigurationBuilder(PropertiesConfiguration.class);
48+
final ConfigurationBuilder<BuiltConfiguration> configBuilder =
49+
ConfigurationBuilderFactory.newConfigurationBuilder();
5050
final Path configFile = tempDir.resolve("log4j.xml");
5151
final Path externalResourceFile1 = tempDir.resolve("external-resource-1.txt");
5252
final Path externalResourceFile2 = tempDir.resolve("external-resource-2.txt");

log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/api/ConfigurationBuilder.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@ public interface ConfigurationBuilder<T extends Configuration> extends Builder<T
6565
* Adds a top level component.
6666
* @param builder The ComponentBuilder with all of its attributes and sub components set.
6767
* @return this builder instance.
68+
* @since 2.25.0
6869
*/
6970
default ConfigurationBuilder<T> addComponent(ComponentBuilder<?> builder) {
7071
throw new UnsupportedOperationException();

0 commit comments

Comments
 (0)