Skip to content

Commit 5bc9762

Browse files
committed
Replaced DefaultComponentBuilder#put with DefaultComponentBuilder#putAttributte (#2791)
+ more appropriate method name
1 parent 406b097 commit 5bc9762

File tree

1 file changed

+8
-7
lines changed

1 file changed

+8
-7
lines changed

log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultComponentBuilder.java

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -91,37 +91,38 @@ public DefaultComponentBuilder(
9191
/** {@inheritDoc} */
9292
@Override
9393
public @NonNull T addAttribute(final @NonNull String key, final boolean value) {
94-
return put(key, Boolean.toString(value));
94+
return putAttribute(key, Boolean.toString(value));
9595
}
9696

9797
/** {@inheritDoc} */
9898
@Override
9999
public @NonNull T addAttribute(final @NonNull String key, final int value) {
100-
return put(key, Integer.toString(value));
100+
return putAttribute(key, Integer.toString(value));
101101
}
102102

103103
/** {@inheritDoc} */
104104
@Override
105105
public @NonNull T addAttribute(final @NonNull String key, final @Nullable Enum<?> value) {
106-
return put(key, Optional.ofNullable(value).map(Enum::name).orElse(null));
106+
return putAttribute(key, Optional.ofNullable(value).map(Enum::name).orElse(null));
107107
}
108108

109109
/** {@inheritDoc} */
110110
@Override
111111
public @NonNull T addAttribute(final @NonNull String key, final @Nullable Level level) {
112-
return put(key, Optional.ofNullable(level).map(Level::toString).orElse(null));
112+
return putAttribute(key, Optional.ofNullable(level).map(Level::toString).orElse(null));
113113
}
114114

115115
/** {@inheritDoc} */
116116
@Override
117117
public @NonNull T addAttribute(final @NonNull String key, final @Nullable Object value) {
118-
return put(key, Optional.ofNullable(value).map(Object::toString).orElse(null));
118+
return putAttribute(
119+
key, Optional.ofNullable(value).map(Object::toString).orElse(null));
119120
}
120121

121122
/** {@inheritDoc} */
122123
@Override
123124
public @NonNull T addAttribute(final @NonNull String key, final @Nullable String value) {
124-
return put(key, value);
125+
return putAttribute(key, value);
125126
}
126127

127128
/**
@@ -188,7 +189,7 @@ public DefaultComponentBuilder(
188189
* @return this builder (for chaining)
189190
* @throws NullPointerException if the given {@code key} argument is {@code null}
190191
*/
191-
private @NonNull T put(final @NonNull String key, final @Nullable String value) {
192+
private @NonNull T putAttribute(final @NonNull String key, final @Nullable String value) {
192193

193194
Objects.requireNonNull(key, "The 'key' argument must not be null.");
194195

0 commit comments

Comments
 (0)