Cleanup AsyncWaitStrategyFactoryConfigTest new tests + add one

Author: jethomas-tsi

log4j-core-test/src/test/java/org/apache/logging/log4j/core/async/AsyncWaitStrategyFactoryConfigTest.java

@@ -39,11 +39,11 @@ public class AsyncWaitStrategyFactoryConfigTest {
     @LoggerContextSource("AsyncWaitStrategyFactoryConfigTest.xml")
     public void testConfigWaitStrategyFactory(final LoggerContext context) throws Exception {
         final AsyncWaitStrategyFactory asyncWaitStrategyFactory =
-                context.getConfiguration().getAsyncWaitStrategyFactory();
+            context.getConfiguration().getAsyncWaitStrategyFactory();
         assertEquals(YieldingWaitStrategyFactory.class, asyncWaitStrategyFactory.getClass());
         assertThat(
-                "factory is YieldingWaitStrategyFactory",
-                asyncWaitStrategyFactory instanceof YieldingWaitStrategyFactory);
+            "factory is YieldingWaitStrategyFactory",
+            asyncWaitStrategyFactory instanceof YieldingWaitStrategyFactory);
     }
 
     @Test
@@ -53,20 +53,20 @@ public void testWaitStrategy(final LoggerContext context) throws Exception {
         final org.apache.logging.log4j.Logger logger = context.getRootLogger();
 
         final AsyncLoggerConfig loggerConfig =
-                (AsyncLoggerConfig) ((org.apache.logging.log4j.core.Logger) logger).get();
+            (AsyncLoggerConfig) ((org.apache.logging.log4j.core.Logger) logger).get();
         final AsyncLoggerConfigDisruptor delegate =
-                (AsyncLoggerConfigDisruptor) loggerConfig.getAsyncLoggerConfigDelegate();
+            (AsyncLoggerConfigDisruptor) loggerConfig.getAsyncLoggerConfigDelegate();
         assertEquals(YieldingWaitStrategy.class, delegate.getWaitStrategy().getClass());
         assertThat(
-                "waitstrategy is YieldingWaitStrategy",
-                delegate.getWaitStrategy() instanceof com.lmax.disruptor.YieldingWaitStrategy);
+            "waitstrategy is YieldingWaitStrategy",
+            delegate.getWaitStrategy() instanceof com.lmax.disruptor.YieldingWaitStrategy);
     }
 
     @Test
     @LoggerContextSource("AsyncWaitStrategyIncorrectFactoryConfigTest.xml")
     public void testIncorrectConfigWaitStrategyFactory(final LoggerContext context) throws Exception {
         final AsyncWaitStrategyFactory asyncWaitStrategyFactory =
-                context.getConfiguration().getAsyncWaitStrategyFactory();
+            context.getConfiguration().getAsyncWaitStrategyFactory();
         assertNull(asyncWaitStrategyFactory);
     }
 
@@ -81,41 +81,50 @@ void testInvalidBuilderConfiguration3159(final Configuration configuration) {
         assertNull(configuration.getAsyncWaitStrategyFactory(), "The AsyncWaitStrategyFactory should be null.");
     }
 
+    /**
+     * Test that when programmatically building a {@link AsyncWaitStrategyFactoryConfig} not setting a valid
+     * factory class-name throws an exception.
+     */
+    @Test
+    void testInvalidProgrammaticConfiguration3159WithFactoryClassNameNotSet() {
+        Assertions.assertNull(AsyncWaitStrategyFactoryConfig.newBuilder().build());
+    }
+
     /**
      * Test that when programmatically building a {@link AsyncWaitStrategyFactoryConfig} a {@code null}
      * factory class-name throws an exception.
      */
     @Test
-    void testInvalidProgrammaticConfiguration3159WithNullFactoryClassName() {
+    void testInvalidProgrammaticConfiguration3159WithFactoryClassNameNull() {
         Assertions.assertThrows(IllegalArgumentException.class, () -> AsyncWaitStrategyFactoryConfig.newBuilder()
-                .withFactoryClassName(null));
+                                                                                                    .withFactoryClassName(null));
     }
 
     /**
      * Test that when programmatically building a {@link AsyncWaitStrategyFactoryConfig} a blank ({@code ""})
      * factory class-name throws an exception.
      */
     @Test
-    void testInvalidProgrammaticConfiguration3159WithEmptyFactoryClassName() {
+    void testInvalidProgrammaticConfiguration3159WithFactoryClassNameEmpty() {
         Assertions.assertThrows(IllegalArgumentException.class, () -> AsyncWaitStrategyFactoryConfig.newBuilder()
-                .withFactoryClassName(""));
+                                                                                                    .withFactoryClassName(""));
     }
 
     @Test
     @LoggerContextSource("AsyncWaitStrategyIncorrectFactoryConfigTest.xml")
     public void testIncorrectWaitStrategyFallsBackToDefault(
-            @Named("WaitStrategyAppenderList") final ListAppender list1, final LoggerContext context) throws Exception {
+        @Named("WaitStrategyAppenderList") final ListAppender list1, final LoggerContext context) throws Exception {
         final org.apache.logging.log4j.Logger logger = context.getRootLogger();
 
         final AsyncLoggerConfig loggerConfig =
-                (AsyncLoggerConfig) ((org.apache.logging.log4j.core.Logger) logger).get();
+            (AsyncLoggerConfig) ((org.apache.logging.log4j.core.Logger) logger).get();
         final AsyncLoggerConfigDisruptor delegate =
-                (AsyncLoggerConfigDisruptor) loggerConfig.getAsyncLoggerConfigDelegate();
+            (AsyncLoggerConfigDisruptor) loggerConfig.getAsyncLoggerConfigDelegate();
         assertEquals(
-                TimeoutBlockingWaitStrategy.class, delegate.getWaitStrategy().getClass());
+            TimeoutBlockingWaitStrategy.class, delegate.getWaitStrategy().getClass());
         assertThat(
-                "waitstrategy is TimeoutBlockingWaitStrategy",
-                delegate.getWaitStrategy() instanceof TimeoutBlockingWaitStrategy);
+            "waitstrategy is TimeoutBlockingWaitStrategy",
+            delegate.getWaitStrategy() instanceof TimeoutBlockingWaitStrategy);
     }
 
     public static class YieldingWaitStrategyFactory implements AsyncWaitStrategyFactory {