Skip to content

Commit 6e66551

Browse files
committed
Simplify configuration after BND 7.x upgrade
BND 7.x supports multi-release JARs, so we can remove many manual overrides of module names. We also **add** an override from `disruptor` to `com.conversantmedia.disruptor`, since new (Java 11 based) versions of `com.conversantmetida:disruptor` have a JPMS descriptor.
1 parent 9565d4b commit 6e66551

File tree

11 files changed

+31
-45
lines changed

11 files changed

+31
-45
lines changed

log4j-api/pom.xml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,10 +36,6 @@
3636
<bnd-multi-release>true</bnd-multi-release>
3737
<!-- Differs from OSGi bundle name -->
3838
<bnd-module-name>org.apache.logging.log4j</bnd-module-name>
39-
<bnd-extra-package-options>
40-
<!-- This is a Java 9 only package, so BND can not detect it as private -->
41-
!org.apache.logging.log4j.util.internal
42-
</bnd-extra-package-options>
4339
<bnd-extra-module-options>
4440
<!-- Used in StringBuilders through reflection -->
4541
java.sql;static=true,

log4j-core-test/pom.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@
5353
org.hamcrest;transitive=false,
5454
org.junit.jupiter.api;transitive=false,
5555
<!-- Name changes -->
56-
org.assertj.core;substitute="assertj-core",
5756
java.allocation.instrumenter;substitute="java-allocation-instrumenter",
5857
spring.test;substitute="spring-test"
5958
</bnd-extra-module-options>

log4j-core/pom.xml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -66,10 +66,10 @@
6666
<!-- Remove `transitive` from optional dependencies -->
6767
com.fasterxml.jackson.annotation;transitive=false,
6868
com.lmax.disruptor;transitive=false,
69-
com.fasterxml.jackson.core;substitute="jackson-core";transitive=false,
70-
com.fasterxml.jackson.databind;substitute="jackson-databind";transitive=false,
71-
com.fasterxml.jackson.dataformat.xml;substitute="jackson-dataformat-xml";transitive=false,
72-
com.fasterxml.jackson.dataformat.yaml;substitute="jackson-dataformat-yaml";transitive=false,
69+
com.fasterxml.jackson.core;transitive=false,
70+
com.fasterxml.jackson.databind;transitive=false,
71+
com.fasterxml.jackson.dataformat.xml;transitive=false,
72+
com.fasterxml.jackson.dataformat.yaml;transitive=false,
7373
java.naming;transitive=false,
7474
org.apache.commons.csv;transitive=false,
7575
org.fusesource.jansi;transitive=false,

log4j-docker/pom.xml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -32,11 +32,6 @@
3232
<!--
3333
~ OSGi and JPMS options
3434
-->
35-
<bnd-extra-module-options>
36-
<!-- Non detected module names -->
37-
com.fasterxml.jackson.core;substitute="jackson-core",
38-
com.fasterxml.jackson.databind;substitute="jackson-databind"
39-
</bnd-extra-module-options>
4035
<Fragment-Host>org.apache.logging.log4j.core</Fragment-Host>
4136
</properties>
4237
<dependencies>

log4j-jcl/pom.xml

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,12 +27,7 @@
2727
<packaging>jar</packaging>
2828
<name>Apache Log4j Commons Logging Bridge</name>
2929
<description>The Apache Log4j Commons Logging Adapter</description>
30-
<properties>
31-
<bnd-extra-module-options>
32-
<!-- Filebase module names: MUST be static -->
33-
commons.logging;substitute="commons-logging";transitive=false;static=true
34-
</bnd-extra-module-options>
35-
</properties>
30+
3631
<dependencies>
3732
<dependency>
3833
<groupId>org.apache.logging.log4j</groupId>

log4j-jdbc-dbcp2/pom.xml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,10 +33,6 @@
3333
~ OSGi and JPMS options
3434
-->
3535
<bnd-module-name>org.apache.logging.log4j.core.appender.db.jdbc</bnd-module-name>
36-
<bnd-extra-module-options>
37-
<!-- Module names -->
38-
org.apache.commons.dbcp2;substitute="commons-dbcp2"
39-
</bnd-extra-module-options>
4036
<Fragment-Host>org.apache.logging.log4j.core</Fragment-Host>
4137
</properties>
4238

log4j-jpa/pom.xml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -32,11 +32,6 @@
3232
<!--
3333
~ OSGi and JPMS options
3434
-->
35-
<bnd-extra-module-options>
36-
<!-- Non detected module names -->
37-
com.fasterxml.jackson.core;substitute="jackson-core",
38-
com.fasterxml.jackson.databind;substitute="jackson-databind"
39-
</bnd-extra-module-options>
4035
<Fragment-Host>org.apache.logging.log4j.core</Fragment-Host>
4136
</properties>
4237

log4j-slf4j2-impl/pom.xml

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -28,17 +28,7 @@
2828
<packaging>jar</packaging>
2929
<name>Apache Log4j SLF4J 2.0 Binding</name>
3030
<description>The Apache Log4j SLF4J 2.0 API binding to Log4j 2 Core</description>
31-
<properties>
3231

33-
<!--
34-
~ OSGi and JPMS options
35-
-->
36-
<bnd-extra-module-options>
37-
<!-- The module descriptor is in `META-INF/versions/9`
38-
BND can not find it -->
39-
org.slf4j;substitute="slf4j-api"
40-
</bnd-extra-module-options>
41-
</properties>
4232
<dependencies>
4333
<dependency>
4434
<groupId>org.osgi</groupId>

log4j-to-slf4j/pom.xml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -37,11 +37,6 @@
3737
<!-- This bridge also support SLF4J 2.x -->
3838
org.slf4j.*;version="${slf4j.support.range}"
3939
</bnd-extra-package-options>
40-
<bnd-extra-module-options>
41-
<!-- The module descriptor is in `META-INF/versions/9`
42-
BND 6.x can not find it -->
43-
org.slf4j;substitute="slf4j-api"
44-
</bnd-extra-module-options>
4540
</properties>
4641
<dependencies>
4742
<dependency>

log4j-web/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
-->
3737
<bnd-extra-module-options>
3838
<!-- Filebased module names: MUST be static -->
39-
javax.servlet.api;substitute="javax.servlet-api";transitive=true;static=true
39+
javax.servlet.api;substitute="javax.servlet-api";transitive=false;static=true
4040
</bnd-extra-module-options>
4141
<Fragment-Host>org.apache.logging.log4j.core</Fragment-Host>
4242
</properties>

0 commit comments

Comments
 (0)