Skip to content

Commit 6fdab69

Browse files
committed
Improvements on the logger message factory namespacing (#2961)
1 parent 2062676 commit 6fdab69

File tree

5 files changed

+7
-6
lines changed

5 files changed

+7
-6
lines changed

log4j-api/src/main/java/org/apache/logging/log4j/simple/SimpleLoggerContext.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ public Object getExternalContext() {
9595

9696
@Override
9797
public ExtendedLogger getLogger(final String name) {
98-
return getLogger(name, null);
98+
return getLogger(name, DEFAULT_MESSAGE_FACTORY);
9999
}
100100

101101
@Override

log4j-api/src/main/java/org/apache/logging/log4j/spi/LoggerRegistry.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -240,7 +240,8 @@ public boolean hasLogger(final String name, final Class<? extends MessageFactory
240240
}
241241

242242
/**
243-
* Registers the provided logger using the given name – <b>message factory parameter is ignored</b> and the one from the logger will be used instead.
243+
* Registers the provided logger.
244+
* <b>Logger name and message factory parameters are ignored</b>, those will be obtained from the logger instead.
244245
*
245246
* @param name ignored – kept for backward compatibility
246247
* @param messageFactory ignored – kept for backward compatibility

log4j-taglib/src/main/java/org/apache/logging/log4j/taglib/Log4jTaglibLoggerContext.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ public Object getExternalContext() {
6363

6464
@Override
6565
public Log4jTaglibLogger getLogger(final String name) {
66-
return getLogger(name, null);
66+
return getLogger(name, DEFAULT_MESSAGE_FACTORY);
6767
}
6868

6969
@Override
@@ -87,7 +87,7 @@ private Log4jTaglibLogger createLogger(final String name, final MessageFactory m
8787

8888
@Override
8989
public boolean hasLogger(final String name) {
90-
return loggerRegistry.hasLogger(name);
90+
return loggerRegistry.hasLogger(name, DEFAULT_MESSAGE_FACTORY);
9191
}
9292

9393
@Override

log4j-to-jul/src/main/java/org/apache/logging/log4j/tojul/JULLoggerContext.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ public Object getExternalContext() {
4444

4545
@Override
4646
public ExtendedLogger getLogger(final String name) {
47-
return getLogger(name, null);
47+
return getLogger(name, DEFAULT_MESSAGE_FACTORY);
4848
}
4949

5050
@Override

log4j-to-slf4j/src/main/java/org/apache/logging/slf4j/SLF4JLoggerContext.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ public Object getExternalContext() {
3737

3838
@Override
3939
public ExtendedLogger getLogger(final String name) {
40-
return getLogger(name, null);
40+
return getLogger(name, DEFAULT_MESSAGE_FACTORY);
4141
}
4242

4343
@Override

0 commit comments

Comments
 (0)