Add warnings for other mutator methods

Author: ppkarwasz

log4j-jul/src/main/java/org/apache/logging/log4j/jul/ApiLogger.java

@@ -16,7 +16,9 @@
  */
 package org.apache.logging.log4j.jul;
 
+import java.util.ResourceBundle;
 import java.util.logging.Filter;
+import java.util.logging.Handler;
 import java.util.logging.Level;
 import java.util.logging.LogRecord;
 import java.util.logging.Logger;
@@ -41,6 +43,12 @@
  */
 public class ApiLogger extends Logger {
 
+    private static final org.apache.logging.log4j.Logger LOGGER = StatusLogger.getLogger();
+    private static final String MUTATOR_DISABLED =
+            "Ignoring call to `j.ul.Logger.{}({})`, since the Log4j API does not provide methods to modify the underlying implementation.\n"
+                    + "To modify the configuration using JUL, use an `AbstractLoggerAdapter` appropriate for your logging implementation.\n"
+                    + "See https://logging.apache.org/log4j/3.x/log4j-jul.html#log4j.jul.loggerAdapter for more information.";
+
     private final WrappedLogger logger;
     private static final String FQCN = ApiLogger.class.getName();
 
@@ -94,10 +102,7 @@ public Level getLevel() {
 
     @Override
     public void setLevel(final Level newLevel) throws SecurityException {
-        StatusLogger.getLogger()
-                .error(
-                        "Cannot set JUL log level through log4j-api: " + "ignoring call to Logger.setLevel({})",
-                        newLevel);
+        LOGGER.warn(MUTATOR_DISABLED, "setLevel", newLevel);
         // Some libraries rely on the following assertion:
         //
         // logger.setLevel(level);
@@ -118,6 +123,32 @@ protected void doSetLevel(final Level newLevel) throws SecurityException {
         super.setLevel(newLevel);
     }
 
+    @Override
+    public void setUseParentHandlers(boolean useParentHandlers) {
+        LOGGER.warn(MUTATOR_DISABLED, "setLevel", useParentHandlers);
+        super.setUseParentHandlers(useParentHandlers);
+    }
+
+    @Override
+    public void addHandler(Handler handler) throws SecurityException {
+        LOGGER.warn(MUTATOR_DISABLED, "addHandler", handler);
+        super.addHandler(handler);
+    }
+
+    @Override
+    public void removeHandler(Handler handler) throws SecurityException {
+        LOGGER.warn(MUTATOR_DISABLED, "removeHandler", handler);
+        super.removeHandler(handler);
+    }
+
+    @Override
+    public void setResourceBundle(ResourceBundle bundle) {
+        LOGGER.warn(
+                "Ignoring call to `j.u.l.Logger.setResourceBundle({})`, since `o.a.l.l.jul.LogManager` currently does not support resource bundles.",
+                bundle);
+        super.setResourceBundle(bundle);
+    }
+
     /**
      * Unsupported operation.
      *

log4j-jul/src/test/java/org/apache/logging/log4j/jul/test/AbstractLoggerTest.java

@@ -19,6 +19,9 @@
 import static org.assertj.core.api.Assertions.assertThat;
 
 import java.util.List;
+import java.util.ResourceBundle;
+import java.util.logging.ConsoleHandler;
+import java.util.logging.Filter;
 import java.util.logging.Logger;
 import org.apache.logging.log4j.Level;
 import org.apache.logging.log4j.core.LogEvent;
@@ -240,6 +243,67 @@ public void testSetAndGetLevel() {
         }
     }
 
+    /**
+     * The value of `useParentHandlers` should be recorded even if it is not effective.
+     */
+    @Test
+    public void testSetUseParentHandlers() {
+        final Logger logger = Logger.getLogger(AbstractLoggerTest.class.getName() + ".testSetUseParentHandlers");
+
+        for (boolean useParentHandlers : new boolean[] {false, true}) {
+            logger.setUseParentHandlers(useParentHandlers);
+            assertThat(logger.getUseParentHandlers()).isEqualTo(useParentHandlers);
+        }
+    }
+
+    /**
+     * The programmatically configured handlers should be recorded, even if they are not used.
+     */
+    @Test
+    public void testAddAndRemoveHandlers() {
+        final Logger logger = Logger.getLogger(AbstractLoggerTest.class.getName() + ".testAddAndRemoveHandlers");
+
+        assertThat(logger.getHandlers()).isEmpty();
+        // Add a handler
+        ConsoleHandler handler = new ConsoleHandler();
+        logger.addHandler(handler);
+        assertThat(logger.getHandlers()).hasSize(1).containsExactly(handler);
+        // Remove handler
+        logger.removeHandler(handler);
+        assertThat(logger.getHandlers()).isEmpty();
+    }
+
+    /**
+     * The programmatically configured filters should be recorded, even if they are not used.
+     */
+    @Test
+    public void testSetFilter() {
+        final Logger logger = Logger.getLogger(AbstractLoggerTest.class.getName() + ".testSetFilter");
+
+        assertThat(logger.getFilter()).isNull();
+        // Set filter
+        Filter denyAllFilter = record -> false;
+        logger.setFilter(denyAllFilter);
+        assertThat(logger.getFilter()).isEqualTo(denyAllFilter);
+        // Remove filter
+        logger.setFilter(null);
+        assertThat(logger.getFilter()).isNull();
+    }
+
+    /**
+     * The programmatically configured resource bundles should be recorded, even if they are not used.
+     */
+    @Test
+    public void testSetResourceBundle() {
+        final Logger logger = Logger.getLogger(AbstractLoggerTest.class.getName() + ".testSetResourceBundle");
+
+        assertThat(logger.getResourceBundle()).isNull();
+        // Set resource bundle
+        ResourceBundle bundle = ResourceBundle.getBundle("testResourceBundle");
+        logger.setResourceBundle(bundle);
+        assertThat(logger.getResourceBundle()).isSameAs(bundle);
+    }
+
     private void testLambdaMessages(final String string) {
         final Logger root = Logger.getLogger(Logger.GLOBAL_LOGGER_NAME);
         root.info(() -> "Test info " + string);

log4j-jul/src/test/resources/testResourceBundle.properties

@@ -0,0 +1,18 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to you under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#      http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+###
+# An empty resource bundle for tests