Fix JTL static analysis issues

Author: vy

log4j-layout-template-json-test/src/test/java/org/apache/logging/log4j/layout/template/json/ThreadLocalRecyclerNestedLoggingTest.java

@@ -38,6 +38,8 @@ public class ThreadLocalRecyclerNestedLoggingTest {
 
     private static final class ThrowableLoggingInGetMessage extends RuntimeException {
 
+        private static final long serialVersionUID = 10127;
+
         private final Logger logger;
 
         private ThrowableLoggingInGetMessage(final Logger logger) {

log4j-layout-template-json-test/src/test/java/org/apache/logging/log4j/layout/template/json/resolver/LevelResolverTest.java

@@ -23,8 +23,6 @@
 import static org.assertj.core.api.Assertions.assertThat;
 
 import org.apache.logging.log4j.Level;
-import org.apache.logging.log4j.Marker;
-import org.apache.logging.log4j.MarkerManager;
 import org.apache.logging.log4j.core.LogEvent;
 import org.apache.logging.log4j.core.impl.Log4jLogEvent;
 import org.apache.logging.log4j.layout.template.json.JsonTemplateLayout;
@@ -49,7 +47,6 @@ void should_work_with_custom_levels() {
                 .build();
 
         // Create the log event.
-        final Marker marker = MarkerManager.getMarker("MARKER");
         Level level = Level.forName("CUSTOM_LEVEL", 250);
         final LogEvent logEvent = Log4jLogEvent.newBuilder().setLevel(level).build();
 

log4j-layout-template-json-test/src/test/java/org/apache/logging/log4j/layout/template/json/resolver/MessageResolverTest.java

@@ -46,7 +46,7 @@
 class MessageResolverTest {
 
     /**
-     * @see <a href="https://issues.apache.org/jira/browse/LOG4J2-3080">LOG4J2-3080</a>
+     * A <a href="https://issues.apache.org/jira/browse/LOG4J2-3080">LOG4J2-3080</a> reproduction.
      */
     @Test
     @LoggerContextSource("messageFallbackKeyUsingJsonTemplateLayout.xml")

log4j-layout-template-json-test/src/test/java/org/apache/logging/log4j/layout/template/json/resolver/StackTraceStringResolverTest.java

@@ -629,6 +629,7 @@ private static final class NonAsciiUtf8MethodNameContainingException extends Run
 
         private static final String NON_ASCII_UTF8_TEXT = "அஆஇฬ๘";
 
+        @SuppressWarnings("StaticAssignmentOfThrowable")
         private static final NonAsciiUtf8MethodNameContainingException INSTANCE = createInstance();
 
         @SuppressWarnings("UnicodeInCode")

log4j-layout-template-json-test/src/test/java/org/apache/logging/log4j/layout/template/json/resolver/TimestampResolverTest.java

@@ -31,7 +31,7 @@
 class TimestampResolverTest {
 
     /**
-     * @see <a href="https://issues.apache.org/jira/browse/LOG4J2-3183">LOG4J2-3183</a>
+     * Reproduces <a href="https://issues.apache.org/jira/browse/LOG4J2-3183">LOG4J2-3183</a>.
      */
     @Test
     void epoch_nanos_should_not_overlap() {

log4j-layout-template-json-test/src/test/java/org/apache/logging/log4j/layout/template/json/util/InstantFormatterTest.java

@@ -58,7 +58,7 @@ void nanoseconds_should_be_formatted() {
     }
 
     /**
-     * @see <a href="https://issues.apache.org/jira/browse/LOG4J2-3614">LOG4J2-3614</a>
+     * Reproduces <a href="https://issues.apache.org/jira/browse/LOG4J2-3614">LOG4J2-3614</a>.
      */
     @Test
     void FastDateFormat_failures_should_be_handled() {

log4j-layout-template-json-test/src/test/java/org/apache/logging/log4j/layout/template/json/util/JsonWriterTest.java

@@ -41,7 +41,7 @@
 import org.assertj.core.api.SoftAssertions;
 import org.junit.jupiter.api.Test;
 
-@SuppressWarnings("DoubleBraceInitialization")
+@SuppressWarnings({"DoubleBraceInitialization", "UnnecessaryStringBuilder"})
 class JsonWriterTest {
 
     private static final JsonWriter WRITER = JsonWriter.newBuilder()

log4j-layout-template-json/src/main/java/org/apache/logging/log4j/layout/template/json/resolver/MessageResolverFactory.java

@@ -20,7 +20,7 @@
 import org.apache.logging.log4j.core.config.plugins.PluginFactory;
 
 /**
- * @see MessageResolver
+ * A {@link MessageResolver} factory.
  */
 @Plugin(name = "MessageResolverFactory", category = TemplateResolverFactory.CATEGORY)
 public final class MessageResolverFactory implements EventResolverFactory {

log4j-layout-template-json/src/main/java/org/apache/logging/log4j/layout/template/json/resolver/TemplateResolverFactories.java

@@ -102,6 +102,7 @@ Map<String, F> populateFactoryByName(
         }
     }
 
+    @SuppressWarnings("TypeParameterUnusedInFormals")
     private static <V, C extends TemplateResolverContext<V, C>, F extends TemplateResolverFactory<V, C>> F castFactory(
             final Class<V> valueClass, final Class<C> contextClass, final TemplateResolverFactory<?, ?> factory) {
         final Class<?> factoryValueClass = factory.getValueClass();

log4j-layout-template-json/src/main/java/org/apache/logging/log4j/layout/template/json/resolver/TemplateResolverInterceptors.java

@@ -16,7 +16,7 @@
  */
 package org.apache.logging.log4j.layout.template.json.resolver;
 
-import java.util.LinkedList;
+import java.util.ArrayList;
 import java.util.List;
 import java.util.Map;
 import java.util.Set;
@@ -71,7 +71,7 @@ List<I> populateInterceptors(
                     final Map<String, PluginType<?>> pluginTypeByName,
                     final Class<V> valueClass,
                     final Class<C> contextClass) {
-        final List<I> interceptors = new LinkedList<>();
+        final List<I> interceptors = new ArrayList<>();
         final Set<String> pluginNames = pluginTypeByName.keySet();
         for (final String pluginName : pluginNames) {
             final PluginType<?> pluginType = pluginTypeByName.get(pluginName);
@@ -100,6 +100,7 @@ List<I> populateInterceptors(
         }
     }
 
+    @SuppressWarnings("TypeParameterUnusedInFormals")
     private static <V, C extends TemplateResolverContext<V, C>, I extends TemplateResolverInterceptor<V, C>>
             I castInterceptor(
                     final Class<V> valueClass,