Skip to content

Commit 9758413

Browse files
committed
now taking all named patterns automatically
Signed-off-by: Roy Ash <[email protected]>
1 parent 3418e4c commit 9758413

File tree

1 file changed

+3
-23
lines changed

1 file changed

+3
-23
lines changed

log4j-core-test/src/test/java/org/apache/logging/log4j/core/pattern/DatePatternConverterTestBase.java

Lines changed: 3 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
import java.util.Calendar;
2727
import java.util.Date;
2828
import java.util.TimeZone;
29+
import java.util.stream.Stream;
2930
import org.apache.logging.log4j.core.AbstractLogEvent;
3031
import org.apache.logging.log4j.core.LogEvent;
3132
import org.apache.logging.log4j.core.time.Instant;
@@ -329,29 +330,8 @@ void testNewInstanceAllowsNullParameter() {
329330
DatePatternConverter.newInstance(null); // no errors
330331
}
331332

332-
private static final String[] PATTERN_NAMES = {
333-
"ABSOLUTE",
334-
"ABSOLUTE_MICROS",
335-
"ABSOLUTE_NANOS",
336-
"ABSOLUTE_PERIOD",
337-
"COMPACT",
338-
"DATE",
339-
"DATE_PERIOD",
340-
"DEFAULT",
341-
"DEFAULT_MICROS",
342-
"DEFAULT_NANOS",
343-
"DEFAULT_PERIOD",
344-
"ISO8601_BASIC",
345-
"ISO8601_BASIC_PERIOD",
346-
"ISO8601",
347-
"ISO8601_OFFSET_DATE_TIME_HH",
348-
"ISO8601_OFFSET_DATE_TIME_HHMM",
349-
"ISO8601_OFFSET_DATE_TIME_HHCMM",
350-
"ISO8601_PERIOD",
351-
"ISO8601_PERIOD_MICROS",
352-
"US_MONTH_DAY_YEAR2_TIME",
353-
"US_MONTH_DAY_YEAR4_TIME"
354-
};
333+
private static final String[] PATTERN_NAMES =
334+
Stream.of(NamedDatePattern.values()).map(Enum::name).toArray(String[]::new);
355335

356336
@Test
357337
void testPredefinedFormatWithoutTimezone() {

0 commit comments

Comments
 (0)