Skip to content

Commit b99df58

Browse files
committed
refactor(1.2-api): migrate to junit5
1 parent 2f6916d commit b99df58

File tree

8 files changed

+101
-60
lines changed

8 files changed

+101
-60
lines changed

log4j-1.2-api/src/test/java/org/apache/log4j/CallerInformationTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,12 @@
2020

2121
import java.util.List;
2222
import org.apache.logging.log4j.core.test.appender.ListAppender;
23-
import org.apache.logging.log4j.core.test.junit.LoggerContextSource;
2423
import org.apache.logging.log4j.core.test.junit.Named;
24+
import org.apache.logging.log4j.core.test.junit.LoggerContextSource;
2525
import org.junit.jupiter.api.Test;
2626

2727
// config from log4j-core test-jar
28-
@LoggerContextSource(value = "log4j2-calling-class.xml", timeout = 10)
28+
@LoggerContextSource(value = "log4j2-calling-class.xml")
2929
public class CallerInformationTest {
3030

3131
@Test

log4j-1.2-api/src/test/java/org/apache/log4j/CategoryTest.java

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,13 @@
4444
import org.apache.logging.log4j.util.Constants;
4545
import org.apache.logging.log4j.util.Strings;
4646
import org.junit.jupiter.api.AfterAll;
47+
<<<<<<< HEAD
4748
import org.junit.jupiter.api.BeforeAll;
4849
import org.junit.jupiter.api.BeforeEach;
50+
=======
51+
import org.junit.jupiter.api.BeforeEach;
52+
import org.junit.jupiter.api.BeforeAll;
53+
>>>>>>> b0238ae0ee (refactor(1.2-api): migrate to junit5)
4954
import org.junit.jupiter.api.Test;
5055

5156
/**
@@ -346,11 +351,25 @@ public void testAddAppender() {
346351
logger.addAppender(appender);
347352
// Root logger
348353
rootLogger.info("testAddLogger");
354+
<<<<<<< HEAD
349355
assertEquals(++count, version1Appender.getEvents().size(), "adding at root works");
350356
assertEquals(0, appender.getEvents().size(), "adding at child works");
351357
// Another logger
352358
logger.info("testAddLogger2");
353359
assertEquals(++count, version1Appender.getEvents().size(), "adding at root works");
360+
=======
361+
assertEquals(
362+
++count,
363+
version1Appender.getEvents().size(),
364+
"adding at root works");
365+
assertEquals(0, appender.getEvents().size(), "adding at child works");
366+
// Another logger
367+
logger.info("testAddLogger2");
368+
assertEquals(
369+
++count,
370+
version1Appender.getEvents().size(),
371+
"adding at root works");
372+
>>>>>>> b0238ae0ee (refactor(1.2-api): migrate to junit5)
354373
assertEquals(1, appender.getEvents().size(), "adding at child works");
355374
// Call appenders
356375
final LoggingEvent event = new LoggingEvent();

log4j-1.2-api/src/test/java/org/apache/log4j/LoggerTest.java

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,18 @@
1616
*/
1717
package org.apache.log4j;
1818

19+
<<<<<<< HEAD
1920
import static org.hamcrest.MatcherAssert.assertThat;
2021
import static org.hamcrest.Matchers.equalTo;
2122
import static org.hamcrest.Matchers.is;
2223
import static org.hamcrest.Matchers.nullValue;
24+
=======
25+
import static org.hamcrest.Matchers.nullValue;
26+
import static org.hamcrest.Matchers.equalTo;
27+
import static org.hamcrest.Matchers.is;
28+
import static org.hamcrest.MatcherAssert.assertThat;
29+
30+
>>>>>>> b0238ae0ee (refactor(1.2-api): migrate to junit5)
2331
import static org.junit.jupiter.api.Assertions.assertEquals;
2432
import static org.junit.jupiter.api.Assertions.assertFalse;
2533
import static org.junit.jupiter.api.Assertions.assertNotNull;
@@ -39,8 +47,13 @@
3947
import org.apache.logging.log4j.core.layout.PatternLayout;
4048
import org.apache.logging.log4j.core.test.appender.ListAppender;
4149
import org.junit.jupiter.api.AfterAll;
50+
<<<<<<< HEAD
4251
import org.junit.jupiter.api.BeforeAll;
4352
import org.junit.jupiter.api.BeforeEach;
53+
=======
54+
import org.junit.jupiter.api.BeforeEach;
55+
import org.junit.jupiter.api.BeforeAll;
56+
>>>>>>> b0238ae0ee (refactor(1.2-api): migrate to junit5)
4457
import org.junit.jupiter.api.Test;
4558

4659
/**

log4j-1.2-api/src/test/java/org/apache/log4j/LoggingTest.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,11 @@
1919
import static org.junit.jupiter.api.Assertions.assertEquals;
2020
import static org.junit.jupiter.api.Assertions.assertNotNull;
2121

22+
<<<<<<< HEAD
2223
import org.apache.logging.log4j.core.test.junit.LoggerContextSource;
24+
=======
25+
import org.apache.logging.log4j.core.test.junit.LoggerContextSource;;
26+
>>>>>>> b0238ae0ee (refactor(1.2-api): migrate to junit5)
2327
import org.junit.jupiter.api.Test;
2428

2529
/**

log4j-1.2-api/src/test/java/org/apache/log4j/MDCTestCase.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,13 @@
1818

1919
import static org.junit.jupiter.api.Assertions.assertEquals;
2020

21+
<<<<<<< HEAD
2122
import org.junit.jupiter.api.AfterEach;
2223
import org.junit.jupiter.api.BeforeEach;
24+
=======
25+
import org.junit.jupiter.api.BeforeEach;
26+
import org.junit.jupiter.api.AfterEach;
27+
>>>>>>> b0238ae0ee (refactor(1.2-api): migrate to junit5)
2328
import org.junit.jupiter.api.Test;
2429

2530
public class MDCTestCase {

log4j-1.2-api/src/test/java/org/apache/log4j/NDCTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020

2121
import java.util.Stack;
2222
import org.apache.logging.log4j.util.Strings;
23+
import static org.junit.jupiter.api.Assertions.assertEquals;
2324
import org.junit.jupiter.api.Test;
2425

2526
public class NDCTest {

log4j-1.2-api/src/test/java/org/apache/log4j/config/AbstractLog4j1ConfigurationConverterTest.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,12 @@
2929
import java.util.List;
3030
import javax.xml.parsers.DocumentBuilderFactory;
3131
import javax.xml.parsers.ParserConfigurationException;
32+
// import org.junit.jupiter.params.ParameterizedTest;
33+
// import org.junit.jupiter.params.provider.MethodSource;
34+
import org.junit.jupiter.api.Test;
35+
36+
// import org.junit.runner.RunWith;
37+
// import org.junit.runners.Parameterized;
3238
import org.xml.sax.SAXException;
3339
// import org.junit.jupiter.params.ParameterizedTest;
3440
// import org.junit.jupiter.params.provider.MethodSource;

0 commit comments

Comments
 (0)