Fix RollingRandomAppenderDirectWriteAndSwitchDirectoryTest

Attempt to fix the flaky `RollingRandomAppenderDirectWriteAndSwitchDirectoryTest`.

Author: ppkarwasz

log4j-core-test/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingRandomAppenderDirectWriteAndSwitchDirectorTest.java renamed to log4j-core-test/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingRandomAppenderDirectWriteAndSwitchDirectoryTest.java

@@ -16,33 +16,36 @@
  */
 package org.apache.logging.log4j.core.appender.rolling;
 
-import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.assertj.core.api.Assertions.assertThat;
 
-import java.io.File;
+import java.nio.file.Path;
 import java.time.LocalTime;
 import org.apache.logging.log4j.core.Logger;
 import org.apache.logging.log4j.core.LoggerContext;
 import org.apache.logging.log4j.core.test.junit.LoggerContextSource;
 import org.apache.logging.log4j.test.junit.CleanUpDirectories;
+import org.apache.logging.log4j.test.junit.TempLoggingDir;
 import org.junit.jupiter.api.Test;
 
-@CleanUpDirectories(RollingRandomAppenderDirectWriteAndSwitchDirectorTest.DIR)
-class RollingRandomAppenderDirectWriteAndSwitchDirectorTest {
+@CleanUpDirectories(RollingRandomAppenderDirectWriteAndSwitchDirectoryTest.DIR)
+class RollingRandomAppenderDirectWriteAndSwitchDirectoryTest {
     public static final String DIR = "target/rolling-random-direct-switch-director";
 
+    @TempLoggingDir
+    private Path loggingPath;
+
     @Test
-    @LoggerContextSource(value = "log4j-rolling-random-direct-switch-director.xml", timeout = 10)
+    @LoggerContextSource(value = "appender/rolling/RollingRandomAppenderDirectWriteAndSwitchDirectoryTest.xml", timeout = 10)
     void testAppender(final LoggerContext context) throws Exception {
-        final Logger logger = context.getLogger(RollingRandomAppenderDirectWriteAndSwitchDirectorTest.class.getName());
+        final Logger logger = context.getLogger(RollingRandomAppenderDirectWriteAndSwitchDirectoryTest.class.getName());
         final LocalTime start = LocalTime.now();
         LocalTime end;
         do {
             end = LocalTime.now();
             logger.info("test log");
             Thread.sleep(100);
         } while (start.getSecond() == end.getSecond());
-
-        final File nextLogFile = new File(String.format("%s/%d/%d.log", DIR, end.getSecond(), end.getSecond()));
-        assertTrue(nextLogFile.exists(), "nextLogFile not created");
+        Path nextLogPath = loggingPath.resolve(String.format("%d/%d.log", end.getSecond(), end.getSecond()));
+        assertThat(nextLogPath).as("Archived log for second %s", end.getSecond()).exists();
     }
 }

log4j-core-test/src/test/resources/appender/rolling/RollingRandomAppenderDirectWriteAndSwitchDirectoryTest.xml

@@ -0,0 +1,36 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+  ~ Licensed to the Apache Software Foundation (ASF) under one or more
+  ~ contributor license agreements.  See the NOTICE file distributed with
+  ~ this work for additional information regarding copyright ownership.
+  ~ The ASF licenses this file to you under the Apache License, Version 2.0
+  ~ (the "License"); you may not use this file except in compliance with
+  ~ the License.  You may obtain a copy of the License at
+  ~
+  ~      http://www.apache.org/licenses/LICENSE-2.0
+  ~
+  ~ Unless required by applicable law or agreed to in writing, software
+  ~ distributed under the License is distributed on an "AS IS" BASIS,
+  ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  ~ See the License for the specific language governing permissions and
+  ~ limitations under the License.
+  -->
+<Configuration xmlns="https://logging.apache.org/xml/ns"
+               xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+               xsi:schemaLocation="
+                   https://logging.apache.org/xml/ns
+                   https://logging.apache.org/xml/ns/log4j-config-2.xsd"
+               name="RollingRandomAppenderDirectWriteAndSwitchDirectoryTest">
+  <Appenders>
+    <RollingRandomAccessFile name="ROLLING"
+                             filePattern="${test:logging.path}/%d{s}/%d{s}.log">
+      <PatternLayout pattern="%d{s.SSS} %m%n"/>
+      <TimeBasedTriggeringPolicy/>
+    </RollingRandomAccessFile>
+  </Appenders>
+  <Loggers>
+    <Root level="DEBUG">
+      <AppenderRef ref="ROLLING"/>
+    </Root>
+  </Loggers>
+</Configuration>