Move JNDI DataSource
to separate module
#2915
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We move the
DataSource
connection source to a new modulelog4j-jdbc-jndi
.The main rationale for this change is to remove the optional dependency on
log4j-jndi
fromlog4j-jdbc
.This change forces users to opt-in for the JNDI
DataSource
by addinglog4j-jdbc-jndi
to their classpath.After this change, the
log4j-jdbc
artifact contains:JDBC
Appender,DriverManager
,Closes #1914