LoggerConfig - make LoggerConfig#clearAppenders() public?

[JWT007]

LoggerConfig (Log4j 2.24.1)

I am not sure if this would be considered a bug or works-as-designed.

I am currently implementing a custom Configuration which does not inherit from AbstractConfiguration- but I am borrowing a lot of the behaviour from AbstractConfiguration.

In the 'AbstractConfiguration#stop()' method, the appenders are cleared from all LoggerConfigs after stopping the appenders.

This uses the package-protected LoggerConfig#clearAppenders() method.

LoggerConfig

protected void clearAppenders() {
    do {
        final AppenderControl[] original = appenders.clear();
        for (final AppenderControl ctl : original) {
            cleanupFilter(ctl);
        }
    } while (!appenders.isEmpty());
}

Since this is package-protected; I cannot provide the same functionality with a custom Configuration implementation.

NOTE: Why am I doing this? My implementation is not Node based. I am capturing all configuration from the configuration XML so that I will be able to write a new XML at runtime with changes added from an Admin-Client UI (i.e. new/updated Loggers/Appenders).

My workaround is a static utility method in a custom-class pushed into the LoggerConfig package - which will only work as long as we are not using Java module-system.

[JWT007]

@ppkarwasz - my use-case has changed - I don't need this workaround anymore.

Since I go no feedback on whether or not it was a good idea I am closing this issue (for now). 😊

[ppkarwasz]

@JWT007,

In the 'AbstractConfiguration#stop()' method, the appenders are cleared from all LoggerConfigs after stopping the appenders.

This uses the package-protected LoggerConfig#clearAppenders() method.

I am not eager exposing new public methods, but we should probably implement the stop() method in LoggerConfig and call clearAppenders from there.