Skip to content

Conversation

JWT007
Copy link
Contributor

@JWT007 JWT007 commented Feb 11, 2025

[#3215]

Returns null if the 'replacement' parameter is null.

  • per other builder methods in Log4j a invalid input parameter should result in a fast-fail returning null
  • added changelog for 2.25.0

Copy link
Contributor

@ppkarwasz ppkarwasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

github-actions bot commented Feb 16, 2025

Job Requested goals Build Tool Version Build Outcome Build Scan®
build-macos-latest clean install 3.9.8 Build Scan PUBLISHED
build-ubuntu-latest clean install 3.9.8 Build Scan PUBLISHED
build-windows-latest clean install 3.9.8 Build Scan PUBLISHED
Generated by gradle/develocity-actions

@JWT007
Copy link
Contributor Author

JWT007 commented Feb 16, 2025

@ppkarwasz - moved changelog to .2.x.x per otther code-review

@ppkarwasz ppkarwasz added this to the 2.25.0 milestone Apr 13, 2025
@ppkarwasz
Copy link
Contributor

@JWT007, can you rebase it with signatures and merge it?

JWT007 added 2 commits May 25, 2025 15:25
…eateRegexReplacement (apache#3215)

* per other builder methods in Log4j a invalid input parameter should result in a fas-fail returning null
@ppkarwasz ppkarwasz force-pushed the bugfix/LOG4J-3215 branch from 59bc4b5 to c29e67e Compare May 25, 2025 13:26
@ppkarwasz ppkarwasz enabled auto-merge (squash) May 25, 2025 13:27
@ppkarwasz ppkarwasz merged commit 78d4cb8 into apache:2.x May 25, 2025
7 checks passed
@github-project-automation github-project-automation bot moved this from To triage to Done in Log4j bug tracker May 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants