Skip to content

Conversation

ppkarwasz
Copy link
Contributor

This is a short workaround for the compatibility issues between merge-dependabot and branch protection rules.

Commits pushed by a GitHub workflow don't trigger other workflows, so Dependabot PRs cannot be merged if the workflow manages to add a changelog file.

This is a short workaround for the compatibility issues between `merge-dependabot` and branch protection rules.

Commits pushed by a GitHub workflow don't trigger other workflows, so Dependabot PRs cannot be merged if the workflow manages to add a changelog file.
@vy
Copy link
Member

vy commented May 3, 2025

@ppkarwasz, what is long-term solution to this problem?

@ppkarwasz
Copy link
Contributor Author

what is long-term solution to this problem?

The main problem to solve is how to trigger a build on the commit with the changelog. I haven't test any of these, which is why I call the "longterm" solutions:

  1. We could try to trigger the build using workflow_run like in develocity-publish-build-scans.yaml.
  2. We could try to trigger the build, when the PR is approved.
  3. We could try using labels.

@vy
Copy link
Member

vy commented May 19, 2025

@ppkarwasz, can we close this issue since we agreed on a forward path to make this work?

@ppkarwasz ppkarwasz closed this May 19, 2025
@github-project-automation github-project-automation bot moved this from To triage to Done in Log4j bug tracker May 19, 2025
@ppkarwasz ppkarwasz deleted the fix/2.x/disable-merge-dependabot branch May 19, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants